From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17EF7EC4; Sun, 24 Mar 2024 00:02:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711238557; cv=none; b=qhB7mRDX39+5rzoejonqIoRZa5Aqz+7wEeFGyEKuc1fqWlr9sGPll/xvl6ri8XmiYdxY5O6YF+sCSuZ1x3KPoJjGBysTdzHFtPH+BwKEqoOFl4dzXdCqpNZ4l94suJtwpNj+IV95yBn46eS8GCEtzm6OSVxHbEN+dI3/Tq021iQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711238557; c=relaxed/simple; bh=Fi9jn9xhea3Eqr2Fwon3wNGvHYW3Esicm6biLdBkR+s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F/YMGBftXXpyOtkUWtTiVW4NfIXQ4IpzbMsZsIPKuPP2LrYFEdo0qM2mKHOKeTAxAQ/3l5DY7t9/oRIL/5Jsn/B348QPN5bf0G6YjKodhE9lslxbhzm3WKRxa43y6mRIs6lbWqJpRkY8x097AUuz/0eIHxysdaWJtK6XHeI2C2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mblCrbov; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mblCrbov" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a46cd9e7fcaso382602766b.1; Sat, 23 Mar 2024 17:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711238554; x=1711843354; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NrERVl7fRobrwC10yk2s2onot9WRsDJnDzX1zxJyjwk=; b=mblCrbov0d6HgLCOGECkakEzlVJ8vN4+W+ARF6SfS0LMBt+fKxvKY+7P9scexEK0mH 6LI8RLLB3Bvf2405PiocW9sqz6UQizgSBfDCwMV4qISpOngNW3gufXmPW9ysOPoxx6gz aGAoRjtLGs8v5Vl8KODFOIveIBGsfntlPf+XoL/ms5N5ZH+8PY70fnvZlB/j4ppBz+39 1Q2vyjOucuGjHfrUxrlw7a1OsMX2JJwfYkQw2c1YZwIhEJbf0/uskfaZdwlyQfCRCcn8 CRjy8M+CG7M5LBNKsEiQEstIiIwwmAIAM15o3d9/pcnfkK12BTH1+zR4OBUSq68wkCN0 3Ftw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711238554; x=1711843354; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NrERVl7fRobrwC10yk2s2onot9WRsDJnDzX1zxJyjwk=; b=Hbz/3f13jYTJDjE3e2CxOWdIe37/zz1GMraQIuIFwy7GwkP995aXIRbqPUx4bWs6ZL uUWc4HTe9Heot7KgJ2p6gw+u/d3jDYPt2M9k+Hxeme9pUgjV3g7UU2AR0LReeG4cGjk5 A4AHOaeg3PTt99Ofq4kH73t5Iw5UQvX1mdsmoQvFmTAgep6Ui9YvCzbW6M18KUhaR2vi TLxdRNnIwZfS1CF6c2OebtrqzEgQ8MjJKx7wexwZFAytq0Sabq8thmIbZfzY91b5SDe5 5PwzbWmJxDgQ8H3h5Izpj5t6WNcToHTkv2sB8rOhdQgtnRzarYHYLUE8/6awgqClgrv4 MtQQ== X-Forwarded-Encrypted: i=1; AJvYcCXEEvVSQ7Kh6MbYG1b+3laeS6xNw7pCfR3N2GM/ivRASmAriKqqGiaZVwW+Mz7fIbODO6PqXViY87VoG/uckJQsyBaaUy4Ms0ZVbn2BuFx52iqUN+j35HG9PddREGwiyUlgKd2LsD69ouFTnd8tOJAXT5CIkUUde20tL9n1TCUHACn4Xg== X-Gm-Message-State: AOJu0Yz4DNjmUqwGPerYpeFahTxlKKH/vAcnLK4dV3tk9ePE1TtCuuH0 6tuZxcGf7SNu/bqTp9pUjrOVtNb9QR3ynP0of68S5gvdZPyEOL/s X-Google-Smtp-Source: AGHT+IFhO6YVTUasRqpMP/iFm84HriWglmNUAWmJyzycChzZD235X9oPbIcfDaXRaGTIhzAhvr36qw== X-Received: by 2002:a17:906:240c:b0:a46:bd1d:d9c9 with SMTP id z12-20020a170906240c00b00a46bd1dd9c9mr2383059eja.31.1711238554112; Sat, 23 Mar 2024 17:02:34 -0700 (PDT) Received: from ?IPV6:2a02:8389:41cf:e200:5b00:ff22:8933:f27e? (2a02-8389-41cf-e200-5b00-ff22-8933-f27e.cable.dynamic.v6.surfer.at. [2a02:8389:41cf:e200:5b00:ff22:8933:f27e]) by smtp.gmail.com with ESMTPSA id bh9-20020a170906a0c900b00a461b1e814asm1401032ejb.130.2024.03.23.17.02.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Mar 2024 17:02:33 -0700 (PDT) Message-ID: <6e68e0ca-2f3e-41a7-bb96-00fbdadc4436@gmail.com> Date: Sun, 24 Mar 2024 01:02:31 +0100 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dt-bindings: rtc: armada-380-rtc: convert to dtschema To: Alexandre Belloni Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Baruch Siach , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240323-rtc-yaml-v1-0-0c5d12b1b89d@gmail.com> <20240323-rtc-yaml-v1-1-0c5d12b1b89d@gmail.com> <20240323233742bfb9ba4a@mail.local> Content-Language: en-US, de-AT From: Javier Carrasco In-Reply-To: <20240323233742bfb9ba4a@mail.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/24/24 00:37, Alexandre Belloni wrote: > On 23/03/2024 23:46:13+0100, Javier Carrasco wrote: >> Convert existing binding to dtschema to support validation. >> >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - interrupts >> + >> +additionalProperties: false > > This is not correct because at least start-year is supported. Please > check for all your other submissions too. > allOf: - $ref: rtc.yaml# is missing, and then unvealuatedProperties: false to account for that. "start-year" is read in the RTC base class, so I wonder why so many RTC bindings add a reference to rtc.yaml, but then use additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + rtc@a3800 { >> + compatible = "marvell,armada-380-rtc"; >> + reg = <0xa3800 0x20>, <0x184a0 0x0c>; >> + reg-names = "rtc", "rtc-soc"; >> + interrupts = ; >> + }; >> >> -- >> 2.40.1 >> > Thanks and best regards, Javier Carrasco From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8267C54E67 for ; Sun, 24 Mar 2024 00:03:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZjQ1E2CqjmA6K2FKsgOyC052ahLxHjvn0pQhY+kXS7c=; b=ucJ9xnVNwzMXEC DwK/iVSjSF+irG3oG059GRfUOt57cOSfYcKH3zSnhghNh0L7J+0GJtxXY9WormgKH2grjYS8G2oz/ 9hKtpXo+eMd+G3STJT/nhPNqJPI8vAZuf12p0MzdIDcwOybI0P9yDIwJvYafm2VVDCTFq6ZVgFNRL UYTZqLLaZ4AvqALdD2uTi3cqT+XRk+jlZNimGuQth6xv5QuEPu0BamNzsJKjvN1qYIJ0Gj6CDB29P rwf1e18FvjLrnjFjlB/Fyb2zn6ey1YjiU/xu2TeEQqFeVmYAgXi3PogcDp+yoNHDcTZiYXH2yO/2r vinNCn8vXmEZ3gCXqkQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1roBJw-0000000BR8q-1yRX; Sun, 24 Mar 2024 00:02:40 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1roBJt-0000000BR8K-16JR for linux-arm-kernel@lists.infradead.org; Sun, 24 Mar 2024 00:02:38 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a46cd9e7fcaso382602866b.1 for ; Sat, 23 Mar 2024 17:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711238554; x=1711843354; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NrERVl7fRobrwC10yk2s2onot9WRsDJnDzX1zxJyjwk=; b=GfjjBJv751CWyN4OTAyuqJVStniyJ/0FENRgloI7yjZwzztLKOoRK+bqEkRxdffL0k 61c8djXhCVftUL336rOWzGlKI4fOryFDpnbfz/38UcVlPIPifsKxIQiCjuOFqHS+uFFB 34fUi1Geic4rAnLuJ5sk2oo2Z2B5JahnusTgcUiae8bTef2sHYBA8xmNS1OViY22dmTc fRmYUKOEJg1COMMornkJLoagbi7ZP44T2T9I5lrFU975dzOndXMrAEH0vY+1TduOEsiK 6rNdugKNGHSr9LVK5jGWdcpHKxu4Te2A6angvBc7m/1C7bRPYE2yvRUuU3eVXKjV2raq oDkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711238554; x=1711843354; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NrERVl7fRobrwC10yk2s2onot9WRsDJnDzX1zxJyjwk=; b=jrrmiJcucsZkJwCgQiM5C0vYZEP5YIbh9VJE5GoWz3eRgTXEq3CHMF4+9h1nwhNiWu gPi+zIlzKt46/PsE+e+fIxIgSvuefgGpM650H7nmJxDIYZP3Vep1snxBYMwYcLW2gjHe 1rhq/PC+GB1+4N5cjNdB56RRooFL78AheR9vHq59ChufgT/VWnK1R0Nni1/AtExcPbZN mrgUKLQp42NGcbASyXak21HU3phmbW4B0Kfx7h0FrkkNmyexdJUA97MWc8hhCYMZeWOn 0pud59M0iAQG7l/ezqi3f/3XUcRSsXDCIyaLy/seNICsYi2sim6yGOsd0eIAP7lzH/J8 AYWw== X-Forwarded-Encrypted: i=1; AJvYcCV8URnPzawVPbMlE1jZPiCtiBvzw3PHgOpxDcw2MHgYzbOScDp9kptglYIThOFKu0ZPcH7m81It4wL0WLxOWoFrkO6ZxTe7iL1/q001PLN8y03CKtQ= X-Gm-Message-State: AOJu0YxXRVJbF4O5rXYSpv+vaE6XetcVKjJzK80TjRrlXQG9NcEbCC5C fnDGv8F0gRxhuZ1X4C5dBTbrFHkAGUZONolJUrFJCO7PrsSv04kQIxrZi77KuRdfnw== X-Google-Smtp-Source: AGHT+IFhO6YVTUasRqpMP/iFm84HriWglmNUAWmJyzycChzZD235X9oPbIcfDaXRaGTIhzAhvr36qw== X-Received: by 2002:a17:906:240c:b0:a46:bd1d:d9c9 with SMTP id z12-20020a170906240c00b00a46bd1dd9c9mr2383059eja.31.1711238554112; Sat, 23 Mar 2024 17:02:34 -0700 (PDT) Received: from ?IPV6:2a02:8389:41cf:e200:5b00:ff22:8933:f27e? (2a02-8389-41cf-e200-5b00-ff22-8933-f27e.cable.dynamic.v6.surfer.at. [2a02:8389:41cf:e200:5b00:ff22:8933:f27e]) by smtp.gmail.com with ESMTPSA id bh9-20020a170906a0c900b00a461b1e814asm1401032ejb.130.2024.03.23.17.02.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Mar 2024 17:02:33 -0700 (PDT) Message-ID: <6e68e0ca-2f3e-41a7-bb96-00fbdadc4436@gmail.com> Date: Sun, 24 Mar 2024 01:02:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dt-bindings: rtc: armada-380-rtc: convert to dtschema To: Alexandre Belloni Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Baruch Siach , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240323-rtc-yaml-v1-0-0c5d12b1b89d@gmail.com> <20240323-rtc-yaml-v1-1-0c5d12b1b89d@gmail.com> <20240323233742bfb9ba4a@mail.local> Content-Language: en-US, de-AT From: Javier Carrasco In-Reply-To: <20240323233742bfb9ba4a@mail.local> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240323_170237_531942_D4B65F67 X-CRM114-Status: GOOD ( 13.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/24/24 00:37, Alexandre Belloni wrote: > On 23/03/2024 23:46:13+0100, Javier Carrasco wrote: >> Convert existing binding to dtschema to support validation. >> >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - interrupts >> + >> +additionalProperties: false > > This is not correct because at least start-year is supported. Please > check for all your other submissions too. > allOf: - $ref: rtc.yaml# is missing, and then unvealuatedProperties: false to account for that. "start-year" is read in the RTC base class, so I wonder why so many RTC bindings add a reference to rtc.yaml, but then use additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + rtc@a3800 { >> + compatible = "marvell,armada-380-rtc"; >> + reg = <0xa3800 0x20>, <0x184a0 0x0c>; >> + reg-names = "rtc", "rtc-soc"; >> + interrupts = ; >> + }; >> >> -- >> 2.40.1 >> > Thanks and best regards, Javier Carrasco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel