From: Shuah Khan <skhan@linuxfoundation.org>
To: Ba Jing <bajing@cmss.chinamobile.com>, sj@kernel.org
Cc: shuah@kernel.org, damon@lists.linux.dev, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] damon: access_memory_even: remove unused variables
Date: Mon, 23 Sep 2024 10:44:43 -0600 [thread overview]
Message-ID: <6e71e7e2-5b69-488d-b3fc-e547d6b4b042@linuxfoundation.org> (raw)
In-Reply-To: <20240903034300.10443-1-bajing@cmss.chinamobile.com>
On 9/2/24 21:43, Ba Jing wrote:
> These variables are never referenced in the code, just remove it.
remove them?
Add details on how you found this problem in the commit log.
Send v2 with these changes.
>
> Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
> ---
> tools/testing/selftests/damon/access_memory_even.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c
> index 3be121487432..a9f4e9aaf3a9 100644
> --- a/tools/testing/selftests/damon/access_memory_even.c
> +++ b/tools/testing/selftests/damon/access_memory_even.c
> @@ -14,10 +14,8 @@
> int main(int argc, char *argv[])
> {
> char **regions;
> - clock_t start_clock;
> int nr_regions;
> int sz_region;
> - int access_time_ms;
> int i;
>
> if (argc != 3) {
With these changes:
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
prev parent reply other threads:[~2024-09-23 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 3:43 [PATCH] damon: access_memory_even: remove unused variables Ba Jing
2024-09-23 16:36 ` SeongJae Park
2024-09-23 16:44 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e71e7e2-5b69-488d-b3fc-e547d6b4b042@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=bajing@cmss.chinamobile.com \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.