From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEA00C5478C for ; Fri, 1 Mar 2024 12:34:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GnPNR70xwgfpAdPZoMTiMByTtXVF+V73mqcW7fK0rXU=; b=bwxM6aU8T5/csOMlQ2r9yqm/Yc Huq2OaDCT8ppMDRPguYw5UtlvE+hwI4tNRH4yxEVp8ISvnqGZ2Mf2mnkT/ssKr8apeAKan3tMJr9Y 7wex8w+4UVBYy26rELhgr6+vF4yQ4iPq/NY6UaJMprhxKGfRZvj1J/HtFdaSrL4Kr5lDX51jCkANs dzmJPuTtaNF99teKyjAR3i47+4QJnaFUAQTfBlxvST3sAH+IDcLTUi3ODp72G1NvYR+u3CPtpfL98 mWMKHoxVQcnr0OhRTNiSnSYcPzCiDaDnxvCyuFLz2SKaTv+fWH08hRw3V3JIsuT4qgdFyBEPvlDrx 4qmbeajw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg25y-00000000B6t-1Tvk; Fri, 01 Mar 2024 12:34:34 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg25u-00000000B5Q-0gxv; Fri, 01 Mar 2024 12:34:32 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1709296467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uXXrFPwA0W0DulbaMA1x6JuvLaWb0VOrWlzgP3c4M7Q=; b=p5UhcMKc4xU9LuKVQWuvU/QxoXFmMBjrOiQ8NEc6RjpP2+2CQXenPt0qVjtgB3UWmHyK46 UdeRcK5vHBHG27dfzTXYKH2XdYhg8nma+o6WSEt02mHL3CPEYQ5+MlmS7zgLKtTEsYd/x5 8YAZ9nK6fBwVfl6/D/AACEH+KMYt2BzPlfdMWczsjmSaMHhCzcUwCyOrhYiTIdf8WCoX76 sIkFMrEKNc1B0/7ZUkWkvMY0rMV9QIL0w/zoraMLB9assOKRNwk6RL0KfIrNMUJWCY9Pev ueRYy1TSLFVq2cFMYqSeIqQ5He6q18bPYJ61Of82YclwFKRShq4M3vXcODje5w== Date: Fri, 01 Mar 2024 13:34:26 +0100 From: Dragan Simic To: Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] arm64: dts: rockchip: enable built-in thermal monitoring on RK3588 In-Reply-To: References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <20240229-rk-dts-additions-v3-1-6afe8473a631@gmail.com> <8b48eeac7b629c39adc6024ff418724c@manjaro.org> Message-ID: <6e76db0b2e7739176bcea0b90746a35a@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_043430_860296_6AC6C613 X-CRM114-Status: GOOD ( 69.72 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wMy0wMSAxMjoxMCwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4gT24gRnJpLCBNYXIg MSwgMjAyNCBhdCAxMjo1MuKAr1BNIERyYWdhbiBTaW1pYyA8ZHNpbWljQG1hbmphcm8ub3JnPiAK PiB3cm90ZToKPj4gT24gMjAyNC0wMy0wMSAwOToyNSwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4+ ID4gT24gRnJpLCBNYXIgMSwgMjAyNCBhdCA5OjUx4oCvQU0gRHJhZ2FuIFNpbWljIDxkc2ltaWNA bWFuamFyby5vcmc+IHdyb3RlOgo+PiA+PiBPbiAyMDI0LTAzLTAxIDA2OjEyLCBBbGV4ZXkgQ2hh cmtvdiB3cm90ZToKPj4gPj4gPiBPbiBGcmksIE1hciAxLCAyMDI0IGF0IDEyOjIx4oCvQU0gRHJh Z2FuIFNpbWljIDxkc2ltaWNAbWFuamFyby5vcmc+Cj4+ID4+ID4gd3JvdGU6Cj4+ID4+ID4+IE9u IDIwMjQtMDItMjkgMjA6MjYsIEFsZXhleSBDaGFya292IHdyb3RlOgo+PiA+PiA+PiA+IEluY2x1 ZGUgdGhlcm1hbCB6b25lcyBpbmZvcm1hdGlvbiBpbiBkZXZpY2UgdHJlZSBmb3IgUkszNTg4IHZh cmlhbnRzLgo+PiA+PiA+PiA+Cj4+ID4+ID4+ID4gVGhpcyBhbHNvIGVuYWJsZXMgdGhlIFRTQURD IGNvbnRyb2xsZXIgdW5jb25kaXRpb25hbGx5IG9uIGFsbCBib2FyZHMKPj4gPj4gPj4gPiB0byBl bnN1cmUgdGhhdCB0aGVybWFsIHByb3RlY3Rpb25zIGFyZSBpbiBwbGFjZSB2aWEgdGhyb3R0bGlu ZyBhbmQKPj4gPj4gPj4gPiBlbWVyZ2VuY3kgcmVzZXQsIG9uY2UgT1BQcyBhcmUgYWRkZWQgdG8g ZW5hYmxlIENQVSBEVkZTLgo+PiA+PiA+PiA+Cj4+ID4+ID4+ID4gVGhlIGRlZmF1bHQgc2V0dGlu Z3MgKHVzaW5nIENSVSBhcyB0aGUgZW1lcmdlbmN5IHJlc2V0IG1lY2hhbmlzbSkKPj4gPj4gPj4g PiBzaG91bGQgd29yayBvbiBhbGwgYm9hcmRzIHJlZ2FyZGxlc3Mgb2YgdGhlaXIgd2lyaW5nLCBh cyBDUlUgcmVzZXRzCj4+ID4+ID4+ID4gZG8gbm90IGRlcGVuZCBvbiBhbnkgZXh0ZXJuYWwgY29t cG9uZW50cy4gQm9hcmRzIHRoYXQgaGF2ZSB0aGUgVFNIVVQKPj4gPj4gPj4gPiBzaWduYWwgd2ly ZWQgdG8gdGhlIHJlc2V0IGxpbmUgb2YgdGhlIFBNSUMgbWF5IG9wdCB0byBzd2l0Y2ggdG8gR1BJ Two+PiA+PiA+PiA+IHRzaHV0IG1vZGUgaW5zdGVhZCAocm9ja2NoaXAsaHctdHNodXQtbW9kZSA9 IDwxPjspCj4+ID4+ID4+Cj4+ID4+ID4+IFF1aXRlIGZyYW5rbHksIEknbSBzdGlsbCBub3Qgc3Vy ZSB0aGF0IGVuYWJsaW5nIHRoaXMgb24gdGhlIFNvQyBsZXZlbAo+PiA+PiA+PiBpcyB0aGUgd2F5 IHRvIGdvLiAgQXMgSSBhbHJlYWR5IGRlc2NyaWJlZCBpbiBkZXRhaWwsIFs0XSBhY2NvcmRpbmcg dG8KPj4gPj4gPj4gdGhlIFJLMzU4OCBIYXJkd2FyZSBEZXNpZ24gR3VpZGUgdjEuMCBhbmQgdGhl IFJvY2sgNUIgc2NoZW1hdGljLCB3ZQo+PiA+PiA+PiBzaG91bGQgYWN0dWFsbHkgdXNlIEdQSU8t YmFzZWQgaGFuZGxpbmcgZm9yIHRoZSB0aGVybWFsIHJ1bmF3YXlzIG9uCj4+ID4+ID4+IHRoZSBS b2NrIDVCLiAgT3RoZXIgYm9hcmRzIHNob3VsZCBhbHNvIGJlIGludmVzdGlnYXRlZCBpbmRpdmlk dWFsbHksCj4+ID4+ID4+IGFuZCB0aGUgVFNBREMgc2hvdWxkIGJlIGVuYWJsZWQgb24gYSBib2Fy ZC10by1ib2FyZCBiYXNpcy4KPj4gPj4gPgo+PiA+PiA+IFdpdGggYWxsIGR1ZSByZXNwZWN0LCBJ IGRpc2FncmVlLCBoZXJlIGlzIHdoeToKPj4gPj4gPiAgLSBOZWl0aGVyIHRoZSBzY2hlbWF0aWMg bm9yIHRoZSBoYXJkd2FyZSBkZXNpZ24gZ3VpZGUsIG9uIHdoaWNoIHRoZQo+PiA+PiA+IHNjaGVt YXRpYyBzZWVtcyB0byBiZSBiYXNlZCwgcHJlc2NyaWJlcyBhIHBhcnRpY3VsYXIgd2F5IHRvIGhh bmRsZQo+PiA+PiA+IHRoZXJtYWwgcnVuYXdheXMuIFRoZXkgb25seSBwcm92aWRlIHRoZSBwb3Nz aWJpbGl0eSBvZiBHUElPIGJhc2VkCj4+ID4+ID4gcmVzZXRzLCBhbG9uZyB3aXRoIHRoZSBDUlUg YmFzZWQgb25lCj4+ID4+Cj4+ID4+IFBsZWFzZSBub3RlIHRoYXQgb3RoZXIgZG9jdW1lbnRzIGZy b20gUm9ja2NoaXAgYWxzbyBleGlzdC4gIEJlbG93IGlzCj4+ID4+IGEgbGluayB0byBhIHNjcmVl bnNob3QgZnJvbSB0aGUgVGhlcm1hbCBkZXZlbG9wZXIgZ3VpZGUsIHZlcnNpb24gMS4wLAo+PiA+ PiB3aGljaCBkZXNjcmliZXMgdGhlIHdob2xlIHRoaW5nIGZ1cnRoZXIuICBJIGJlbGlldmUgaXQn cyBvYnZpb3VzIHRoYXQKPj4gPj4gdGhlIHRoZXJtYWwgcnVuYXdheSBpcyB0byBiZSB0cmVhdGVk IGFzIGEgYm9hcmQtbGV2ZWwgZmVhdHVyZS4KPj4gPj4KPj4gPj4gLSBodHRwczovL2kuaW1ndXIu Y29tL0lKNmRTQWMucG5nCj4+ID4KPj4gPiBGcmFua2x5LCB0aGF0IHN0aWxsIGRvZXNuJ3QgbWFr ZSBUU0FEQyBwZXIgc2UgYSBib2FyZC1sZXZlbCB0aGluZyBJTU8uCj4+ID4gVGhlIG9ubHkgdGhp bmcgdGhhdCBpcyBib2FyZC1sZXZlbCBpcyB0aGUgd2lyaW5nIG9mIEdQSU8gYmFzZWQgcmVzZXRz LAo+PiA+IHdoaWNoIEkgZnVsbHkgYWdyZWUgc2hvdWxkIGdvIHRvIGJvYXJkIC5kdHMgZm9yIGJv YXJkcyB0aGF0IHN1cHBvcnQKPj4gPiBpdCwgYnV0IHRoYXQncyBub3QgcGFydCBvZiB0aGUgY3Vy cmVudCBkZWZhdWx0cyBhbmQgY2FuIGJlIHNhZmVseQo+PiA+IGFkZGVkIGxhdGVyLgo+PiA+Cj4+ ID4gVFNBREMgaXMgaW5zaWRlIHRoZSBTb0MuIENSVSBpcyBpbnNpZGUgdGhlIFNvQy4gVGhleSB3 b3JrIGp1c3QgZmluZQo+PiA+IGZvciBhIHRoZXJtYWwgcmVzZXQsIGV2ZW4gaWYgbm8gZGVkaWNh dGVkIHJlc2V0IGxvZ2ljIGlzIHdpcmVkIG9uIHRoZQo+PiA+IGJvYXJkLiBJIHJlYWxseSBkb24n dCBzZWUgYW55IGRvd25zaWRlcyBpbiBoYXZpbmcgVFNBREMgZW5hYmxlZCBieQo+PiA+IGRlZmF1 bHQgd2l0aCBDUlUgYmFzZWQgcmVzZXRzOgo+PiA+IC0gaXQncyBhIHNhZmUgZGVmYXVsdCAoaS5l LiBJIGNhbm5vdCB0aGluayBvZiBhbnkgY29uZmlndXJhdGlvbiBvciB1c2UKPj4gPiBjYXNlIHdo ZXJlIGVuYWJsZWQtYnktZGVmYXVsdCBUU0FEQyBkb2VzIGFueSBoYXJtKQo+PiA+IC0gaXQncyBz YWZlciB0aGFuIGFjY2lkZW50YWxseSBmb3JnZXR0aW5nIHRvIGVuYWJsZSBUU0FEQyAoYXMgaXQg YWRkcwo+PiA+IHRoZXJtYWwgcHJvdGVjdGlvbiB3aGljaCBpcyBvdGhlcndpc2UgbWlzc2luZykK Pj4gPiAtIGl0IHdpbGwgd29yayBvbiBhbGwgYm9hcmRzIChldmVuIGlmIGl0IGRvZXNuJ3QgdXRp bGl6ZSB0aGUgZnVsbAo+PiA+IGhhcmR3YXJlIGZ1bmN0aW9uYWxpdHkgYnkgaWdub3JpbmcgR1BJ TyByZXNldHMgdGhhdCBzb21lIGJvYXJkcyBhbHNvCj4+ID4gaGF2ZSBpbiBhZGRpdGlvbiB0byB0 aGUgQ1JVKQo+PiA+IC0gYW5kIGl0IHJlcXVpcmVzIGZld2VyIG92ZXJyaWRlcyBpbiBib2FyZCAu ZHRzIGZpbGVzCj4+ID4KPj4gPiBTb3VuZHMgbGlrZSBhIG5vLXJlZ3JldCBtb3ZlIHRvIG1lLgo+ PiAKPj4gUGxlYXNlIHNlZSBteSBjb21tZW50cyBiZWxvdy4KPj4gCj4+ID4+IFRvIGJlIGZhaXIs IHRoYXQgdmVyc2lvbiBvZiB0aGUgVGhlcm1hbCBkZXZlbG9wZXIgZ3VpZGUgZGF0ZXMgYmFjayB0 bwo+PiA+PiAyMDE5LCBtZWFuaW5nIHRoYXQgaXQgdGVjaG5pY2FsbHkgYXBwbGllcyB0byB0aGUg UkszMzk5LCBmb3IgZXhhbXBsZSwKPj4gPj4gYnV0IHRoZSBUU0FEQyBhbmQgcmVzZXQgY2lyY3Vp dHJ5IGRlc2lnbiBoYXMgYmFzaWNhbGx5IHJlbWFpbmVkIHRoZQo+PiA+PiBzYW1lIGZvciB0aGUg UkszNTg4Lgo+PiA+Pgo+PiA+PiA+ICAtIE15IHN0cm9uZyBiZWxpZWYgaXMgdGhhdCBkZWZhdWx0 cyAocmVnYXJkbGVzcyBvZiBjb250ZXh0KSBzaG91bGQgYmUKPj4gPj4gPiBzYWZlIGFuZCByZWFz b25hYmxlLCBhbmQgc2hvdWxkIGFsc28gbWluaW1pemUgdGhlIG5lZWQgdG8gb3ZlcnJpZGUKPj4g Pj4gPiB0aGVtCj4+ID4+Cj4+ID4+IFBsZWFzZSBub3RlIHRoYXQgdGhlIFRTQURDIGlzIGRpc2Fi bGVkIGluIHRoZSBSSzMzOTkgU29DIGR0c2ksIHNvCj4+ID4+IGhhdmluZwo+PiA+PiBpdCBkaXNh YmxlZCBpbiB0aGUgUkszNTg4KHMpIFNvQyBkdHNpIHdvdWxkIHByb3ZpZGUgc29tZSBjb25zaXN0 ZW5jeS4KPj4gPgo+PiA+IEknbSBoYXBweSB0byBwcm9kdWNlIGEgcGF0Y2ggdG8gcmV2ZXJzZSB0 aGUgbG9naWMgaW4gUkszMzk5IChhbmQgYW55Cj4+ID4gb3RoZXJzIGZvciB0aGF0IG1hdHRlcikg dG8gYWxzbyBoYXZlIFRTQURDIGVuYWJsZWQgYnkgZGVmYXVsdCB0aGVyZSwKPj4gPiB0aHVzIHNh dmluZyBzZXZlcmFsIGxpbmVzIG9mIGNvZGUsIGlmIGl0J3MganVzdCBhYm91dCBjb25zaXN0ZW5j eS4KPj4gCj4+IEJ1dCB3aHkgc2hvdWxkIHdlIGNoYW5nZSBzb21ldGhpbmcgdGhhdCBoYXMgc2Vy dmVkIHVzIGZvciB5ZWFycywgb24KPj4gbXVsdGlwbGUgU29Dcywgd2l0aCB6ZXJvIHRyb3VibGVz IGFuZCB3aXRoIChBRkFJSykgemVybyBib2FyZHMgCj4+IHByb2R1Y2luZwo+PiBwdWZmcyBvZiBi bHVpc2ggc21va2U/Cj4gCj4gVGhhdCdzIGp1c3QgaWYgd2UgYXJlIGNvbmNlcm5lZCBhYm91dCBj b25zaXN0ZW5jeSBhY3Jvc3MgZGlmZmVyZW50IFNvQwo+IHNlcmllcy4gVGhlIHBvaW50IGlzIHRo YXQgSSdtIGhhcHB5IHRvIG1ha2Ugd2hhdGV2ZXIgY2hhbmdlIHdlIGFncmVlCj4gdXBvbiBpbiBh IGNvbnNpc3RlbnQgd2F5IGFjcm9zcyBhbGwgcmVsYXRlZCAuZHRzaS8uZHRzIGZpbGVzIC0gdGh1 cyBubwo+IG5lZWQgdG8gd29ycnkgYWJvdXQgcGFzdCBkZWNpc2lvbnMgdGhhdCBoYXZlIGFscmVh ZHkgYmVlbiBpbXBsZW1lbnRlZAo+IGZvciBvdGhlciBjaGlwcy4gTGV0J3MganVzdCBhZ3JlZSBv biB0aGUgdGVjaG5pY2FsIG1lcml0cyBvZiBvbmUgb3IKPiB0aGUgb3RoZXIgYXBwcm9hY2gsIGxl YXZpbmcgIndlJ3ZlIGJlZW4gZG9pbmcgaXQgZGlmZmVyZW50bHkgZWxzZXdoZXJlIgo+IGFzaWRl IGZvciBub3cuCgpJIHNlZSwgSSdkIGFsc28gYmUgd2lsbGluZyB0byBpbXBsZW1lbnQgc3VjaCBj bGVhbnVwIHBhdGNoZXMuICBUaG91Z2gsCmxldCdzIGFsc28ga2VlcCBpbiBtaW5kIHRoYXQgc29t ZSBwYXN0IGRlY2lzaW9ucyBtaWdodCBoYXZlIHNvbWUgc3Ryb25nCnJlYXNvbnMgYmVoaW5kIHRo ZW0sIHdoaWNoIG1pZ2h0IG5vdCBiZSBvYnZpb3VzLiAgVGhhdCdzIGFub3RoZXIgcmVhc29uCndo eSBJJ20gYWdhaW5zdCBlbmFibGluZyBUU0FEQyBieSBkZWZhdWx0LgoKPj4gPj4gVGhvdWdoLCB0 aGUgUkszMzk5IHN0aWxsIGRvZXMgaXQgaW4gYSBzYWZlIHdheSwgYnkgbW92aW5nIHRoZSBPUFBz Cj4+ID4+IGludG8KPj4gPj4gYSBzZXBhcmF0ZSBkdHNpIGZpbGUsIG5hbWVkIHJrMzM5OS1vcHAu ZHRzaSwgd2hpY2ggdGhlIGJvYXJkIGR0cyBmaWxlcwo+PiA+PiB0aGVuIGluY2x1ZGUgdG9nZXRo ZXIgd2l0aCBlbmFibGluZyB0aGUgVFNBREMuCj4+ID4+Cj4+ID4+IElmIHlvdSBhZ3JlZSwgbGV0 J3MgZW1wbG95IHRoZSBzYW1lIGFwcHJvYWNoIGZvciB0aGUgUkszNTg4KHMpLCBieQo+PiA+PiBo YXZpbmcKPj4gPj4gdGhlIGl0cyBPUFBzIGRlZmluZWQgaW4gYSBzZXBhcmF0ZSBmaWxlLCBuYW1l ZCByazM1ODhzLW9wcC5kdHNpLCBldGMuCj4+ID4KPj4gPiBTZXBhcmF0ZSBmaWxlIGZvciBPUFBz IGlzIGEgZ29vZCBuby1yZWdyZXQgbW92ZSB0byBkZWNsdXR0ZXIgdGhlIFNvQwo+PiA+IGxldmVs IC5kdHNpIChhcyB0aGUgT1BQIHRhYmxlIGlzIGxvbmcgYW5kIGJvcmluZykgLSBoYXBweSB0byBt b3ZlIGl0Cj4+ID4gcmVnYXJkbGVzcyBvZiB0aGUgb3V0Y29tZSBvZiB0aGUgYWJvdmUgVFNBREMg ZGlzY3Vzc2lvbi4gVGhhbmtzIGZvcgo+PiA+IHRoZSBwb2ludGVyIQo+PiAKPj4gWWVhaCwgYnV0 IEknbSBub3Qgc3VyZSB0aGF0IGV2ZXJ5b25lIHdvdWxkIGxpa2UgdGhhdCBraW5kIG9mIAo+PiBz ZXBhcmF0aW9uLgo+PiBJbiBmYWN0LCBzdWNoIHNlcGFyYXRpb24gbWF5IGJlIGZyb3duZWQgdXBv biB1bmxlc3MgaXQncyBuZWNlc3NhcnkuCj4+IAo+PiBBcyBJIGFscmVhZHkgZGVzY3JpYmVkIGlu IGFub3RoZXIgdGhyZWFkLCB0aGUgc2VwYXJhdGlvbiBmb3IgdGhlIAo+PiBSSzMzOTkKPj4gaXMg dGhlcmUgb25seSBiZWNhdXNlIGEgY291cGxlIG9mIGRpZmZlcmVudCB2YXJpYW50cyBvZiB0aGUg UkszMzk5IFNvQwo+PiByZXF1aXJlIGRpZmZlcmVudCBPUFBzLgo+PiAKPj4gPj4gPiAgLSBJbiBj b250ZXh0IG9mIGR0cy9kdHNpLCBhcyBmYXIgYXMgSSB1bmRlcnN0YW5kIHRoZSBnZW5lcmFsIGxv Z2ljCj4+ID4+ID4gYmVoaW5kIHRoZSBzcGxpdCwgdGhlIFNvQyAuZHRzaSBzaG91bGQgY29udGFp biBhbGwgdGhlIHRoaW5ncyB0aGF0IGFyZQo+PiA+PiA+IGZ1bGx5IGNvbnRhaW5lZCB3aXRoaW4g dGhlIFNvQyBhbmQgZG8gbm90IGRlcGVuZCBvbiB0aGUgd2lyaW5nIG9mIGEKPj4gPj4gPiBwYXJ0 aWN1bGFyIGJvYXJkIG9yIGl0cyB0YXJnZXQgdXNlIGNhc2UuIEJvYXJkcyB0aGVuCj4+ID4+ID4g YWRkL3JlbW92ZS9vdmVycmlkZSBzZXR0aW5ncyB0byBtYXRjaCB0aGVpciB3aXJpbmcgYW5kIHVz ZSBjYXNlIG1vcmUKPj4gPj4gPiBjbG9zZWx5Cj4+ID4+Cj4+ID4+IE9mIGNvdXJzZSwgYnV0IHRo ZSB0aGVybWFsIHNodXRkb3duIGlzIG9idmlvdXNseSBhIGJvYXJkLWxldmVsCj4+ID4+IGZlYXR1 cmUsCj4+ID4+IHdoaWNoIEkgZGVzY3JpYmVkIGZ1cnRoZXIgYWJvdmUuCj4+ID4KPj4gPiBOb3Qg c28gb2J2aW91cyB0byBtZSA6LSkgSSBkb24ndCBtZWFuIHRvIGJlIHN0dWJib3JuIG9yIHVuY29v cGVyYXRpdmUKPj4gPiBoZXJlLCBidXQgSSByZWFsbHkgY2FuJ3QgZmluZCBhbnkgdGVjaG5pY2Fs IG1lcml0IGluIGhhdmluZyBpdCBlbmFibGVkCj4+ID4gYXQgYm9hcmQgbGV2ZWwgaW5zdGVhZCBv ZiBTb0MgbGV2ZWwuCj4+IAo+PiBXZWxsLCBwbGVhc2UgYWxzbyBjb25zaWRlciB0aGF0IHRoZSBQ TUlDcyBmcm9tIFJvY2tjaGlwIGFyZSBraW5kIG9mCj4+IHdlaXJkIGxpdHRsZSBjaGlwcywgc3Bl Y2lmaWNhbGx5IGN1c3RvbWl6ZWQgdG8gc2VydmUgcGFydGljdWxhciBTb0NzLgo+PiBGb3IgZXhh bXBsZSwgdGhleSBlbnN1cmUgdGhlIHJpZ2h0IHNlcXVlbmNpbmcgYW5kIHJhbXBpbmctdXAgb2YK Pj4gZGlmZmVyZW50IHBvd2VyIHJhaWxzLCB3aGljaCBpcyBpbiBtYW55IGNhc2VzIGVzc2VudGlh bC4KPiAKPiBTdXJlLiBJJ20gbm90IHNheWluZyB0aGF0IHN3aXRjaGluZyB0byBhIFBNSUMtYXNz aXN0ZWQgcmVzZXQgc2hvdWxkbid0Cj4gYmUgZG9uZSB3aGVyZSB0aGUgYm9hcmQgc3VwcG9ydHMg aXQgLSBxdWl0ZSB0aGUgb3Bwb3NpdGUuIEFsbCBJJ20KPiBzYXlpbmcgaXMgdGhhdCBoYXZpbmcg YXQgbGVhc3QgcGFzc2l2ZSBjb29saW5nIGFuZCBDUlUgYmFzZWQgcmVzZXRzCj4gZ3VhcmFudGVl ZCBmb3IgYW55IGJvYXJkLCByZWdhcmRsZXNzIG9mIGhvdyB0aG91Z2h0IHRocm91Z2ggaXRzIC5k dHMKPiBpcywgc2VlbXMgdG8gYmUgYSBiZXR0ZXIgZGVmYXVsdCB0aGFuIG5vIHRoZXJtYWwgcHJv dGVjdGlvbi4KClRoZSB3YXkgSSBzZWUgaXQsIHdoaWNoIEkgdHJpZWQgdG8gZGVzY3JpYmUgaW4g bXkgcHJldmlvdXMgcmVzcG9uc2UsIGlzCnRoYXQgd2UgY2FuJ3QgYmUgMTAwJSBzdXJlIHRoYXQg Q1JVLWJhc2VkIHJlc2V0cyB3b3VsZCB3b3JrIGFzIGV4cGVjdGVkCmFuZCAxMDAlIHJlbGlhYmx5 IG9uIGFsbCBib2FyZHMuCgo+PiBUaHVzLCB3aG8ga25vd3Mgd2hhdCBtaWdodCAob3IgbWlnaHQg bm90KSBnbyB3cm9uZyBpZiB3ZSBkb24ndCByZXNldCAKPj4gdGhlCj4+IFBNSUMgYXQgdGhlIHNh bWUgdGltZSB3aGVuIHRoZSBDUlUgcmVzZXRzIHRoZSBTb0M/ICBVbmZvcnR1bmF0ZWx5LCB0aGUK Pj4gdGhpbmdzIGFyZW4ndCB0aGF0IHN0cmFpZ2h0Zm9yd2FyZC4KPj4gCj4+IE9uIHRvcCBvZiB0 aGF0LCBzb21lIGJvYXJkcywgc3VjaCBhcyB0aGUgUm9jayA1QiwgdXNlIGEgZmV3IGFkZGl0aW9u YWwKPj4gZGlzY3JldGUgdm9sdGFnZSByZWd1bGF0b3JzIGluc3RlYWQgb2YgYSBtYXN0ZXItc2xh dmUgUE1JQwo+PiBjb25maWd1cmF0aW9uLAo+PiB3aGljaCBtYXkgYWN0dWFsbHkgaW50cm9kdWNl IHNvbWUgd2VpcmQgcG93ZXItcmVsYXRlZCBpc3N1ZXMsIHdoaWNoIAo+PiBhbHNvCj4+IG1heSBi ZSBpbnRlcm1pdHRlbnQuICBBY3R1YWxseSwgSSd2ZSBhbHJlYWR5IG92ZXJoZWFyZCB0aGF0IHRo ZSBSb2NrIAo+PiA1Qgo+PiBleHBlcmllbmNlcyBzb21lIGlzc3VlcyBvZiB0aGF0IG5hdHVyZSwg YnV0IEkgZG9uJ3Qga25vdyB0aGUgZGV0YWlscy4KPiAKPiBUaG9zZSBkaXNjcmV0ZSByZWd1bGF0 b3JzIHNlZW0gdG8gYmUgb3V0IG9mIHNjb3BlIG9mIHRoaXMgZGlzY3Vzc2lvbi4KPiAKPiBJIGFn cmVlIHRoYXQgYSBkZWVwZXIgcG93ZXItY3ljbGUgd2l0aCBwcm9wZXIgcG93ZXItdXAgc2VxdWVu Y2UgdG8KPiBmb2xsb3cgaXQgaXMgYmV0dGVyIHdoZW4gaXQncyBhdmFpbGFibGUgaW4gdGhlIHJl c3BlY3RpdmUgaGFyZHdhcmUuCj4gSSdtIGFsc28gaGFwcHkgdG8gcHJvdmlkZSBhIGZvbGxvdy11 cCBwYXRjaCB0byBzd2l0Y2ggZnJvbSBDUlUgdG8gUE1JQwo+IHJlc2V0cyBmb3IgdGhlIGJvYXJk cyBJIGZvdW5kIHRvIHN1cHBvcnQgdGhlIGxhdHRlci4KPiAKPiBUaGUgcXVlc3Rpb24gd2UgaGF2 ZSBhdCBoYW5kIGlzIHNvbGVseSBhYm91dCB0aGUgZGVmYXVsdCBiZWhhdmlvciBmb3IKPiBhIGh5 cG90aGV0aWNhbCBuZXcgYm9hcmQgd2l0aCBtaW5pbWFsIC5kdHMsIG9yIGFuIGV4aXN0aW5nIGJv YXJkIHdoZXJlCj4gd2UgY2FuJ3QgZGV0ZXJtaW5lIHRoZSB3aXJpbmcgb2YgdGhlIFRTSFVUIHNp Z25hbDoKPiBPcHRpb24gMS4gTGV0IHRoZW0gc3RheSBuaWNlIGFuZCB3YXJtIGF0IDEyMEMrIHVu ZGVyIGxvYWQsIGJlY2F1c2UKPiB0aGV5IHNob3VsZCBoYXZlIGtub3duIGJldHRlciBhbmQgc2hv dWxkIGhhdmUgZW5hYmxlZCB0aGUgVFNBREMgaW4KPiB0aGVpciBkZXZpY2UgdHJlZSBiZWZvcmUg cHV0dGluZyB0aGUgc3lzdGVtIHVuZGVyIGxvYWQKPiBPcHRpb24gMi4gR2V0IHRoZW0gcGFzc2l2 ZWx5IGNvb2xlZCBhdCA4NUMgdW5kZXIgbG9hZCBldmVuIHdpdGggbm8KPiBoZWF0c2luaywgdGhl biBmb3JjZSBhIENSVSByZXNldCBvdXQgb2YgYWJ1bmRhbmNlIG9mIGNhdXRpb24gYXQgMTIwQwo+ IHVubGVzcyB0aGV5IGRlZmluZWQgUE1JQyByZXNldCBpbiB0aGVpciBkZXZpY2UgdHJlZQo+IAo+ IEknbSBhZHZvY2F0aW5nIGZvciB0aGUgbGF0dGVyLgoKSnVzdCB0byBjbGFyaWZ5LCB0aGUgd2F5 IEkgc2VlIGl0LCB3ZSdkIGVuZCB1cCB3aXRoIGhhdmluZyBUU0FEQyBhbmQKQ1JVLWJhc2VkIHJl c2V0cyBlbmFibGVkIGZvciB0aGUgYm9hcmRzIHdlIGNhbid0IGJlIHN1cmUgdG8gaGF2ZSBzdXBw b3J0CmZvciBQTUlDIHJlc2V0cy4gIEl0J3MganVzdCB0aGF0LCB0aGUgd2F5IEkgc2VlIGl0LCBU U0FEQyB3b3VsZG4ndCBiZQplbmFibGVkIG9uIHRoZSBTb0MgbGV2ZWwsIGJ1dCBubyBib2FyZHMg d291bGQgYmUgbGVmdCB3aXRoIG5vIHRoZXJtYWwKcnVuYXdheSBoYW5kbGluZyBpbiBwbGFjZS4K Cj4+ID4gU3dpdGNoaW5nIHRvIFBNSUMtYXNzaXN0ZWQgcmVzZXRzIGlzIG9uZSB0aGluZyAtIGl0 IGRlZmluaXRlbHkgc2hvdWxkCj4+ID4gZ28gdG8gYm9hcmQgZmlsZXMsIGFzIGl0IGRlcGVuZHMg b24gdGhlIHNwZWNpZmljIHdpcmluZyBvZiB0aGUKPj4gPiBUU0FEQ19TSFVUIHNpZ25hbC4gRW5h YmxpbmcgVFNBREMgaW4gYSBkZWZhdWx0IGNvbmZpZ3VyYXRpb24gdGhhdCBjYW4KPj4gPiBhbmQg d2lsbCB3b3JrIG9uIGFsbCBib2FyZHMgcmVnYXJkbGVzcyBvZiB0aGVpciB3aXJpbmcgaXMgYW5v dGhlcgo+PiA+IHRoaW5nLiBJJ20ganVzdCBhcmd1aW5nIGZvciB0aGUgbGF0dGVyLgo+PiAKPj4g Q1JVLWJhc2VkIHRoZXJtYWwgcnVuYXdheSBoYW5kbGluZyBtYXkgaW4gdGhlb3J5IHdvcmsgb24g YWxsIGJvYXJkcywgCj4+IGJ1dAo+PiB3ZSBzaW1wbHkgY2FuJ3QgYmUgMTAwJSBzdXJlIHdpdGhv dXQgZGV0YWlsZWQgaW5zaWdodHMgaW50byB0aGUgYm9hcmQKPj4gZGVzaWducyBhbmQgdGVzdGlu Zy4gIE1heWJlIGV2ZW4gdGhlIGRvd25zdHJlYW0gVS1Cb290IGRvZXMgc29tZSBtYWdpYwo+PiBk dXJpbmcgc3VjaCB0aGVybWFsIHJ1bmF3YXkgcmVzZXRzLCB3aGljaCB3ZSBkb24ndCBrbm93LiAg SXQgbWF5IGJlCj4+IHNpbWlsYXIgdG8gdGhlIFNvQyByZXNldCBpc3N1ZXMgdGhhdCB0aGUgUksz Mzk5IHN1ZmZlcnMgZnJvbS4KPiAKPiBUaGF0IG1pZ2h0IGJlIHRydWUsIGJ1dCB3ZSdyZSB0YWxr aW5nIGFib3V0IG9wZXJhdGlvbiBhdCAxMjBDKyBoZXJlLgo+IEknZCByYXRoZXIgaGF2ZSBteSBi b2FyZCByZWJvb3QgaW4gYW55IHdheSBpdCBwbGVhc2VzIHVuZGVyIHRob3NlCj4gY29uZGl0aW9u cywgYW5kIGhhdmUgdGhhdCBiZWhhdmlvciB0cmlnZ2VyZWQgYnkgZGVmYXVsdCBldmVuIGlmIGl0 J3MKPiBpbXBlcmZlY3QsIHRoZW4gd29ycnkgYWJvdXQgdGhlIGNvcnJlY3Qgc3RhdGUgb2YgYWxs IHJlZ3VsYXRvcnMgYW5kCj4gcGVyaXBoZXJhbHMgdXBvbiBuZXh0IGJvb3QuIFRoZSBsYXR0ZXIg aXMgaW1wb3J0YW50IG9mIGNvdXJzZSwgYnV0IEknZAo+IHJhdGhlciBsZXQgaXQgY29vbCBkb3du IGFuZCByZWJvb3QgaXQgbWFudWFsbHkgYW55d2F5LCBiZWNhdXNlIHRoYXQKPiBoZWF0IGNvdWxk IGhhdmUgbWFkZSBtb3JlIHRoaW5ncyBnbyBzaWRld2F5cyB0aGFuIGp1c3QgdGhlIHJlZ3VsYXRv cnMuCgpNYWtlcyBzZW5zZSwgYnV0IGFzIHlvdSBjYW4gc2VlIGFib3ZlLCB0aGUgd2F5IEkgcHJv cG9zZSBpdCBubyBib2FyZHMKd291bGQgYmUgbGVmdCB0byBzaXp6bGUgdW5kZXIgbG9hZC4gIFRo YXQgd291bGQgYmUgaXJyZXNwb25zaWJsZSBhbmQgYmFkCm9uIG11bHRpcGxlIGxldmVscy4KCj4+ IFNlZSBhbHNvIG15IGNvbW1lbnQgYWJvdmUuCj4+IAo+PiA+IFRvIG1lIGl0IHNlZW1zIHNpbWls YXIgdG8gdGhlIHdhdGNoZG9nIHRpbWVyIHNpdHVhdGlvbjogd2UgZW5hYmxlIGl0Cj4+ID4gYXQg dGhlIFNvQyBsZXZlbCBbMV0sIGFzIGl0IGlzIGV4cGVjdGVkIHRvIHdvcmsgaW4gaXRzIGRlZmF1 bHQKPj4gPiBjb25maWd1cmF0aW9uIHJlZ2FyZGxlc3Mgb2YgdGhlIGJvYXJkIHdpcmluZywgYW5k IGl0IHByb3ZpZGVzCj4+ID4gcHJvdGVjdGlvbiBhZ2FpbnN0IHN5c3RlbSBtYWxmdW5jdGlvbnMu IERvZXNuJ3QgbWF0dGVyIGlmIHRoZSBib2FyZCBvcgo+PiA+IGl0cyB1c2Vyc3BhY2UgY29kZSBl bmRzIHVwIHVzaW5nIHRoZSBmdWxsIGZ1bmN0aW9uYWxpdHkgLSBpdCBqdXN0IHNpdHMKPj4gPiB0 aGVyZSB3YWl0aW5nIGZvciBpdHMgc3BvdGxpZ2h0IHdpdGhvdXQgaHVydGluZyBhbnlib2R5Lgo+ PiAKPj4gRnJhbmtseSwgSSBkb24ndCBrbm93IG11Y2ggYWJvdXQgdGhlIHdhdGNoZG9nIGZ1bmN0 aW9uYWxpdHksIHNvIEknZCAKPj4gbmVlZAo+PiB0byByZXNlYXJjaCBpdCBiZWZvcmUgSSBjb3Vs ZCBzYXkgc29tZXRoaW5nIGFib3V0IGl0Lgo+IAo+IEZXSVcsIHdhdGNoZG9nIHJlc2V0cyBhcmUg ZXhjbHVzaXZlbHkgcm91dGVkIHRocm91Z2ggdGhlIENSVSAoc2VlCj4gUkszNTg4IFRSTSBWMS4w IHBhcnQgMSBwYWdlIDMxKS4gU28gaWYgd2UgZXhwZWN0IHRoYXQgb25lIHRvIHdvcmsKPiBzb21l aG93LCBwcm9iYWJseSB3ZSBzaG91bGQgZXhwZWN0IHRoZXJtYWwgcmVzZXRzIHRvIHdvcmsgdG9v LgoKSSdsbCBzZWUgdG8gcmVhc2VhcmNoIHRoYXQgYSBiaXQsIG1heWJlIEknbGwgZmluZCBzb21l dGhpbmcgb3V0IHRoYXQKY291bGQgYmUgaW50ZXJlc3Rpbmcgb3IgdXNlZnVsLgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFp bGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D74F2C5478C for ; Fri, 1 Mar 2024 12:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LZHnXO5u9eElUhnh1XJfljPghAfSSuwtGBIHSA9HQ8Q=; b=D/fNaH+7sXXhc318D8n+UwYqXW uo9YgQEFl+hebF+a8MdaB4AK9sWDUP8NXPfXGaN+F8pQSzpZNwD7ws/6HOqH3cXrJN0gHqs8Ok7re u52fqewlvdN6HjtalmPASvLK/zeBfH1RdxJJBr0ysZ8GGvXUH3CcIusrDkteU9CVKlZQ1+C2/nM4s YWN/JY5cqe1FxIB/4Smtl1hy4aBHRWMiMdiNjc18tlDb6952m26//nlnstoEyI7YQmupkC+5TGKRT yt7//gKl5BnC4BUyfMNx7yFekHviZhHOP24v8g+786PF7662SV8Fh6v9CcTdDlA8uxO5GSEroM9E6 SjWnXo3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg25x-00000000B6i-2pMD; Fri, 01 Mar 2024 12:34:33 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg25u-00000000B5Q-0gxv; Fri, 01 Mar 2024 12:34:32 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1709296467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uXXrFPwA0W0DulbaMA1x6JuvLaWb0VOrWlzgP3c4M7Q=; b=p5UhcMKc4xU9LuKVQWuvU/QxoXFmMBjrOiQ8NEc6RjpP2+2CQXenPt0qVjtgB3UWmHyK46 UdeRcK5vHBHG27dfzTXYKH2XdYhg8nma+o6WSEt02mHL3CPEYQ5+MlmS7zgLKtTEsYd/x5 8YAZ9nK6fBwVfl6/D/AACEH+KMYt2BzPlfdMWczsjmSaMHhCzcUwCyOrhYiTIdf8WCoX76 sIkFMrEKNc1B0/7ZUkWkvMY0rMV9QIL0w/zoraMLB9assOKRNwk6RL0KfIrNMUJWCY9Pev ueRYy1TSLFVq2cFMYqSeIqQ5He6q18bPYJ61Of82YclwFKRShq4M3vXcODje5w== Date: Fri, 01 Mar 2024 13:34:26 +0100 From: Dragan Simic To: Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] arm64: dts: rockchip: enable built-in thermal monitoring on RK3588 In-Reply-To: References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <20240229-rk-dts-additions-v3-1-6afe8473a631@gmail.com> <8b48eeac7b629c39adc6024ff418724c@manjaro.org> Message-ID: <6e76db0b2e7739176bcea0b90746a35a@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_043430_860296_6AC6C613 X-CRM114-Status: GOOD ( 69.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wMy0wMSAxMjoxMCwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4gT24gRnJpLCBNYXIg MSwgMjAyNCBhdCAxMjo1MuKAr1BNIERyYWdhbiBTaW1pYyA8ZHNpbWljQG1hbmphcm8ub3JnPiAK PiB3cm90ZToKPj4gT24gMjAyNC0wMy0wMSAwOToyNSwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4+ ID4gT24gRnJpLCBNYXIgMSwgMjAyNCBhdCA5OjUx4oCvQU0gRHJhZ2FuIFNpbWljIDxkc2ltaWNA bWFuamFyby5vcmc+IHdyb3RlOgo+PiA+PiBPbiAyMDI0LTAzLTAxIDA2OjEyLCBBbGV4ZXkgQ2hh cmtvdiB3cm90ZToKPj4gPj4gPiBPbiBGcmksIE1hciAxLCAyMDI0IGF0IDEyOjIx4oCvQU0gRHJh Z2FuIFNpbWljIDxkc2ltaWNAbWFuamFyby5vcmc+Cj4+ID4+ID4gd3JvdGU6Cj4+ID4+ID4+IE9u IDIwMjQtMDItMjkgMjA6MjYsIEFsZXhleSBDaGFya292IHdyb3RlOgo+PiA+PiA+PiA+IEluY2x1 ZGUgdGhlcm1hbCB6b25lcyBpbmZvcm1hdGlvbiBpbiBkZXZpY2UgdHJlZSBmb3IgUkszNTg4IHZh cmlhbnRzLgo+PiA+PiA+PiA+Cj4+ID4+ID4+ID4gVGhpcyBhbHNvIGVuYWJsZXMgdGhlIFRTQURD IGNvbnRyb2xsZXIgdW5jb25kaXRpb25hbGx5IG9uIGFsbCBib2FyZHMKPj4gPj4gPj4gPiB0byBl bnN1cmUgdGhhdCB0aGVybWFsIHByb3RlY3Rpb25zIGFyZSBpbiBwbGFjZSB2aWEgdGhyb3R0bGlu ZyBhbmQKPj4gPj4gPj4gPiBlbWVyZ2VuY3kgcmVzZXQsIG9uY2UgT1BQcyBhcmUgYWRkZWQgdG8g ZW5hYmxlIENQVSBEVkZTLgo+PiA+PiA+PiA+Cj4+ID4+ID4+ID4gVGhlIGRlZmF1bHQgc2V0dGlu Z3MgKHVzaW5nIENSVSBhcyB0aGUgZW1lcmdlbmN5IHJlc2V0IG1lY2hhbmlzbSkKPj4gPj4gPj4g PiBzaG91bGQgd29yayBvbiBhbGwgYm9hcmRzIHJlZ2FyZGxlc3Mgb2YgdGhlaXIgd2lyaW5nLCBh cyBDUlUgcmVzZXRzCj4+ID4+ID4+ID4gZG8gbm90IGRlcGVuZCBvbiBhbnkgZXh0ZXJuYWwgY29t cG9uZW50cy4gQm9hcmRzIHRoYXQgaGF2ZSB0aGUgVFNIVVQKPj4gPj4gPj4gPiBzaWduYWwgd2ly ZWQgdG8gdGhlIHJlc2V0IGxpbmUgb2YgdGhlIFBNSUMgbWF5IG9wdCB0byBzd2l0Y2ggdG8gR1BJ Two+PiA+PiA+PiA+IHRzaHV0IG1vZGUgaW5zdGVhZCAocm9ja2NoaXAsaHctdHNodXQtbW9kZSA9 IDwxPjspCj4+ID4+ID4+Cj4+ID4+ID4+IFF1aXRlIGZyYW5rbHksIEknbSBzdGlsbCBub3Qgc3Vy ZSB0aGF0IGVuYWJsaW5nIHRoaXMgb24gdGhlIFNvQyBsZXZlbAo+PiA+PiA+PiBpcyB0aGUgd2F5 IHRvIGdvLiAgQXMgSSBhbHJlYWR5IGRlc2NyaWJlZCBpbiBkZXRhaWwsIFs0XSBhY2NvcmRpbmcg dG8KPj4gPj4gPj4gdGhlIFJLMzU4OCBIYXJkd2FyZSBEZXNpZ24gR3VpZGUgdjEuMCBhbmQgdGhl IFJvY2sgNUIgc2NoZW1hdGljLCB3ZQo+PiA+PiA+PiBzaG91bGQgYWN0dWFsbHkgdXNlIEdQSU8t YmFzZWQgaGFuZGxpbmcgZm9yIHRoZSB0aGVybWFsIHJ1bmF3YXlzIG9uCj4+ID4+ID4+IHRoZSBS b2NrIDVCLiAgT3RoZXIgYm9hcmRzIHNob3VsZCBhbHNvIGJlIGludmVzdGlnYXRlZCBpbmRpdmlk dWFsbHksCj4+ID4+ID4+IGFuZCB0aGUgVFNBREMgc2hvdWxkIGJlIGVuYWJsZWQgb24gYSBib2Fy ZC10by1ib2FyZCBiYXNpcy4KPj4gPj4gPgo+PiA+PiA+IFdpdGggYWxsIGR1ZSByZXNwZWN0LCBJ IGRpc2FncmVlLCBoZXJlIGlzIHdoeToKPj4gPj4gPiAgLSBOZWl0aGVyIHRoZSBzY2hlbWF0aWMg bm9yIHRoZSBoYXJkd2FyZSBkZXNpZ24gZ3VpZGUsIG9uIHdoaWNoIHRoZQo+PiA+PiA+IHNjaGVt YXRpYyBzZWVtcyB0byBiZSBiYXNlZCwgcHJlc2NyaWJlcyBhIHBhcnRpY3VsYXIgd2F5IHRvIGhh bmRsZQo+PiA+PiA+IHRoZXJtYWwgcnVuYXdheXMuIFRoZXkgb25seSBwcm92aWRlIHRoZSBwb3Nz aWJpbGl0eSBvZiBHUElPIGJhc2VkCj4+ID4+ID4gcmVzZXRzLCBhbG9uZyB3aXRoIHRoZSBDUlUg YmFzZWQgb25lCj4+ID4+Cj4+ID4+IFBsZWFzZSBub3RlIHRoYXQgb3RoZXIgZG9jdW1lbnRzIGZy b20gUm9ja2NoaXAgYWxzbyBleGlzdC4gIEJlbG93IGlzCj4+ID4+IGEgbGluayB0byBhIHNjcmVl bnNob3QgZnJvbSB0aGUgVGhlcm1hbCBkZXZlbG9wZXIgZ3VpZGUsIHZlcnNpb24gMS4wLAo+PiA+ PiB3aGljaCBkZXNjcmliZXMgdGhlIHdob2xlIHRoaW5nIGZ1cnRoZXIuICBJIGJlbGlldmUgaXQn cyBvYnZpb3VzIHRoYXQKPj4gPj4gdGhlIHRoZXJtYWwgcnVuYXdheSBpcyB0byBiZSB0cmVhdGVk IGFzIGEgYm9hcmQtbGV2ZWwgZmVhdHVyZS4KPj4gPj4KPj4gPj4gLSBodHRwczovL2kuaW1ndXIu Y29tL0lKNmRTQWMucG5nCj4+ID4KPj4gPiBGcmFua2x5LCB0aGF0IHN0aWxsIGRvZXNuJ3QgbWFr ZSBUU0FEQyBwZXIgc2UgYSBib2FyZC1sZXZlbCB0aGluZyBJTU8uCj4+ID4gVGhlIG9ubHkgdGhp bmcgdGhhdCBpcyBib2FyZC1sZXZlbCBpcyB0aGUgd2lyaW5nIG9mIEdQSU8gYmFzZWQgcmVzZXRz LAo+PiA+IHdoaWNoIEkgZnVsbHkgYWdyZWUgc2hvdWxkIGdvIHRvIGJvYXJkIC5kdHMgZm9yIGJv YXJkcyB0aGF0IHN1cHBvcnQKPj4gPiBpdCwgYnV0IHRoYXQncyBub3QgcGFydCBvZiB0aGUgY3Vy cmVudCBkZWZhdWx0cyBhbmQgY2FuIGJlIHNhZmVseQo+PiA+IGFkZGVkIGxhdGVyLgo+PiA+Cj4+ ID4gVFNBREMgaXMgaW5zaWRlIHRoZSBTb0MuIENSVSBpcyBpbnNpZGUgdGhlIFNvQy4gVGhleSB3 b3JrIGp1c3QgZmluZQo+PiA+IGZvciBhIHRoZXJtYWwgcmVzZXQsIGV2ZW4gaWYgbm8gZGVkaWNh dGVkIHJlc2V0IGxvZ2ljIGlzIHdpcmVkIG9uIHRoZQo+PiA+IGJvYXJkLiBJIHJlYWxseSBkb24n dCBzZWUgYW55IGRvd25zaWRlcyBpbiBoYXZpbmcgVFNBREMgZW5hYmxlZCBieQo+PiA+IGRlZmF1 bHQgd2l0aCBDUlUgYmFzZWQgcmVzZXRzOgo+PiA+IC0gaXQncyBhIHNhZmUgZGVmYXVsdCAoaS5l LiBJIGNhbm5vdCB0aGluayBvZiBhbnkgY29uZmlndXJhdGlvbiBvciB1c2UKPj4gPiBjYXNlIHdo ZXJlIGVuYWJsZWQtYnktZGVmYXVsdCBUU0FEQyBkb2VzIGFueSBoYXJtKQo+PiA+IC0gaXQncyBz YWZlciB0aGFuIGFjY2lkZW50YWxseSBmb3JnZXR0aW5nIHRvIGVuYWJsZSBUU0FEQyAoYXMgaXQg YWRkcwo+PiA+IHRoZXJtYWwgcHJvdGVjdGlvbiB3aGljaCBpcyBvdGhlcndpc2UgbWlzc2luZykK Pj4gPiAtIGl0IHdpbGwgd29yayBvbiBhbGwgYm9hcmRzIChldmVuIGlmIGl0IGRvZXNuJ3QgdXRp bGl6ZSB0aGUgZnVsbAo+PiA+IGhhcmR3YXJlIGZ1bmN0aW9uYWxpdHkgYnkgaWdub3JpbmcgR1BJ TyByZXNldHMgdGhhdCBzb21lIGJvYXJkcyBhbHNvCj4+ID4gaGF2ZSBpbiBhZGRpdGlvbiB0byB0 aGUgQ1JVKQo+PiA+IC0gYW5kIGl0IHJlcXVpcmVzIGZld2VyIG92ZXJyaWRlcyBpbiBib2FyZCAu ZHRzIGZpbGVzCj4+ID4KPj4gPiBTb3VuZHMgbGlrZSBhIG5vLXJlZ3JldCBtb3ZlIHRvIG1lLgo+ PiAKPj4gUGxlYXNlIHNlZSBteSBjb21tZW50cyBiZWxvdy4KPj4gCj4+ID4+IFRvIGJlIGZhaXIs IHRoYXQgdmVyc2lvbiBvZiB0aGUgVGhlcm1hbCBkZXZlbG9wZXIgZ3VpZGUgZGF0ZXMgYmFjayB0 bwo+PiA+PiAyMDE5LCBtZWFuaW5nIHRoYXQgaXQgdGVjaG5pY2FsbHkgYXBwbGllcyB0byB0aGUg UkszMzk5LCBmb3IgZXhhbXBsZSwKPj4gPj4gYnV0IHRoZSBUU0FEQyBhbmQgcmVzZXQgY2lyY3Vp dHJ5IGRlc2lnbiBoYXMgYmFzaWNhbGx5IHJlbWFpbmVkIHRoZQo+PiA+PiBzYW1lIGZvciB0aGUg UkszNTg4Lgo+PiA+Pgo+PiA+PiA+ICAtIE15IHN0cm9uZyBiZWxpZWYgaXMgdGhhdCBkZWZhdWx0 cyAocmVnYXJkbGVzcyBvZiBjb250ZXh0KSBzaG91bGQgYmUKPj4gPj4gPiBzYWZlIGFuZCByZWFz b25hYmxlLCBhbmQgc2hvdWxkIGFsc28gbWluaW1pemUgdGhlIG5lZWQgdG8gb3ZlcnJpZGUKPj4g Pj4gPiB0aGVtCj4+ID4+Cj4+ID4+IFBsZWFzZSBub3RlIHRoYXQgdGhlIFRTQURDIGlzIGRpc2Fi bGVkIGluIHRoZSBSSzMzOTkgU29DIGR0c2ksIHNvCj4+ID4+IGhhdmluZwo+PiA+PiBpdCBkaXNh YmxlZCBpbiB0aGUgUkszNTg4KHMpIFNvQyBkdHNpIHdvdWxkIHByb3ZpZGUgc29tZSBjb25zaXN0 ZW5jeS4KPj4gPgo+PiA+IEknbSBoYXBweSB0byBwcm9kdWNlIGEgcGF0Y2ggdG8gcmV2ZXJzZSB0 aGUgbG9naWMgaW4gUkszMzk5IChhbmQgYW55Cj4+ID4gb3RoZXJzIGZvciB0aGF0IG1hdHRlcikg dG8gYWxzbyBoYXZlIFRTQURDIGVuYWJsZWQgYnkgZGVmYXVsdCB0aGVyZSwKPj4gPiB0aHVzIHNh dmluZyBzZXZlcmFsIGxpbmVzIG9mIGNvZGUsIGlmIGl0J3MganVzdCBhYm91dCBjb25zaXN0ZW5j eS4KPj4gCj4+IEJ1dCB3aHkgc2hvdWxkIHdlIGNoYW5nZSBzb21ldGhpbmcgdGhhdCBoYXMgc2Vy dmVkIHVzIGZvciB5ZWFycywgb24KPj4gbXVsdGlwbGUgU29Dcywgd2l0aCB6ZXJvIHRyb3VibGVz IGFuZCB3aXRoIChBRkFJSykgemVybyBib2FyZHMgCj4+IHByb2R1Y2luZwo+PiBwdWZmcyBvZiBi bHVpc2ggc21va2U/Cj4gCj4gVGhhdCdzIGp1c3QgaWYgd2UgYXJlIGNvbmNlcm5lZCBhYm91dCBj b25zaXN0ZW5jeSBhY3Jvc3MgZGlmZmVyZW50IFNvQwo+IHNlcmllcy4gVGhlIHBvaW50IGlzIHRo YXQgSSdtIGhhcHB5IHRvIG1ha2Ugd2hhdGV2ZXIgY2hhbmdlIHdlIGFncmVlCj4gdXBvbiBpbiBh IGNvbnNpc3RlbnQgd2F5IGFjcm9zcyBhbGwgcmVsYXRlZCAuZHRzaS8uZHRzIGZpbGVzIC0gdGh1 cyBubwo+IG5lZWQgdG8gd29ycnkgYWJvdXQgcGFzdCBkZWNpc2lvbnMgdGhhdCBoYXZlIGFscmVh ZHkgYmVlbiBpbXBsZW1lbnRlZAo+IGZvciBvdGhlciBjaGlwcy4gTGV0J3MganVzdCBhZ3JlZSBv biB0aGUgdGVjaG5pY2FsIG1lcml0cyBvZiBvbmUgb3IKPiB0aGUgb3RoZXIgYXBwcm9hY2gsIGxl YXZpbmcgIndlJ3ZlIGJlZW4gZG9pbmcgaXQgZGlmZmVyZW50bHkgZWxzZXdoZXJlIgo+IGFzaWRl IGZvciBub3cuCgpJIHNlZSwgSSdkIGFsc28gYmUgd2lsbGluZyB0byBpbXBsZW1lbnQgc3VjaCBj bGVhbnVwIHBhdGNoZXMuICBUaG91Z2gsCmxldCdzIGFsc28ga2VlcCBpbiBtaW5kIHRoYXQgc29t ZSBwYXN0IGRlY2lzaW9ucyBtaWdodCBoYXZlIHNvbWUgc3Ryb25nCnJlYXNvbnMgYmVoaW5kIHRo ZW0sIHdoaWNoIG1pZ2h0IG5vdCBiZSBvYnZpb3VzLiAgVGhhdCdzIGFub3RoZXIgcmVhc29uCndo eSBJJ20gYWdhaW5zdCBlbmFibGluZyBUU0FEQyBieSBkZWZhdWx0LgoKPj4gPj4gVGhvdWdoLCB0 aGUgUkszMzk5IHN0aWxsIGRvZXMgaXQgaW4gYSBzYWZlIHdheSwgYnkgbW92aW5nIHRoZSBPUFBz Cj4+ID4+IGludG8KPj4gPj4gYSBzZXBhcmF0ZSBkdHNpIGZpbGUsIG5hbWVkIHJrMzM5OS1vcHAu ZHRzaSwgd2hpY2ggdGhlIGJvYXJkIGR0cyBmaWxlcwo+PiA+PiB0aGVuIGluY2x1ZGUgdG9nZXRo ZXIgd2l0aCBlbmFibGluZyB0aGUgVFNBREMuCj4+ID4+Cj4+ID4+IElmIHlvdSBhZ3JlZSwgbGV0 J3MgZW1wbG95IHRoZSBzYW1lIGFwcHJvYWNoIGZvciB0aGUgUkszNTg4KHMpLCBieQo+PiA+PiBo YXZpbmcKPj4gPj4gdGhlIGl0cyBPUFBzIGRlZmluZWQgaW4gYSBzZXBhcmF0ZSBmaWxlLCBuYW1l ZCByazM1ODhzLW9wcC5kdHNpLCBldGMuCj4+ID4KPj4gPiBTZXBhcmF0ZSBmaWxlIGZvciBPUFBz IGlzIGEgZ29vZCBuby1yZWdyZXQgbW92ZSB0byBkZWNsdXR0ZXIgdGhlIFNvQwo+PiA+IGxldmVs IC5kdHNpIChhcyB0aGUgT1BQIHRhYmxlIGlzIGxvbmcgYW5kIGJvcmluZykgLSBoYXBweSB0byBt b3ZlIGl0Cj4+ID4gcmVnYXJkbGVzcyBvZiB0aGUgb3V0Y29tZSBvZiB0aGUgYWJvdmUgVFNBREMg ZGlzY3Vzc2lvbi4gVGhhbmtzIGZvcgo+PiA+IHRoZSBwb2ludGVyIQo+PiAKPj4gWWVhaCwgYnV0 IEknbSBub3Qgc3VyZSB0aGF0IGV2ZXJ5b25lIHdvdWxkIGxpa2UgdGhhdCBraW5kIG9mIAo+PiBz ZXBhcmF0aW9uLgo+PiBJbiBmYWN0LCBzdWNoIHNlcGFyYXRpb24gbWF5IGJlIGZyb3duZWQgdXBv biB1bmxlc3MgaXQncyBuZWNlc3NhcnkuCj4+IAo+PiBBcyBJIGFscmVhZHkgZGVzY3JpYmVkIGlu IGFub3RoZXIgdGhyZWFkLCB0aGUgc2VwYXJhdGlvbiBmb3IgdGhlIAo+PiBSSzMzOTkKPj4gaXMg dGhlcmUgb25seSBiZWNhdXNlIGEgY291cGxlIG9mIGRpZmZlcmVudCB2YXJpYW50cyBvZiB0aGUg UkszMzk5IFNvQwo+PiByZXF1aXJlIGRpZmZlcmVudCBPUFBzLgo+PiAKPj4gPj4gPiAgLSBJbiBj b250ZXh0IG9mIGR0cy9kdHNpLCBhcyBmYXIgYXMgSSB1bmRlcnN0YW5kIHRoZSBnZW5lcmFsIGxv Z2ljCj4+ID4+ID4gYmVoaW5kIHRoZSBzcGxpdCwgdGhlIFNvQyAuZHRzaSBzaG91bGQgY29udGFp biBhbGwgdGhlIHRoaW5ncyB0aGF0IGFyZQo+PiA+PiA+IGZ1bGx5IGNvbnRhaW5lZCB3aXRoaW4g dGhlIFNvQyBhbmQgZG8gbm90IGRlcGVuZCBvbiB0aGUgd2lyaW5nIG9mIGEKPj4gPj4gPiBwYXJ0 aWN1bGFyIGJvYXJkIG9yIGl0cyB0YXJnZXQgdXNlIGNhc2UuIEJvYXJkcyB0aGVuCj4+ID4+ID4g YWRkL3JlbW92ZS9vdmVycmlkZSBzZXR0aW5ncyB0byBtYXRjaCB0aGVpciB3aXJpbmcgYW5kIHVz ZSBjYXNlIG1vcmUKPj4gPj4gPiBjbG9zZWx5Cj4+ID4+Cj4+ID4+IE9mIGNvdXJzZSwgYnV0IHRo ZSB0aGVybWFsIHNodXRkb3duIGlzIG9idmlvdXNseSBhIGJvYXJkLWxldmVsCj4+ID4+IGZlYXR1 cmUsCj4+ID4+IHdoaWNoIEkgZGVzY3JpYmVkIGZ1cnRoZXIgYWJvdmUuCj4+ID4KPj4gPiBOb3Qg c28gb2J2aW91cyB0byBtZSA6LSkgSSBkb24ndCBtZWFuIHRvIGJlIHN0dWJib3JuIG9yIHVuY29v cGVyYXRpdmUKPj4gPiBoZXJlLCBidXQgSSByZWFsbHkgY2FuJ3QgZmluZCBhbnkgdGVjaG5pY2Fs IG1lcml0IGluIGhhdmluZyBpdCBlbmFibGVkCj4+ID4gYXQgYm9hcmQgbGV2ZWwgaW5zdGVhZCBv ZiBTb0MgbGV2ZWwuCj4+IAo+PiBXZWxsLCBwbGVhc2UgYWxzbyBjb25zaWRlciB0aGF0IHRoZSBQ TUlDcyBmcm9tIFJvY2tjaGlwIGFyZSBraW5kIG9mCj4+IHdlaXJkIGxpdHRsZSBjaGlwcywgc3Bl Y2lmaWNhbGx5IGN1c3RvbWl6ZWQgdG8gc2VydmUgcGFydGljdWxhciBTb0NzLgo+PiBGb3IgZXhh bXBsZSwgdGhleSBlbnN1cmUgdGhlIHJpZ2h0IHNlcXVlbmNpbmcgYW5kIHJhbXBpbmctdXAgb2YK Pj4gZGlmZmVyZW50IHBvd2VyIHJhaWxzLCB3aGljaCBpcyBpbiBtYW55IGNhc2VzIGVzc2VudGlh bC4KPiAKPiBTdXJlLiBJJ20gbm90IHNheWluZyB0aGF0IHN3aXRjaGluZyB0byBhIFBNSUMtYXNz aXN0ZWQgcmVzZXQgc2hvdWxkbid0Cj4gYmUgZG9uZSB3aGVyZSB0aGUgYm9hcmQgc3VwcG9ydHMg aXQgLSBxdWl0ZSB0aGUgb3Bwb3NpdGUuIEFsbCBJJ20KPiBzYXlpbmcgaXMgdGhhdCBoYXZpbmcg YXQgbGVhc3QgcGFzc2l2ZSBjb29saW5nIGFuZCBDUlUgYmFzZWQgcmVzZXRzCj4gZ3VhcmFudGVl ZCBmb3IgYW55IGJvYXJkLCByZWdhcmRsZXNzIG9mIGhvdyB0aG91Z2h0IHRocm91Z2ggaXRzIC5k dHMKPiBpcywgc2VlbXMgdG8gYmUgYSBiZXR0ZXIgZGVmYXVsdCB0aGFuIG5vIHRoZXJtYWwgcHJv dGVjdGlvbi4KClRoZSB3YXkgSSBzZWUgaXQsIHdoaWNoIEkgdHJpZWQgdG8gZGVzY3JpYmUgaW4g bXkgcHJldmlvdXMgcmVzcG9uc2UsIGlzCnRoYXQgd2UgY2FuJ3QgYmUgMTAwJSBzdXJlIHRoYXQg Q1JVLWJhc2VkIHJlc2V0cyB3b3VsZCB3b3JrIGFzIGV4cGVjdGVkCmFuZCAxMDAlIHJlbGlhYmx5 IG9uIGFsbCBib2FyZHMuCgo+PiBUaHVzLCB3aG8ga25vd3Mgd2hhdCBtaWdodCAob3IgbWlnaHQg bm90KSBnbyB3cm9uZyBpZiB3ZSBkb24ndCByZXNldCAKPj4gdGhlCj4+IFBNSUMgYXQgdGhlIHNh bWUgdGltZSB3aGVuIHRoZSBDUlUgcmVzZXRzIHRoZSBTb0M/ICBVbmZvcnR1bmF0ZWx5LCB0aGUK Pj4gdGhpbmdzIGFyZW4ndCB0aGF0IHN0cmFpZ2h0Zm9yd2FyZC4KPj4gCj4+IE9uIHRvcCBvZiB0 aGF0LCBzb21lIGJvYXJkcywgc3VjaCBhcyB0aGUgUm9jayA1QiwgdXNlIGEgZmV3IGFkZGl0aW9u YWwKPj4gZGlzY3JldGUgdm9sdGFnZSByZWd1bGF0b3JzIGluc3RlYWQgb2YgYSBtYXN0ZXItc2xh dmUgUE1JQwo+PiBjb25maWd1cmF0aW9uLAo+PiB3aGljaCBtYXkgYWN0dWFsbHkgaW50cm9kdWNl IHNvbWUgd2VpcmQgcG93ZXItcmVsYXRlZCBpc3N1ZXMsIHdoaWNoIAo+PiBhbHNvCj4+IG1heSBi ZSBpbnRlcm1pdHRlbnQuICBBY3R1YWxseSwgSSd2ZSBhbHJlYWR5IG92ZXJoZWFyZCB0aGF0IHRo ZSBSb2NrIAo+PiA1Qgo+PiBleHBlcmllbmNlcyBzb21lIGlzc3VlcyBvZiB0aGF0IG5hdHVyZSwg YnV0IEkgZG9uJ3Qga25vdyB0aGUgZGV0YWlscy4KPiAKPiBUaG9zZSBkaXNjcmV0ZSByZWd1bGF0 b3JzIHNlZW0gdG8gYmUgb3V0IG9mIHNjb3BlIG9mIHRoaXMgZGlzY3Vzc2lvbi4KPiAKPiBJIGFn cmVlIHRoYXQgYSBkZWVwZXIgcG93ZXItY3ljbGUgd2l0aCBwcm9wZXIgcG93ZXItdXAgc2VxdWVu Y2UgdG8KPiBmb2xsb3cgaXQgaXMgYmV0dGVyIHdoZW4gaXQncyBhdmFpbGFibGUgaW4gdGhlIHJl c3BlY3RpdmUgaGFyZHdhcmUuCj4gSSdtIGFsc28gaGFwcHkgdG8gcHJvdmlkZSBhIGZvbGxvdy11 cCBwYXRjaCB0byBzd2l0Y2ggZnJvbSBDUlUgdG8gUE1JQwo+IHJlc2V0cyBmb3IgdGhlIGJvYXJk cyBJIGZvdW5kIHRvIHN1cHBvcnQgdGhlIGxhdHRlci4KPiAKPiBUaGUgcXVlc3Rpb24gd2UgaGF2 ZSBhdCBoYW5kIGlzIHNvbGVseSBhYm91dCB0aGUgZGVmYXVsdCBiZWhhdmlvciBmb3IKPiBhIGh5 cG90aGV0aWNhbCBuZXcgYm9hcmQgd2l0aCBtaW5pbWFsIC5kdHMsIG9yIGFuIGV4aXN0aW5nIGJv YXJkIHdoZXJlCj4gd2UgY2FuJ3QgZGV0ZXJtaW5lIHRoZSB3aXJpbmcgb2YgdGhlIFRTSFVUIHNp Z25hbDoKPiBPcHRpb24gMS4gTGV0IHRoZW0gc3RheSBuaWNlIGFuZCB3YXJtIGF0IDEyMEMrIHVu ZGVyIGxvYWQsIGJlY2F1c2UKPiB0aGV5IHNob3VsZCBoYXZlIGtub3duIGJldHRlciBhbmQgc2hv dWxkIGhhdmUgZW5hYmxlZCB0aGUgVFNBREMgaW4KPiB0aGVpciBkZXZpY2UgdHJlZSBiZWZvcmUg cHV0dGluZyB0aGUgc3lzdGVtIHVuZGVyIGxvYWQKPiBPcHRpb24gMi4gR2V0IHRoZW0gcGFzc2l2 ZWx5IGNvb2xlZCBhdCA4NUMgdW5kZXIgbG9hZCBldmVuIHdpdGggbm8KPiBoZWF0c2luaywgdGhl biBmb3JjZSBhIENSVSByZXNldCBvdXQgb2YgYWJ1bmRhbmNlIG9mIGNhdXRpb24gYXQgMTIwQwo+ IHVubGVzcyB0aGV5IGRlZmluZWQgUE1JQyByZXNldCBpbiB0aGVpciBkZXZpY2UgdHJlZQo+IAo+ IEknbSBhZHZvY2F0aW5nIGZvciB0aGUgbGF0dGVyLgoKSnVzdCB0byBjbGFyaWZ5LCB0aGUgd2F5 IEkgc2VlIGl0LCB3ZSdkIGVuZCB1cCB3aXRoIGhhdmluZyBUU0FEQyBhbmQKQ1JVLWJhc2VkIHJl c2V0cyBlbmFibGVkIGZvciB0aGUgYm9hcmRzIHdlIGNhbid0IGJlIHN1cmUgdG8gaGF2ZSBzdXBw b3J0CmZvciBQTUlDIHJlc2V0cy4gIEl0J3MganVzdCB0aGF0LCB0aGUgd2F5IEkgc2VlIGl0LCBU U0FEQyB3b3VsZG4ndCBiZQplbmFibGVkIG9uIHRoZSBTb0MgbGV2ZWwsIGJ1dCBubyBib2FyZHMg d291bGQgYmUgbGVmdCB3aXRoIG5vIHRoZXJtYWwKcnVuYXdheSBoYW5kbGluZyBpbiBwbGFjZS4K Cj4+ID4gU3dpdGNoaW5nIHRvIFBNSUMtYXNzaXN0ZWQgcmVzZXRzIGlzIG9uZSB0aGluZyAtIGl0 IGRlZmluaXRlbHkgc2hvdWxkCj4+ID4gZ28gdG8gYm9hcmQgZmlsZXMsIGFzIGl0IGRlcGVuZHMg b24gdGhlIHNwZWNpZmljIHdpcmluZyBvZiB0aGUKPj4gPiBUU0FEQ19TSFVUIHNpZ25hbC4gRW5h YmxpbmcgVFNBREMgaW4gYSBkZWZhdWx0IGNvbmZpZ3VyYXRpb24gdGhhdCBjYW4KPj4gPiBhbmQg d2lsbCB3b3JrIG9uIGFsbCBib2FyZHMgcmVnYXJkbGVzcyBvZiB0aGVpciB3aXJpbmcgaXMgYW5v dGhlcgo+PiA+IHRoaW5nLiBJJ20ganVzdCBhcmd1aW5nIGZvciB0aGUgbGF0dGVyLgo+PiAKPj4g Q1JVLWJhc2VkIHRoZXJtYWwgcnVuYXdheSBoYW5kbGluZyBtYXkgaW4gdGhlb3J5IHdvcmsgb24g YWxsIGJvYXJkcywgCj4+IGJ1dAo+PiB3ZSBzaW1wbHkgY2FuJ3QgYmUgMTAwJSBzdXJlIHdpdGhv dXQgZGV0YWlsZWQgaW5zaWdodHMgaW50byB0aGUgYm9hcmQKPj4gZGVzaWducyBhbmQgdGVzdGlu Zy4gIE1heWJlIGV2ZW4gdGhlIGRvd25zdHJlYW0gVS1Cb290IGRvZXMgc29tZSBtYWdpYwo+PiBk dXJpbmcgc3VjaCB0aGVybWFsIHJ1bmF3YXkgcmVzZXRzLCB3aGljaCB3ZSBkb24ndCBrbm93LiAg SXQgbWF5IGJlCj4+IHNpbWlsYXIgdG8gdGhlIFNvQyByZXNldCBpc3N1ZXMgdGhhdCB0aGUgUksz Mzk5IHN1ZmZlcnMgZnJvbS4KPiAKPiBUaGF0IG1pZ2h0IGJlIHRydWUsIGJ1dCB3ZSdyZSB0YWxr aW5nIGFib3V0IG9wZXJhdGlvbiBhdCAxMjBDKyBoZXJlLgo+IEknZCByYXRoZXIgaGF2ZSBteSBi b2FyZCByZWJvb3QgaW4gYW55IHdheSBpdCBwbGVhc2VzIHVuZGVyIHRob3NlCj4gY29uZGl0aW9u cywgYW5kIGhhdmUgdGhhdCBiZWhhdmlvciB0cmlnZ2VyZWQgYnkgZGVmYXVsdCBldmVuIGlmIGl0 J3MKPiBpbXBlcmZlY3QsIHRoZW4gd29ycnkgYWJvdXQgdGhlIGNvcnJlY3Qgc3RhdGUgb2YgYWxs IHJlZ3VsYXRvcnMgYW5kCj4gcGVyaXBoZXJhbHMgdXBvbiBuZXh0IGJvb3QuIFRoZSBsYXR0ZXIg aXMgaW1wb3J0YW50IG9mIGNvdXJzZSwgYnV0IEknZAo+IHJhdGhlciBsZXQgaXQgY29vbCBkb3du IGFuZCByZWJvb3QgaXQgbWFudWFsbHkgYW55d2F5LCBiZWNhdXNlIHRoYXQKPiBoZWF0IGNvdWxk IGhhdmUgbWFkZSBtb3JlIHRoaW5ncyBnbyBzaWRld2F5cyB0aGFuIGp1c3QgdGhlIHJlZ3VsYXRv cnMuCgpNYWtlcyBzZW5zZSwgYnV0IGFzIHlvdSBjYW4gc2VlIGFib3ZlLCB0aGUgd2F5IEkgcHJv cG9zZSBpdCBubyBib2FyZHMKd291bGQgYmUgbGVmdCB0byBzaXp6bGUgdW5kZXIgbG9hZC4gIFRo YXQgd291bGQgYmUgaXJyZXNwb25zaWJsZSBhbmQgYmFkCm9uIG11bHRpcGxlIGxldmVscy4KCj4+ IFNlZSBhbHNvIG15IGNvbW1lbnQgYWJvdmUuCj4+IAo+PiA+IFRvIG1lIGl0IHNlZW1zIHNpbWls YXIgdG8gdGhlIHdhdGNoZG9nIHRpbWVyIHNpdHVhdGlvbjogd2UgZW5hYmxlIGl0Cj4+ID4gYXQg dGhlIFNvQyBsZXZlbCBbMV0sIGFzIGl0IGlzIGV4cGVjdGVkIHRvIHdvcmsgaW4gaXRzIGRlZmF1 bHQKPj4gPiBjb25maWd1cmF0aW9uIHJlZ2FyZGxlc3Mgb2YgdGhlIGJvYXJkIHdpcmluZywgYW5k IGl0IHByb3ZpZGVzCj4+ID4gcHJvdGVjdGlvbiBhZ2FpbnN0IHN5c3RlbSBtYWxmdW5jdGlvbnMu IERvZXNuJ3QgbWF0dGVyIGlmIHRoZSBib2FyZCBvcgo+PiA+IGl0cyB1c2Vyc3BhY2UgY29kZSBl bmRzIHVwIHVzaW5nIHRoZSBmdWxsIGZ1bmN0aW9uYWxpdHkgLSBpdCBqdXN0IHNpdHMKPj4gPiB0 aGVyZSB3YWl0aW5nIGZvciBpdHMgc3BvdGxpZ2h0IHdpdGhvdXQgaHVydGluZyBhbnlib2R5Lgo+ PiAKPj4gRnJhbmtseSwgSSBkb24ndCBrbm93IG11Y2ggYWJvdXQgdGhlIHdhdGNoZG9nIGZ1bmN0 aW9uYWxpdHksIHNvIEknZCAKPj4gbmVlZAo+PiB0byByZXNlYXJjaCBpdCBiZWZvcmUgSSBjb3Vs ZCBzYXkgc29tZXRoaW5nIGFib3V0IGl0Lgo+IAo+IEZXSVcsIHdhdGNoZG9nIHJlc2V0cyBhcmUg ZXhjbHVzaXZlbHkgcm91dGVkIHRocm91Z2ggdGhlIENSVSAoc2VlCj4gUkszNTg4IFRSTSBWMS4w IHBhcnQgMSBwYWdlIDMxKS4gU28gaWYgd2UgZXhwZWN0IHRoYXQgb25lIHRvIHdvcmsKPiBzb21l aG93LCBwcm9iYWJseSB3ZSBzaG91bGQgZXhwZWN0IHRoZXJtYWwgcmVzZXRzIHRvIHdvcmsgdG9v LgoKSSdsbCBzZWUgdG8gcmVhc2VhcmNoIHRoYXQgYSBiaXQsIG1heWJlIEknbGwgZmluZCBzb21l dGhpbmcgb3V0IHRoYXQKY291bGQgYmUgaW50ZXJlc3Rpbmcgb3IgdXNlZnVsLgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 295B1812; Fri, 1 Mar 2024 12:34:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709296474; cv=none; b=QosqjLpF/aYsVAr478S+Chz+MKDCGay6zmANpp/ft5Toi+gNHRTfHByiJhJcvkPn29dSLJz2TgtKQQW9BzcPWji0DE6dQ6INyT4yMjlRARuL8f0rEaml9DLgflMo4WdAgtBgj43F3+LeJmuPNqngnEbyCL8tp4FgI99ITngwLw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709296474; c=relaxed/simple; bh=v7pPKcM/LK+j7XMQkYI4Q1FyQ5pU6u6VvVtgS+onmWw=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=NKzihLLd/F1wQU9lB5AdDdj+YcWLshVz9BChHown27Yrz0T7d5w/hlG0teHohizL8EAMtVR8h81O5pKOkzxvh9z6Zw2PqoY3R+tFBROBIYilCYefmzXqCbFt5hXhZTCw2ToNB0tC6Ph+vUhU44dheY0v1Gi9wVDcN792gnVQcu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=p5UhcMKc; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="p5UhcMKc" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1709296467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uXXrFPwA0W0DulbaMA1x6JuvLaWb0VOrWlzgP3c4M7Q=; b=p5UhcMKc4xU9LuKVQWuvU/QxoXFmMBjrOiQ8NEc6RjpP2+2CQXenPt0qVjtgB3UWmHyK46 UdeRcK5vHBHG27dfzTXYKH2XdYhg8nma+o6WSEt02mHL3CPEYQ5+MlmS7zgLKtTEsYd/x5 8YAZ9nK6fBwVfl6/D/AACEH+KMYt2BzPlfdMWczsjmSaMHhCzcUwCyOrhYiTIdf8WCoX76 sIkFMrEKNc1B0/7ZUkWkvMY0rMV9QIL0w/zoraMLB9assOKRNwk6RL0KfIrNMUJWCY9Pev ueRYy1TSLFVq2cFMYqSeIqQ5He6q18bPYJ61Of82YclwFKRShq4M3vXcODje5w== Date: Fri, 01 Mar 2024 13:34:26 +0100 From: Dragan Simic To: Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] arm64: dts: rockchip: enable built-in thermal monitoring on RK3588 In-Reply-To: References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <20240229-rk-dts-additions-v3-1-6afe8473a631@gmail.com> <8b48eeac7b629c39adc6024ff418724c@manjaro.org> Message-ID: <6e76db0b2e7739176bcea0b90746a35a@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org On 2024-03-01 12:10, Alexey Charkov wrote: > On Fri, Mar 1, 2024 at 12:52 PM Dragan Simic > wrote: >> On 2024-03-01 09:25, Alexey Charkov wrote: >> > On Fri, Mar 1, 2024 at 9:51 AM Dragan Simic wrote: >> >> On 2024-03-01 06:12, Alexey Charkov wrote: >> >> > On Fri, Mar 1, 2024 at 12:21 AM Dragan Simic >> >> > wrote: >> >> >> On 2024-02-29 20:26, Alexey Charkov wrote: >> >> >> > Include thermal zones information in device tree for RK3588 variants. >> >> >> > >> >> >> > This also enables the TSADC controller unconditionally on all boards >> >> >> > to ensure that thermal protections are in place via throttling and >> >> >> > emergency reset, once OPPs are added to enable CPU DVFS. >> >> >> > >> >> >> > The default settings (using CRU as the emergency reset mechanism) >> >> >> > should work on all boards regardless of their wiring, as CRU resets >> >> >> > do not depend on any external components. Boards that have the TSHUT >> >> >> > signal wired to the reset line of the PMIC may opt to switch to GPIO >> >> >> > tshut mode instead (rockchip,hw-tshut-mode = <1>;) >> >> >> >> >> >> Quite frankly, I'm still not sure that enabling this on the SoC level >> >> >> is the way to go. As I already described in detail, [4] according to >> >> >> the RK3588 Hardware Design Guide v1.0 and the Rock 5B schematic, we >> >> >> should actually use GPIO-based handling for the thermal runaways on >> >> >> the Rock 5B. Other boards should also be investigated individually, >> >> >> and the TSADC should be enabled on a board-to-board basis. >> >> > >> >> > With all due respect, I disagree, here is why: >> >> > - Neither the schematic nor the hardware design guide, on which the >> >> > schematic seems to be based, prescribes a particular way to handle >> >> > thermal runaways. They only provide the possibility of GPIO based >> >> > resets, along with the CRU based one >> >> >> >> Please note that other documents from Rockchip also exist. Below is >> >> a link to a screenshot from the Thermal developer guide, version 1.0, >> >> which describes the whole thing further. I believe it's obvious that >> >> the thermal runaway is to be treated as a board-level feature. >> >> >> >> - https://i.imgur.com/IJ6dSAc.png >> > >> > Frankly, that still doesn't make TSADC per se a board-level thing IMO. >> > The only thing that is board-level is the wiring of GPIO based resets, >> > which I fully agree should go to board .dts for boards that support >> > it, but that's not part of the current defaults and can be safely >> > added later. >> > >> > TSADC is inside the SoC. CRU is inside the SoC. They work just fine >> > for a thermal reset, even if no dedicated reset logic is wired on the >> > board. I really don't see any downsides in having TSADC enabled by >> > default with CRU based resets: >> > - it's a safe default (i.e. I cannot think of any configuration or use >> > case where enabled-by-default TSADC does any harm) >> > - it's safer than accidentally forgetting to enable TSADC (as it adds >> > thermal protection which is otherwise missing) >> > - it will work on all boards (even if it doesn't utilize the full >> > hardware functionality by ignoring GPIO resets that some boards also >> > have in addition to the CRU) >> > - and it requires fewer overrides in board .dts files >> > >> > Sounds like a no-regret move to me. >> >> Please see my comments below. >> >> >> To be fair, that version of the Thermal developer guide dates back to >> >> 2019, meaning that it technically applies to the RK3399, for example, >> >> but the TSADC and reset circuitry design has basically remained the >> >> same for the RK3588. >> >> >> >> > - My strong belief is that defaults (regardless of context) should be >> >> > safe and reasonable, and should also minimize the need to override >> >> > them >> >> >> >> Please note that the TSADC is disabled in the RK3399 SoC dtsi, so >> >> having >> >> it disabled in the RK3588(s) SoC dtsi would provide some consistency. >> > >> > I'm happy to produce a patch to reverse the logic in RK3399 (and any >> > others for that matter) to also have TSADC enabled by default there, >> > thus saving several lines of code, if it's just about consistency. >> >> But why should we change something that has served us for years, on >> multiple SoCs, with zero troubles and with (AFAIK) zero boards >> producing >> puffs of bluish smoke? > > That's just if we are concerned about consistency across different SoC > series. The point is that I'm happy to make whatever change we agree > upon in a consistent way across all related .dtsi/.dts files - thus no > need to worry about past decisions that have already been implemented > for other chips. Let's just agree on the technical merits of one or > the other approach, leaving "we've been doing it differently elsewhere" > aside for now. I see, I'd also be willing to implement such cleanup patches. Though, let's also keep in mind that some past decisions might have some strong reasons behind them, which might not be obvious. That's another reason why I'm against enabling TSADC by default. >> >> Though, the RK3399 still does it in a safe way, by moving the OPPs >> >> into >> >> a separate dtsi file, named rk3399-opp.dtsi, which the board dts files >> >> then include together with enabling the TSADC. >> >> >> >> If you agree, let's employ the same approach for the RK3588(s), by >> >> having >> >> the its OPPs defined in a separate file, named rk3588s-opp.dtsi, etc. >> > >> > Separate file for OPPs is a good no-regret move to declutter the SoC >> > level .dtsi (as the OPP table is long and boring) - happy to move it >> > regardless of the outcome of the above TSADC discussion. Thanks for >> > the pointer! >> >> Yeah, but I'm not sure that everyone would like that kind of >> separation. >> In fact, such separation may be frowned upon unless it's necessary. >> >> As I already described in another thread, the separation for the >> RK3399 >> is there only because a couple of different variants of the RK3399 SoC >> require different OPPs. >> >> >> > - In context of dts/dtsi, as far as I understand the general logic >> >> > behind the split, the SoC .dtsi should contain all the things that are >> >> > fully contained within the SoC and do not depend on the wiring of a >> >> > particular board or its target use case. Boards then >> >> > add/remove/override settings to match their wiring and use case more >> >> > closely >> >> >> >> Of course, but the thermal shutdown is obviously a board-level >> >> feature, >> >> which I described further above. >> > >> > Not so obvious to me :-) I don't mean to be stubborn or uncooperative >> > here, but I really can't find any technical merit in having it enabled >> > at board level instead of SoC level. >> >> Well, please also consider that the PMICs from Rockchip are kind of >> weird little chips, specifically customized to serve particular SoCs. >> For example, they ensure the right sequencing and ramping-up of >> different power rails, which is in many cases essential. > > Sure. I'm not saying that switching to a PMIC-assisted reset shouldn't > be done where the board supports it - quite the opposite. All I'm > saying is that having at least passive cooling and CRU based resets > guaranteed for any board, regardless of how thought through its .dts > is, seems to be a better default than no thermal protection. The way I see it, which I tried to describe in my previous response, is that we can't be 100% sure that CRU-based resets would work as expected and 100% reliably on all boards. >> Thus, who knows what might (or might not) go wrong if we don't reset >> the >> PMIC at the same time when the CRU resets the SoC? Unfortunately, the >> things aren't that straightforward. >> >> On top of that, some boards, such as the Rock 5B, use a few additional >> discrete voltage regulators instead of a master-slave PMIC >> configuration, >> which may actually introduce some weird power-related issues, which >> also >> may be intermittent. Actually, I've already overheard that the Rock >> 5B >> experiences some issues of that nature, but I don't know the details. > > Those discrete regulators seem to be out of scope of this discussion. > > I agree that a deeper power-cycle with proper power-up sequence to > follow it is better when it's available in the respective hardware. > I'm also happy to provide a follow-up patch to switch from CRU to PMIC > resets for the boards I found to support the latter. > > The question we have at hand is solely about the default behavior for > a hypothetical new board with minimal .dts, or an existing board where > we can't determine the wiring of the TSHUT signal: > Option 1. Let them stay nice and warm at 120C+ under load, because > they should have known better and should have enabled the TSADC in > their device tree before putting the system under load > Option 2. Get them passively cooled at 85C under load even with no > heatsink, then force a CRU reset out of abundance of caution at 120C > unless they defined PMIC reset in their device tree > > I'm advocating for the latter. Just to clarify, the way I see it, we'd end up with having TSADC and CRU-based resets enabled for the boards we can't be sure to have support for PMIC resets. It's just that, the way I see it, TSADC wouldn't be enabled on the SoC level, but no boards would be left with no thermal runaway handling in place. >> > Switching to PMIC-assisted resets is one thing - it definitely should >> > go to board files, as it depends on the specific wiring of the >> > TSADC_SHUT signal. Enabling TSADC in a default configuration that can >> > and will work on all boards regardless of their wiring is another >> > thing. I'm just arguing for the latter. >> >> CRU-based thermal runaway handling may in theory work on all boards, >> but >> we simply can't be 100% sure without detailed insights into the board >> designs and testing. Maybe even the downstream U-Boot does some magic >> during such thermal runaway resets, which we don't know. It may be >> similar to the SoC reset issues that the RK3399 suffers from. > > That might be true, but we're talking about operation at 120C+ here. > I'd rather have my board reboot in any way it pleases under those > conditions, and have that behavior triggered by default even if it's > imperfect, then worry about the correct state of all regulators and > peripherals upon next boot. The latter is important of course, but I'd > rather let it cool down and reboot it manually anyway, because that > heat could have made more things go sideways than just the regulators. Makes sense, but as you can see above, the way I propose it no boards would be left to sizzle under load. That would be irresponsible and bad on multiple levels. >> See also my comment above. >> >> > To me it seems similar to the watchdog timer situation: we enable it >> > at the SoC level [1], as it is expected to work in its default >> > configuration regardless of the board wiring, and it provides >> > protection against system malfunctions. Doesn't matter if the board or >> > its userspace code ends up using the full functionality - it just sits >> > there waiting for its spotlight without hurting anybody. >> >> Frankly, I don't know much about the watchdog functionality, so I'd >> need >> to research it before I could say something about it. > > FWIW, watchdog resets are exclusively routed through the CRU (see > RK3588 TRM V1.0 part 1 page 31). So if we expect that one to work > somehow, probably we should expect thermal resets to work too. I'll see to reasearch that a bit, maybe I'll find something out that could be interesting or useful.