From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F85A2D97BC; Wed, 30 Jul 2025 14:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753885513; cv=none; b=G8DNOAqU6OZ0up6q6xf1LrYCPhRIdkZDQZ2Ah2ndaMFnVw0ZRRV69DtfjtcqNVDBwfxZEaYP7ukkgoChS2jMdjFBuO+Sr+BL8/JNWV+gDyQDkvb+QzqyqnG52M6goFgOR46GKkucJbTUfUPVa0mIFeStivVQvN21PpoYPZhwwYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753885513; c=relaxed/simple; bh=cBW5ZhTGEzkKjsNQyDowc6ut+7Yqtc1Qi6/6iLTumX4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=djPbHWecjt2NNB9KUWednQbrpgdnt3A9FB0Xpiw3AFMWgxJ4vHB80JuQG2QEHm6npfsa1gy9sgINx4XmiAnVyYl0OzOC4wC4nzNMUcidyRJ6pG2w01A63XrhB5zir0baDlFvX4noJ4R4kP5vOLra15/kYU35M8jkIOng5sfefec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GxMc/0D4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GxMc/0D4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 025EFC4CEE7; Wed, 30 Jul 2025 14:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753885512; bh=cBW5ZhTGEzkKjsNQyDowc6ut+7Yqtc1Qi6/6iLTumX4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GxMc/0D4t/flGgXijLtbTwdjDp1q7CWwrgk4cOmyXVB6aS+jbwcL0aU+HbjPgDNUQ lZ/AUwp1lNyZDU2nOJBAFuyqu6cRcRN0zrSIe7LWzYgRQc2OFcI0TMSwsw0Fy/tOJz GFweRh3saGRHdEBURwtDLn45XB5LaKA7e7W394mDITX2zKah/DYHoUxmWy4usb9SPx 9dLmNYCQ4oX0xqolklT/RzWDbF12o8Bl3yHZ6HDmmH9RUqvjgp65BlCqk/9BQIVGVu oGWSIypb+SinKw3vdS1104a+i2wSaglXTBQ9MAbZK1AV18o6cgm50RojV1cZuNTS/0 sGmVXGUaB8iQw== Message-ID: <6ebe7084-bb00-4fac-b64d-e08e188f3005@kernel.org> Date: Wed, 30 Jul 2025 16:25:06 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] dt-bindings: ufs: qcom: Split SC7280 and similar into separate file To: Nitin Rawat , Krzysztof Kozlowski , Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Bjorn Andersson , Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ram Kumar Dwivedi References: <20250730-dt-bindings-ufs-qcom-v1-0-4cec9ff202dc@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/07/2025 15:53, Nitin Rawat wrote: > > > On 7/30/2025 6:05 PM, Krzysztof Kozlowski wrote: >> The binding for Qualcomm SoC UFS controllers grew and it will grow >> further. It already includes several conditionals, partially for >> difference in handling encryption block (ICE, either as phandle or as IO >> address space) but it will further grow for MCQ. >> >> See also: lore.kernel.org/r/20250730082229.23475-1-quic_rdwivedi@quicinc.com >> >> The question is whether SM8650 and SM8750 should have their own schemas, >> but based on bindings above I think all devices here have MCQ? >> >> Best regards, >> Krzysztof >> > > > Hi Krzysztof, > > If I understand correctly, you're splitting the YAML files based on MCQ > (Multi-Circular Queue) support: Not entirely, I don't know which devices support MCQ. I split based on common parts in the binding. > > -qcom,sc7280-ufshc.yaml includes targets that support MCQ > -qcom,ufs-common.yaml includes common properties > -qcom,ufs.yaml includes targets that do not support MCQ > > > In future, if a new property applies to both some MCQ and some > non-MCQ targets, we would need to update both YAML files. In the current No > implementation, we handle such cases using if-else conditions to include > the new property. Hm? > > For reference, only SM8650 and SM8750 currently support MCQ, though more > targets may be added later. Are you sure? Are you claiming that SM8550 hardware does not support MCQ? > > Regarding the patch > lore.kernel.org/r/20250730082229.23475-1-quic_rdwivedi@quicinc.com, > instead of using two separate YAML files, we could use if-else > conditions to differentiate the reg and reg-name properties between MCQ > targets (SM8650 and SM8750) and non-MCQ targets (all others). It's a mess already and you want to make it messy. I already responded on that. Best regards, Krzysztof