From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
To: Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com>,
dev@dpdk.org
Cc: Keegan Freyhof <keegan.freyhof@broadcom.com>, stable@dpdk.org
Subject: RE: [PATCH] net/bnxt: fix reported VLAN stripped flag for Thor 2
Date: Tue, 3 Mar 2026 13:04:42 -0500 [thread overview]
Message-ID: <6ec6e43a646c4ae0c22ac3330d4c346b@mail.gmail.com> (raw)
In-Reply-To: <20260227202042.71404-1-Mohammad-Shuab.Siddique@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 2605 bytes --]
Acked-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
-----Original Message-----
From: Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com>
Sent: Friday, February 27, 2026 3:20 PM
To: dev@dpdk.org
Cc: kishore.padmanabha@broadcom.com; Keegan Freyhof
<keegan.freyhof@broadcom.com>; stable@dpdk.org; Mohammad Shuab Siddique
<mohammad-shuab.siddique@broadcom.com>
Subject: [PATCH] net/bnxt: fix reported VLAN stripped flag for Thor 2
From: Keegan Freyhof <keegan.freyhof@broadcom.com>
Modified the way that the scalar path reports VLAN TCI and the
RTE_MBUF_F_RX_VLAN_STRIPPED flag.
Bugzilla ID: 1868
Fixes: 65d2b0557ba3 ("net/bnxt: support Rx completion v3")
Fixes: daa02b5cddbb ("mbuf: add namespace to offload flags")
Cc: stable@dpdk.org
Signed-off-by: Keegan Freyhof <keegan.freyhof@broadcom.com>
Signed-off-by: Mohammad Shuab Siddique
<mohammad-shuab.siddique@broadcom.com>
---
drivers/net/bnxt/bnxt_rxr.c | 3 ++-
drivers/net/bnxt/bnxt_rxr.h | 7 +++++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
index c94abefa01..eb01132f48 100644
--- a/drivers/net/bnxt/bnxt_rxr.c
+++ b/drivers/net/bnxt/bnxt_rxr.c
@@ -1115,6 +1115,7 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
uint16_t cmp_type;
uint32_t vfr_flag = 0, mark_id = 0;
struct bnxt *bp = rxq->bp;
+ struct bnxt_vnic_info *vnic = rxq->vnic;
rxcmp = (struct rx_pkt_cmpl *)
&cpr->cp_desc_ring[cp_cons];
@@ -1198,7 +1199,7 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
if (cmp_type == CMPL_BASE_TYPE_RX_L2_V3) {
bnxt_parse_csum_v3(mbuf, rxcmp1);
bnxt_parse_pkt_type_v3(mbuf, rxcmp, rxcmp1);
- bnxt_rx_vlan_v3(mbuf, rxcmp, rxcmp1);
+ bnxt_rx_vlan_v3(mbuf, rxcmp, rxcmp1, vnic->vlan_strip);
if (BNXT_TRUFLOW_EN(bp))
mark_id = bnxt_ulp_set_mark_in_mbuf_v3(rxq->bp,
rxcmp1,
mbuf,
&vfr_flag);
diff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h
index 7357ca4427..f6d1e3ddfb 100644
--- a/drivers/net/bnxt/bnxt_rxr.h
+++ b/drivers/net/bnxt/bnxt_rxr.h
@@ -474,11 +474,14 @@ bnxt_parse_pkt_type_v2(struct rte_mbuf *mbuf,
static inline void bnxt_rx_vlan_v3(struct rte_mbuf *mbuf,
struct rx_pkt_cmpl *rxcmp,
- struct rx_pkt_cmpl_hi *rxcmp1)
+ struct rx_pkt_cmpl_hi *rxcmp1,
+ bool stripped)
{
if (RX_CMP_V3_VLAN_VALID(rxcmp)) {
mbuf->vlan_tci = RX_CMP_V3_METADATA0_VID(rxcmp1);
- mbuf->ol_flags |= RTE_MBUF_F_RX_VLAN |
RTE_MBUF_F_RX_VLAN_STRIPPED;
+ mbuf->ol_flags |= RTE_MBUF_F_RX_VLAN;
+ if (stripped)
+ mbuf->ol_flags |= RTE_MBUF_F_RX_VLAN_STRIPPED;
}
}
--
2.47.3
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5493 bytes --]
next prev parent reply other threads:[~2026-03-03 18:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 20:20 [PATCH] net/bnxt: fix reported VLAN stripped flag for Thor 2 Mohammad Shuab Siddique
2026-03-03 18:04 ` Kishore Padmanabha [this message]
2026-03-11 17:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ec6e43a646c4ae0c22ac3330d4c346b@mail.gmail.com \
--to=kishore.padmanabha@broadcom.com \
--cc=dev@dpdk.org \
--cc=keegan.freyhof@broadcom.com \
--cc=mohammad-shuab.siddique@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.