From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 38/40] drm/i915/execlists: Flush the CS events before unpinning Date: Mon, 1 Oct 2018 14:15:49 +0100 Message-ID: <6ec8a5e9-041f-3a7a-fe0b-0dffa1f40193@linux.intel.com> References: <20180919195544.1511-1-chris@chris-wilson.co.uk> <20180919195544.1511-38-chris@chris-wilson.co.uk> <153839197634.23109.15762220928909429157@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9AAE689FED for ; Mon, 1 Oct 2018 13:16:53 +0000 (UTC) In-Reply-To: <153839197634.23109.15762220928909429157@skylake-alporthouse-com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAxLzEwLzIwMTggMTI6MDYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTEwLTAxIDExOjUxOjIzKQo+Pgo+PiBPbiAxOS8wOS8yMDE4IDIwOjU1 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBJbnNpZGUgdGhlIGV4ZWNsaXN0cyBzdWJtaXNzaW9u IHRhc2tsZXQsIHdlIG9mdGVuIG1ha2UgdGhlIG1pc3Rha2Ugb2YKPj4+IGFzc3VtaW5nIHRoYXQg ZXZlcnl0aGluZyBiZW5lYXRoIHRoZSByZXF1ZXN0IGlzIGF2YWlsYWJsZSBmb3IgdXNlLgo+Pj4g SG93ZXZlciwgdGhlIHN1Ym1pc3Npb24gYW5kIHRoZSByZXF1ZXN0IGxpdmUgb24gdHdvIHNlcGFy YXRlIHRpbWVsaW5lcywKPj4+IGFuZCB0aGUgcmVxdWVzdCBjb250ZW50cyBtYXkgYmUgZnJlZWQg ZnJvbSBhbiBlYXJseSByZXRpcmVtZW50IGJlZm9yZSB3ZQo+Pj4gaGF2ZSBoYWQgYSBjaGFuY2Ug dG8gcnVuIHRoZSBzdWJtaXNzaW9uIHRhc2tsZXQgKHRoaW5rIGtzb2Z0aXJxZCkuIFRvCj4+PiBz YWZlZ3VhcmQgb3Vyc2VsdmVzIGFnYWluc3QgYW55IG1pc3Rha2VzLCBmbHVzaCB0aGUgdGFza2xl dCBiZWZvcmUgd2UKPj4+IHVucGluIHRoZSBjb250ZXh0IGlmIGV4ZWNsaXN0cyBzdGlsbCBoYXMg YSByZWZlcmVuY2UgdG8gdGhpcyBjb250ZXh0Lgo+Pj4KPj4+IFJlZmVyZW5jZXM6IDYwMzY3MTMy YTIxNCAoImRybS9pOTE1OiBBdm9pZCB1c2UtYWZ0ZXItZnJlZSBvZiBjdHggaW4gcmVxdWVzdCB0 cmFjZXBvaW50cyIpCj4+PiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4KPj4+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50 ZWwuY29tPgo+Pj4gLS0tCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250 ZXh0LmggfCAgMSArCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyAgICAg ICAgfCAzMiArKysrKysrKysrKysrKysrKysrKysrKystCj4+PiAgICAyIGZpbGVzIGNoYW5nZWQs IDMyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5oIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW1fY29udGV4dC5oCj4+PiBpbmRleCA5Zjg5MTE5YTY1NjYuLjFmZDcxZGZkZmE2 MiAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQu aAo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5oCj4+PiBA QCAtMTcwLDYgKzE3MCw3IEBAIHN0cnVjdCBpOTE1X2dlbV9jb250ZXh0IHsKPj4+ICAgICAgICAv KiogZW5naW5lOiBwZXItZW5naW5lIGxvZ2ljYWwgSFcgc3RhdGUgKi8KPj4+ICAgICAgICBzdHJ1 Y3QgaW50ZWxfY29udGV4dCB7Cj4+PiAgICAgICAgICAgICAgICBzdHJ1Y3QgaTkxNV9nZW1fY29u dGV4dCAqZ2VtX2NvbnRleHQ7Cj4+PiArICAgICAgICAgICAgIHN0cnVjdCBpbnRlbF9lbmdpbmVf Y3MgKmFjdGl2ZTsKPj4+ICAgICAgICAgICAgICAgIHN0cnVjdCBpOTE1X3ZtYSAqc3RhdGU7Cj4+ PiAgICAgICAgICAgICAgICBzdHJ1Y3QgaW50ZWxfcmluZyAqcmluZzsKPj4+ICAgICAgICAgICAg ICAgIHUzMiAqbHJjX3JlZ19zdGF0ZTsKPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4+PiBp bmRleCA0OGEyYmNhN2ZlYzMuLmJlN2RiZGQ3ZmMyYyAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9scmMuYwo+Pj4gQEAgLTI4Miw2ICsyODIsOCBAQCBzdGF0aWMgdm9pZCBfX3Vud2luZF9p bmNvbXBsZXRlX3JlcXVlc3RzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPj4+ICAg ICAgICAgICAgICAgIF9faTkxNV9yZXF1ZXN0X3Vuc3VibWl0KHJxKTsKPj4+ICAgICAgICAgICAg ICAgIHVud2luZF93YV90YWlsKHJxKTsKPj4+ICAgIAo+Pj4gKyAgICAgICAgICAgICBHRU1fQlVH X09OKHJxLT5od19jb250ZXh0LT5hY3RpdmUpOwo+Pj4gKwo+Pj4gICAgICAgICAgICAgICAgR0VN X0JVR19PTihycV9wcmlvKHJxKSA9PSBJOTE1X1BSSU9SSVRZX0lOVkFMSUQpOwo+Pj4gICAgICAg ICAgICAgICAgaWYgKHJxX3ByaW8ocnEpICE9IHByaW8pIHsKPj4+ICAgICAgICAgICAgICAgICAg ICAgICAgcHJpbyA9IHJxX3ByaW8ocnEpOwo+Pj4gQEAgLTQyNyw4ICs0MjksMTEgQEAgc3RhdGlj IHZvaWQgZXhlY2xpc3RzX3N1Ym1pdF9wb3J0cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp bmUpCj4+PiAgICAgICAgICAgICAgICBycSA9IHBvcnRfdW5wYWNrKCZwb3J0W25dLCAmY291bnQp Owo+Pj4gICAgICAgICAgICAgICAgaWYgKHJxKSB7Cj4+PiAgICAgICAgICAgICAgICAgICAgICAg IEdFTV9CVUdfT04oY291bnQgPiAhbik7Cj4+PiAtICAgICAgICAgICAgICAgICAgICAgaWYgKCFj b3VudCsrKQo+Pj4gKyAgICAgICAgICAgICAgICAgICAgIGlmICghY291bnQrKykgewo+Pj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgR0VNX0JVR19PTihycS0+aHdfY29udGV4dC0+YWN0 aXZlKTsKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBleGVjbGlzdHNfY29udGV4 dF9zY2hlZHVsZV9pbihycSk7Cj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBycS0+ aHdfY29udGV4dC0+YWN0aXZlID0gZW5naW5lOwo+Pgo+PiBQdXQgaXQgaW4gZXhlY2xpc3RzX2Nv bnRleHRfc2NoZWR1bGVfaW4vb3V0Pwo+Pgo+PiBXaHkgZG9lcyBpdCBoYXZlIHRvIGJlIHRoZSBl bmdpbmUgcG9pbnRlciBhbmQgbm90IGp1c3QgYSBib29sZWFuPwo+PiBCZWNhdXNlIHdlIGRvbid0 IGhhdmUgYW4gZW5naW5lIGJhY2twb2ludGVyIGluIGh3X2NvbnRleHQ/IFNob3VsZCB3ZSBhZGQK Pj4gaXQ/IEkgdGhpbmsgSSBoYWQgb2NjYXNpb25hbGx5IHdpc2hlZCB3ZSBoYWQgaXQuLiBtYXli ZSB0b28gbXVjaCB3b3JrIHRvCj4+IGV2YWx1YXRlIHdoYXQgZnVuY3Rpb24gcHJvdG90eXBlcyB3 ZSBjb3VsZCBjbGVhbiB1cCB3aXRoIGl0IGFuZCB3aGV0aGVyCj4+IGl0IHdvdWxkIGJlIGFuIG92 ZXJhbGwgZ2Fpbi4KPiAKPiBJdCdzIGEgYmFja3BvaW50ZXIgaW4gaHdfY29udGV4dCBmb3IgdGhl IHB1cnBvc2VzIG9mIGJlaW5nIGEgYmFja3BvaW50ZXIKPiBpbiBod19jb250ZXh0LiBJdHMgcHVy cG9zZSBpcyBmb3I6Cj4gCj4gCWFjdGl2ZSA9IFJFQURfT05DRSh2ZS0+Y29udGV4dC5hY3RpdmUp Owo+ICAgICAgICAgIGlmIChhY3RpdmUgJiYgYWN0aXZlICE9IGVuZ2luZSkgewo+ICAgICAgICAg IAlyYiA9IHJiX25leHQocmIpOwo+ICAgICAgICAgIAljb250aW51ZTsKPiAgICAgICAgICB9CgpZ ZWFoLCBJIHdhcyBhc2tpbmcgd2h5IG5vdCBjYWxsIGl0ICdlbmdpbmUnIGFuZCBoYXZlIHRoZSBh Y3RpdmUgZmxhZyBhcyAKYm9vbGVhbi4gSSBndWVzcyBiZWNhdXNlIGNlLT5lbmdpbmUgd2lsbCBu b3QgYmUgcGVybWFuZW50IHNvb24uCgo+IAo+Pj4gKyAgICAgICAgICAgICAgICAgICAgIH0KPj4+ ICAgICAgICAgICAgICAgICAgICAgICAgcG9ydF9zZXQoJnBvcnRbbl0sIHBvcnRfcGFjayhycSwg Y291bnQpKTsKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgZGVzYyA9IGV4ZWNsaXN0c191cGRh dGVfY29udGV4dChycSk7Cj4+PiAgICAgICAgICAgICAgICAgICAgICAgIEdFTV9ERUJVR19FWEVD KHBvcnRbbl0uY29udGV4dF9pZCA9IHVwcGVyXzMyX2JpdHMoZGVzYykpOwo+Pj4gQEAgLTczNCw2 ICs3MzksOCBAQCBleGVjbGlzdHNfY2FuY2VsX3BvcnRfcmVxdWVzdHMoc3RydWN0IGludGVsX2Vu Z2luZV9leGVjbGlzdHMgKiBjb25zdCBleGVjbGlzdHMpCj4+PiAgICAgICAgICAgICAgICAgICAg ICAgICAgaW50ZWxfZW5naW5lX2dldF9zZXFubyhycS0+ZW5naW5lKSk7Cj4+PiAgICAKPj4+ICAg ICAgICAgICAgICAgIEdFTV9CVUdfT04oIWV4ZWNsaXN0cy0+YWN0aXZlKTsKPj4+ICsKPj4+ICsg ICAgICAgICAgICAgcnEtPmh3X2NvbnRleHQtPmFjdGl2ZSA9IE5VTEw7Cj4+PiAgICAgICAgICAg ICAgICBleGVjbGlzdHNfY29udGV4dF9zY2hlZHVsZV9vdXQocnEsCj4+PiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaTkxNV9yZXF1ZXN0X2NvbXBsZXRlZChy cSkgPwo+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIElO VEVMX0NPTlRFWFRfU0NIRURVTEVfT1VUIDoKPj4+IEBAIC05NzEsNiArOTc4LDcgQEAgc3RhdGlj IHZvaWQgcHJvY2Vzc19jc2Ioc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+Pj4gICAg ICAgICAgICAgICAgICAgICAgICAgKi8KPj4+ICAgICAgICAgICAgICAgICAgICAgICAgR0VNX0JV R19PTighaTkxNV9yZXF1ZXN0X2NvbXBsZXRlZChycSkpOwo+Pj4gICAgCj4+PiArICAgICAgICAg ICAgICAgICAgICAgcnEtPmh3X2NvbnRleHQtPmFjdGl2ZSA9IE5VTEw7Cj4+PiAgICAgICAgICAg ICAgICAgICAgICAgIGV4ZWNsaXN0c19jb250ZXh0X3NjaGVkdWxlX291dChycSwKPj4+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIElOVEVMX0NP TlRFWFRfU0NIRURVTEVfT1VUKTsKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgaTkxNV9yZXF1 ZXN0X3B1dChycSk7Cj4+PiBAQCAtMTA4MCw2ICsxMDg4LDI4IEBAIHN0YXRpYyB2b2lkIGV4ZWNs aXN0c19jb250ZXh0X2Rlc3Ryb3koc3RydWN0IGludGVsX2NvbnRleHQgKmNlKQo+Pj4gICAgCj4+ PiAgICBzdGF0aWMgdm9pZCBleGVjbGlzdHNfY29udGV4dF91bnBpbihzdHJ1Y3QgaW50ZWxfY29u dGV4dCAqY2UpCj4+PiAgICB7Cj4+PiArICAgICBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp bmU7Cj4+PiArCj4+PiArICAgICAvKgo+Pj4gKyAgICAgICogVGhlIHRhc2tsZXQgbWF5IHN0aWxs IGJlIHVzaW5nIGEgcG9pbnRlciB0byBvdXIgc3RhdGUsIHZpYSBhbgo+Pj4gKyAgICAgICogb2xk IHJlcXVlc3QuIEhvd2V2ZXIsIHNpbmNlIHdlIGtub3cgd2Ugb25seSB1bnBpbiB0aGUgY29udGV4 dAo+Pj4gKyAgICAgICogb24gcmV0aXJlbWVudCBvZiB0aGUgZm9sbG93aW5nIHJlcXVlc3QsIHdl IGtub3cgdGhhdCB0aGUgbGFzdAo+Pj4gKyAgICAgICogcmVxdWVzdCByZWZlcmVuY2luZyB1cyB3 aWxsIGhhdmUgaGFkIGEgY29tcGxldGlvbiBDUyBpbnRlcnJ1cHQuCj4+Cj4+IEhtIGhtIGhtLi4u IG15IGluaXRpYWwgdGhvdWdodCB3YXMgdGhhdCBpbnRlcnJ1cHRzIGNvdWxkIGJlIG1vcmUgZGVs YXllZAo+PiB0aGFuIGJyZWFkY3J1bWIgd3JpdGVzIChtb3JlIHRoYW4gb25lIGNvbnRleHQgYWhl YWQpLCBpbiB3aGljaCBjYXNlIHRoZQo+PiBwcm9jZXNzX2NzYiBiZWxvdyBjb3VsZCBiZSBwcmVt YXR1cmUgYW5kIHRoZSBhc3NlcnQgd291bGQgdHJpZ2dlci4gQnV0IEkKPj4gbXVzdCBiZSBmb3Jn ZXR0aW5nIHNvbWV0aGluZyBzaW5jZSB0aGF0IHdvdWxkIGFsc28gbWVhbiB3ZSB3b3VsZAo+PiBw cmVtYXR1cmVseSB1bnBpbiB0aGUgY29udGV4dC4gU28gSSBtdXN0IGJlIGZvcmdldHRpbmcgc29t ZXRoaW5nLi4KPiAKPiBUaGVyZSB3aWxsIGhhdmUgYmVlbiBhdCBsZWFzdCBvbmUgQ1MgZXZlbnQg d3JpdHRlbiBiZWNhdXNlIHdlIGhhdmUKPiBzd2l0Y2hlZCBjb250ZXh0cyBkdWUgdG8gdGhlIHVu cGluIGJlaW5nIG9uZSBzZXFubyBiZWhpbmQuIEkgaGF2ZSBub3QKPiAoeWV0KSBvYnNlcnZlZCBD UyBldmVudHMgYmVpbmcgb3V0IG9mIG9yZGVyIHdpdGggYnJlYWRjcnVtYiB3cml0ZXMgKGFuZAo+ IHdlIGhhdmUgdmVyeSBzdHJpY3QgY2hlY2tpbmcpIHNvIGNvbmZpZGVudCB0aGF0IGEgc2luZ2xl IHByb2Nlc3NfY3NiKCkKPiBpcyByZXF1aXJlZCByYXRoZXIgdGhhbiBhIGxvb3AuCgpJIGRpZCBu b3QgbWVhbiBvdXQgb2Ygb3JkZXIgYnV0IGp1c3QgZGVsYXllZC4KClNheSBwb3J0IDAgJiAxIGFy ZSBib3RoIHN1Ym1pdHRlZCwgd2Ugb2JzZXJ2ZSBzZXFubyAxICYgMiBhcyBjb21wbGV0ZSwgCmJ1 dCB0aGUgY3R4IGNvbXBsZXRlIGlycS9oYW5kbGVyIGhhcyBiZWVuIGRlbGF5ZWQuIFdlIGdvIHRv IHVucGluIGN0eDAgCihwb3J0MCkgYnV0IGNlLT5hY3RpdmUgaGFzbid0IGJlZW4gY2xlYXJlZCBk dWUgbm8gY3R4IGNvbXBsZXRlIHlldCBzbyAKdGhlIGFzc2VydCB0cmlnZ2Vycy4gSW1wb3NzaWJs ZSBpbiB5b3VyIGV4cGVyaWVuY2U/CgpSZWdhcmRzLAoKVHZydGtvCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==