Re: [PATCH] platform/x86/amd: Extend Framework 13 quirk to more BIOSes

[Hans de Goede <hdegoede@redhat.com>]

Hi Mario, Ilpo,

On 4/10/24 4:10 PM, Mario Limonciello wrote:
> BIOS 03.05 still hasn't fixed the spurious IRQ1 issue.  As it's still
> being worked on there is still a possiblitiy that it won't need to
> apply to future BIOS releases.
> 
> Add a quirk for BIOS 03.05 as well.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Ilpo, since this fixes a bug and does so based on a DMI match,
so the chance for regressions is quite small, I believe it
would be best to merge this through the pdx86/fixes branch,
can you pick this patch up please ?

Regards,

Hans



> ---
>  drivers/platform/x86/amd/pmc/pmc-quirks.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> index b456370166b6..b4f49720c87f 100644
> --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
> +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> @@ -208,6 +208,15 @@ static const struct dmi_system_id fwbug_list[] = {
>  			DMI_MATCH(DMI_BIOS_VERSION, "03.03"),
>  		}
>  	},
> +	{
> +		.ident = "Framework Laptop 13 (Phoenix)",
> +		.driver_data = &quirk_spurious_8042,
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Framework"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Laptop 13 (AMD Ryzen 7040Series)"),
> +			DMI_MATCH(DMI_BIOS_VERSION, "03.05"),
> +		}
> +	},
>  	{}
>  };
>