From: Hayes Wang <hayeswang@realtek.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: USB list <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: handling MAC set by user space in reset_resume() of r8152
Date: Thu, 28 Jul 2022 09:41:16 +0000 [thread overview]
Message-ID: <6ed729b080c04fc8b93b43b09cf42be0@realtek.com> (raw)
In-Reply-To: <4dfebefb-b4a4-ccdb-d0f7-015273710076@suse.com>
Oliver Neukum <oneukum@suse.com>
[...]
> OK, thank you. Do you agree that a manually set MAC needs to be kept
> even through a pre/post_reset() and reset_resume(), while a MAC passed
> through needs to be reevaluated at pre/post_reset() but not at
> reset_resume()
Yes. I think a user wishes to keep it.
> > Besides, I don't understand why you set tp->external_mac = false
> > in rtl8152_down().
>
> Frankly I need to undo the effect of ndo_set_mac_address()
> at some time, but it is unclear to me how to return a network
> interface to its "native" MAC.
> Any ideas?
I am not sure. Is it necessary?
If I change the MAC address, I don't hope it is recovered unexpectedly
unless the system is rebooted or shutdown.
Best Regards,
Hayes
prev parent reply other threads:[~2022-07-28 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 11:39 handling MAC set by user space in reset_resume() of r8152 Oliver Neukum
2022-07-27 18:34 ` Andrew Lunn
2022-07-28 8:40 ` Hayes Wang
2022-07-28 8:54 ` Oliver Neukum
2022-07-28 9:41 ` Hayes Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ed729b080c04fc8b93b43b09cf42be0@realtek.com \
--to=hayeswang@realtek.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.