Re: [PATCH v2 3/6] arm64: dts: exynos7870: add DSI support

[Krzysztof Kozlowski <krzk@kernel.org>]

On 26/06/2025 22:13, Kaustabh Chakraborty wrote:
>  			reboot-mode {
>  				compatible = "syscon-reboot-mode";
>  				offset = <0x080c>;
> @@ -674,6 +682,83 @@ cmu_isp: clock-controller@144d0000 {
>  				 <&cmu_mif CLK_GOUT_MIF_CMU_ISP_VRA>;
>  		};
>  
> +		syscon_cam0: syscon@144f1040 {
> +			compatible = "samsung,exynos7870-cam0-sysreg", "syscon";
> +			reg = <0x144f1040 0x04>;
> +		};
> +
> +		dsi: dsi@14800000 {
> +			compatible = "samsung,exynos7870-mipi-dsi";
> +			reg = <0x14800000 0x100>;
> +			interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			clock-names = "bus", "pll", "byte", "esc";
> +			clocks = <&cmu_dispaud CLK_GOUT_DISPAUD_BUS_DISP>,
> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_APB_DISP>,
> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_MIPIPHY_TXBYTECLKHS_USER>,
> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_MIPIPHY_RXCLKESC0_USER>;

First clocks, then clock-names, please. Same for phys here and in all
other place.

> +
> +			phy-names = "dsim";
> +			phys = <&mipi_phy 1>;
> +
> +			status = "disabled";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +
> +					dsi_to_decon: endpoint {
> +						remote-endpoint = <&decon_to_dsi>;
> +					};
> +				};
> +			};
> +		};
> +
> +		decon: decon@14830000 {

node name: display-controller@

> +			compatible = "samsung,exynos7870-decon";
> +			reg = <0x14830000 0x8000>;
> +			interrupt-names = "fifo", "vsync", "lcd_sys";
> +			interrupts = <GIC_SPI 201 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			clock-names = "pclk_decon0", "aclk_decon0",
> +				      "decon0_eclk", "decon0_vclk";
> +			clocks = <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_PLL>,
> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_BUS_USER>,
> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_DECON_ECLK>,
> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_DECON_VCLK>;
> +
> +			iommus = <&sysmmu_decon>;
> +
> +			status = "disabled";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					decon_to_dsi: endpoint {
> +						remote-endpoint = <&dsi_to_decon>;
> +					};
> +				};
> +			};
> +		};
> +
> +		sysmmu_decon: sysmmu@14860000 {

iommu@

> +			compatible = "samsung,exynos-sysmmu";
> +			reg = <0x14860000 0x1000>;
> +			interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
> +			#iommu-cells = <0>;
> +
> +			clock-names = "sysmmu";
> +			clocks = <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_BUS_USER>;
> +		};



Best regards,
Krzysztof