All of lore.kernel.org
 help / color / mirror / Atom feed
From: yiboz@codeaurora.org
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 2/4] mac80211: fix issue in loop scenario
Date: Wed, 18 Dec 2019 18:12:32 +0800	[thread overview]
Message-ID: <6f092bd44cfc581a219bd0f0506cc636@codeaurora.org> (raw)
In-Reply-To: <94471b2381bee394f9708eae8ba47129f3facd03.camel@sipsolutions.net>

在 2019-12-13 17:56，Johannes Berg 写道：
> On Fri, 2019-12-13 at 15:19 +0800, Yibo Zhao wrote:
>> In a loop txqs dequeue scenario, if the first txq in the rbtree gets
>> removed from rbtree immediately in the ieee80211_return_txq(), the
>> loop will break soon in the ieee80211_next_txq() due to schedule_pos
>> not leading to the second txq in the rbtree. Thus update schedule_pos
>> to previous node once the node of schedule_pos is either removed from
>> rbtree or move to other location in rbtree due to airtime update.
> 
> For my understanding - this is a fix to the first patch in the series?
> 
> I guess you didn't squash it because that's Toke's patch or something?
> 
> I tend to think you still should, and annotate the changes, but I 
> wanted
> to understand it first.

Hi Johannes,

Yes, this is a fix to the first patch. Actually, the rest of two patches 
are also serve the same. So, are you suggesting to merge them to the 
first patch?

Previouly, I had added Toke's signature in this patch but Toke advised 
to delete it. I feel a little bit confused about how to handle it. 
Appreciate any detail guide.
> 
> johannes

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: yiboz@codeaurora.org
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 2/4] mac80211: fix issue in loop scenario
Date: Wed, 18 Dec 2019 18:12:32 +0800	[thread overview]
Message-ID: <6f092bd44cfc581a219bd0f0506cc636@codeaurora.org> (raw)
In-Reply-To: <94471b2381bee394f9708eae8ba47129f3facd03.camel@sipsolutions.net>

在 2019-12-13 17:56，Johannes Berg 写道：
> On Fri, 2019-12-13 at 15:19 +0800, Yibo Zhao wrote:
>> In a loop txqs dequeue scenario, if the first txq in the rbtree gets
>> removed from rbtree immediately in the ieee80211_return_txq(), the
>> loop will break soon in the ieee80211_next_txq() due to schedule_pos
>> not leading to the second txq in the rbtree. Thus update schedule_pos
>> to previous node once the node of schedule_pos is either removed from
>> rbtree or move to other location in rbtree due to airtime update.
> 
> For my understanding - this is a fix to the first patch in the series?
> 
> I guess you didn't squash it because that's Toke's patch or something?
> 
> I tend to think you still should, and annotate the changes, but I 
> wanted
> to understand it first.

Hi Johannes,

Yes, this is a fix to the first patch. Actually, the rest of two patches 
are also serve the same. So, are you suggesting to merge them to the 
first patch?

Previouly, I had added Toke's signature in this patch but Toke advised 
to delete it. I feel a little bit confused about how to handle it. 
Appreciate any detail guide.
> 
> johannes

  reply	other threads:[~2019-12-18 10:12 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13  7:19 [PATCH V4 0/4] Enable virtual time-based airtime scheduler support on ath10k Yibo Zhao
2019-12-13  7:19 ` Yibo Zhao
2019-12-13  7:19 ` [PATCH 1/4] mac80211: Switch to a virtual time-based airtime scheduler Yibo Zhao
2019-12-13  7:19   ` Yibo Zhao
2019-12-13  7:19 ` [PATCH 2/4] mac80211: fix issue in loop scenario Yibo Zhao
2019-12-13  7:19   ` Yibo Zhao
2019-12-13  9:56   ` Johannes Berg
2019-12-13  9:56     ` Johannes Berg
2019-12-18 10:12     ` yiboz [this message]
2019-12-18 10:12       ` yiboz
2019-12-18 10:18       ` Johannes Berg
2019-12-18 10:18         ` Johannes Berg
2019-12-18 10:37         ` Toke Høiland-Jørgensen
2019-12-18 10:37           ` Toke Høiland-Jørgensen
2019-12-13  7:19 ` [PATCH 3/4] mac80211: fix low throughput in multi-clients situation Yibo Zhao
2019-12-13  7:19   ` Yibo Zhao
2020-01-08 10:46   ` Justin Capella
2020-01-08 10:46     ` Justin Capella
2020-01-08 11:31     ` Toke Høiland-Jørgensen
2020-01-08 11:31       ` Toke Høiland-Jørgensen
2019-12-13  7:19 ` [PATCH 4/4] mac80211: Sync airtime weight sum with per AC synced sta airtime weight together Yibo Zhao
2019-12-13  7:19   ` Yibo Zhao
2019-12-13  9:58   ` Johannes Berg
2019-12-13  9:58     ` Johannes Berg
2019-12-17 15:20     ` Toke Høiland-Jørgensen
2019-12-17 15:20       ` Toke Høiland-Jørgensen
2019-12-13  9:03 ` [PATCH V4 0/4] Enable virtual time-based airtime scheduler support on ath10k Justin Capella
2019-12-13  9:03   ` Justin Capella
2019-12-13 10:06   ` Toke Høiland-Jørgensen
2019-12-13 10:06     ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f092bd44cfc581a219bd0f0506cc636@codeaurora.org \
    --to=yiboz@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.