From: Yanteng Si <si.yanteng@linux.dev>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>,
Furong Xu <0x1207@gmail.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v4 2/3] net: stmmac: Limit FIFO size by hardware capability
Date: Tue, 28 Jan 2025 02:11:36 +0800 [thread overview]
Message-ID: <6f1126a7-b35a-4dc0-9c6e-29cfb6e7a145@linux.dev> (raw)
In-Reply-To: <20250127013820.2941044-3-hayashi.kunihiko@socionext.com>
在 1/27/25 09:38, Kunihiko Hayashi 写道:
> Tx/Rx FIFO size is specified by the parameter "{tx,rx}-fifo-depth" from
> stmmac_platform layer.
>
> However, these values are constrained by upper limits determined by the
> capabilities of each hardware feature. There is a risk that the upper
> bits will be truncated due to the calculation, so it's appropriate to
> limit them to the upper limit values and display a warning message.
>
> This only works if the hardware capability has the upper limit values.
>
> Fixes: e7877f52fd4a ("stmmac: Read tx-fifo-depth and rx-fifo-depth from the devicetree")
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Reviewed-by: Yanteng Si <si.yanteng@linux.dev>
Thanks,
Yanteng
next prev parent reply other threads:[~2025-01-27 18:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 1:38 [PATCH net v4 0/3] Limit devicetree parameters to hardware capability Kunihiko Hayashi
2025-01-27 1:38 ` [PATCH net v4 1/3] net: stmmac: Limit the number of MTL queues " Kunihiko Hayashi
2025-01-27 18:07 ` Yanteng Si
2025-01-27 1:38 ` [PATCH net v4 2/3] net: stmmac: Limit FIFO size by " Kunihiko Hayashi
2025-01-27 18:11 ` Yanteng Si [this message]
2025-01-27 1:38 ` [PATCH net v4 3/3] net: stmmac: Specify hardware capability value when FIFO size isn't specified Kunihiko Hayashi
2025-01-27 18:24 ` Yanteng Si
2025-01-31 9:46 ` Steven Price
2025-01-31 14:15 ` Andrew Lunn
2025-01-31 14:33 ` Steven Price
2025-01-31 14:47 ` Andrew Lunn
2025-01-31 15:03 ` Steven Price
2025-01-31 15:29 ` Andrew Lunn
2025-01-31 15:54 ` Steven Price
2025-01-31 16:07 ` Andrew Lunn
2025-02-01 12:10 ` Xi Ruoyao
2025-02-01 21:03 ` Andrew Lunn
2025-02-01 19:14 ` Guenter Roeck
2025-02-01 19:21 ` Andrew Lunn
2025-02-01 20:25 ` Guenter Roeck
2025-02-01 20:35 ` Russell King (Oracle)
2025-02-01 22:02 ` Guenter Roeck
2025-02-03 2:45 ` Kunihiko Hayashi
2025-02-03 9:23 ` Russell King (Oracle)
2025-02-03 11:32 ` Kunihiko Hayashi
2025-02-03 11:55 ` Kunihiko Hayashi
2025-01-28 12:20 ` [PATCH net v4 0/3] Limit devicetree parameters to hardware capability patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f1126a7-b35a-4dc0-9c6e-29cfb6e7a145@linux.dev \
--to=si.yanteng@linux.dev \
--cc=0x1207@gmail.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.