From: Oleksii Kurochko <oleksii.kurochko@gmail.com>
To: Julien Grall <julien@xen.org>,
"Orzel, Michal" <michal.orzel@amd.com>,
Mykola Kvach <mykola_kvach@epam.com>,
xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
Luca Fancellu <luca.fancellu@arm.com>,
Mykola Kvach <xakep.amatop@gmail.com>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: Re: [PATCH for-4.22 v2.5] xen/arm: gic: defer host LPI allocation until after ITS init
Date: Fri, 19 Jun 2026 15:17:30 +0200 [thread overview]
Message-ID: <6f154afa-38b0-4193-be42-585f4ce72fc8@gmail.com> (raw)
In-Reply-To: <5d3dff74-f51d-4bfc-b917-3c84f2094f34@xen.org>
On 6/19/26 1:52 PM, Julien Grall wrote:
>
>
> On 19/06/2026 12:34, Orzel, Michal wrote:
>>
>>
>> On 19-Jun-26 13:23, Julien Grall wrote:
>>> Hi Michal,
>>>
>>> On 19/06/2026 10:48, Orzel, Michal wrote:
>>>> @Oleksii, can we ask for a release ack here?
>>>
>>> Can you explain the pros/cons of introducing this patch quite late?
>> The advantage is that it fixes the broken LPIs on affected hardware.
>
> > The disadvantage is the reordering risk but I don't think there is
> any issue.
>
> See more below.
>>>
>>> One of the risk here is that we are now initializing the LPIs *after*
>>> the ITSes. I understand this is because we want to know the workaround.
>>> However, I vaguely recall that there was a dependency in the
>>> configuration. So are we confident the new ordering will not bring other
>>> issues? Ideally this should have been explained in the commit message.
>> gic-v3-its.c never references host LPI state, so ITS init has no
>> dependency on LPIs.
>
> My concern is at the HW level. The ITS is using LPIs. But we will
> configure the ITS first and then the LPIs.
>
> What probaly saves us is the fact gicv3_lpi_init_host_lpis() only seem
> to allocate memory. This is a bit fragile though.
Julien, do you think that a fix should be done differently and this one
isn't really acceptable?
~ Oleksii
next prev parent reply other threads:[~2026-06-19 13:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 0:25 [PATCH v2 0/4] xen/arm: gicv3: defer host LPI init and split ITS/LPI quirk scopes Mykola Kvach
2026-05-28 0:25 ` [PATCH for-4.22 v2 1/4] xen/arm: gic: defer host LPI allocation until after ITS init Mykola Kvach
2026-06-03 11:19 ` Oleksandr Tyshchenko
2026-06-05 6:28 ` Mykola Kvach
2026-06-05 7:20 ` Oleksandr Tyshchenko
2026-06-19 5:45 ` [PATCH for-4.22 v2.5] " Mykola Kvach
2026-06-19 6:09 ` Orzel, Michal
2026-06-19 9:48 ` Orzel, Michal
2026-06-19 11:23 ` Julien Grall
2026-06-19 11:34 ` Orzel, Michal
2026-06-19 11:52 ` Julien Grall
2026-06-19 13:17 ` Oleksii Kurochko [this message]
2026-06-19 14:44 ` Julien Grall
2026-06-19 14:55 ` Mykola Kvach
2026-06-19 17:23 ` Julien Grall
2026-06-21 15:49 ` Mykola Kvach
2026-06-22 9:20 ` Oleksii Kurochko
2026-05-28 0:25 ` [PATCH v2 2/4] xen/arm: its: separate ITS and host LPI quirk scopes Mykola Kvach
2026-07-22 11:56 ` Orzel, Michal
2026-07-31 8:24 ` Orzel, Michal
2026-09-22 14:02 ` Mykola Kvach
2026-05-28 0:25 ` [PATCH v2 3/4] xen/arm: its: refactor ITS quirk matching Mykola Kvach
2026-07-31 8:34 ` Orzel, Michal
2026-09-22 14:05 ` Mykola Kvach
2026-05-28 0:25 ` [PATCH v2 4/4] xen/arm: its: handle dma-noncoherent on GIC and ITS nodes Mykola Kvach
2026-07-31 8:39 ` Orzel, Michal
2026-09-22 14:08 ` Mykola Kvach
2026-05-28 0:43 ` [PATCH v2 0/4] xen/arm: gicv3: defer host LPI init and split ITS/LPI quirk scopes Mykola Kvach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f154afa-38b0-4193-be42-585f4ce72fc8@gmail.com \
--to=oleksii.kurochko@gmail.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=luca.fancellu@arm.com \
--cc=michal.orzel@amd.com \
--cc=mykola_kvach@epam.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=xakep.amatop@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.