From: Adam Young <admiyo@amperemail.onmicrosoft.com>
To: admiyo@os.amperecomputing.com,
Sudeep Holla <sudeep.holla@arm.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Robert Moore <robert.moore@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Huisong Li <lihuisong@huawei.com>
Subject: Re: [PATCH net-next v22 1/2] mailbox/pcc: support mailbox management of the shared buffer
Date: Mon, 14 Jul 2025 19:02:04 -0400 [thread overview]
Message-ID: <6f29a47b-13a3-4e41-808b-e29a41799ec1@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <20250710191209.737167-2-admiyo@os.amperecomputing.com>
Internal review discovered an error
On 7/10/25 15:12, admiyo@os.amperecomputing.com wrote:
> + if (pchan->chan.rx_alloc)
> + ret = pcc_write_to_buffer(chan, data);
This is the wrong check. The rx_alloc is expected to be used for the
type4, and the will be called from the type 3.
Going to add an explicit flag instead.
> + pcc_hdr = pchan->chan.shmem;
> + if (ioread32(&pcc_hdr->flags) & PCC_CMD_COMPLETION_NOTIFY)
> + pchan->chan.irq_ack = true;
This flag can be removed and replaced with a check of the value in the
original buffer, which is held in chan->current_req.
Updated version of the patch series to follow.
next prev parent reply other threads:[~2025-07-14 23:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 19:12 [PATCH net-next v22 0/2] MCTP Over PCC Transport admiyo
2025-07-10 19:12 ` [PATCH net-next v22 1/2] mailbox/pcc: support mailbox management of the shared buffer admiyo
2025-07-11 6:51 ` kernel test robot
2025-07-14 19:37 ` Dan Carpenter
2025-07-14 23:02 ` Adam Young [this message]
2025-07-10 19:12 ` [PATCH net-next v22 2/2] mctp pcc: Implement MCTP over PCC Transport admiyo
2025-07-11 11:02 ` kernel test robot
2025-07-11 12:52 ` Jeremy Kerr
2025-07-11 20:03 ` Adam Young
2025-07-14 8:21 ` Jeremy Kerr
-- strict thread matches above, loose matches on Subject: below --
2025-07-11 22:13 [PATCH net-next v22 1/2] mailbox/pcc: support mailbox management of the shared buffer kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f29a47b-13a3-4e41-808b-e29a41799ec1@amperemail.onmicrosoft.com \
--to=admiyo@amperemail.onmicrosoft.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=admiyo@os.amperecomputing.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jassisinghbrar@gmail.com \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.