All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hansg@kernel.org>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	lee@kernel.org, danielt@kernel.org, jingoohan1@gmail.com,
	neil.armstrong@linaro.org, jessica.zhang@oss.qualcomm.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	airlied@gmail.com, simona@ffwll.ch, fnkl.kernel@gmail.com,
	j@jannau.net, ilpo.jarvinen@linux.intel.com, sven@kernel.org,
	alyssa@rosenzweig.io, neal@gompa.dev, deller@gmx.de,
	support.opensource@diasemi.com, duje.mihanovic@skole.hr
Cc: dri-devel@lists.freedesktop.org, asahi@lists.linux.dev,
	platform-driver-x86@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 01/12] platform/x86: dell-uart-backlight: Use blacklight power constant
Date: Wed, 18 Jun 2025 15:01:14 +0200	[thread overview]
Message-ID: <6f644654-c906-46f0-942e-ad50ba159786@kernel.org> (raw)
In-Reply-To: <20250618122436.379013-2-tzimmermann@suse.de>

Hi,

On 18-Jun-25 2:16 PM, Thomas Zimmermann wrote:
> The backlight subsystem has gotten its own power constants. Replace
> FB_BLANK_UNBLANK with BACKLIGHT_POWER_ON.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hansg@kernel.org>

Regards,

Hans




> ---
>  drivers/platform/x86/dell/dell-uart-backlight.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/dell/dell-uart-backlight.c b/drivers/platform/x86/dell/dell-uart-backlight.c
> index 8f868f845350..f323a667dc2d 100644
> --- a/drivers/platform/x86/dell/dell-uart-backlight.c
> +++ b/drivers/platform/x86/dell/dell-uart-backlight.c
> @@ -305,7 +305,7 @@ static int dell_uart_bl_serdev_probe(struct serdev_device *serdev)
>  	dev_dbg(dev, "Firmware version: %.*s\n", resp[RESP_LEN] - 3, resp + RESP_DATA);
>  
>  	/* Initialize bl_power to a known value */
> -	ret = dell_uart_set_bl_power(dell_bl, FB_BLANK_UNBLANK);
> +	ret = dell_uart_set_bl_power(dell_bl, BACKLIGHT_POWER_ON);
>  	if (ret)
>  		return ret;
>  


  reply	other threads:[~2025-06-18 13:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-18 12:16 [PATCH 00/12] backlight: Do not include <linux/fb.h> in header file Thomas Zimmermann
2025-06-18 12:16 ` [PATCH 01/12] platform/x86: dell-uart-backlight: Use blacklight power constant Thomas Zimmermann
2025-06-18 13:01   ` Hans de Goede [this message]
2025-06-24 11:36   ` Ilpo Järvinen
2025-06-18 12:16 ` [PATCH 02/12] drm/panel: panel-samsung-s6e63m0: Include <linux/of.h> Thomas Zimmermann
2025-06-18 12:16 ` [PATCH 03/12] drm/panel: panel-samsung-s6e88a0-ams427ap24: " Thomas Zimmermann
2025-06-18 13:42   ` neil.armstrong
2025-06-18 12:16 ` [PATCH 04/12] drm/panel: panel-summit: " Thomas Zimmermann
2025-06-18 15:19   ` Janne Grunau
2025-06-18 12:16 ` [PATCH 05/12] fbcon: Add necessary include statements and forward declarations Thomas Zimmermann
2025-06-18 12:16 ` [PATCH 06/12] backlight: Include <linux/of.h> Thomas Zimmermann
2025-06-18 12:16 ` [PATCH 07/12] backlight: apple_dwi_bl: Include <linux/mod_devicetable.h> Thomas Zimmermann
2025-06-18 15:08   ` Nick Chan
2025-06-18 12:16 ` [PATCH 08/12] backlight: as3711_bl: Include <linux/of.h> Thomas Zimmermann
2025-06-18 12:16 ` [PATCH 09/12] backlight: da9052_bl: Include <linux/mod_devicetable.h> Thomas Zimmermann
2025-06-18 12:16 ` [PATCH 10/12] backlight: ktd2801: " Thomas Zimmermann
2025-06-18 15:04   ` Nick Chan
2025-06-24 16:41   ` Duje Mihanović
2025-06-18 12:16 ` [PATCH 11/12] backlight: led_bl: Include <linux/of.h> Thomas Zimmermann
2025-06-18 12:16 ` [PATCH 12/12] backlight: Do not include <linux/fb.h> in header file Thomas Zimmermann
2025-06-19  5:12   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f644654-c906-46f0-942e-ad50ba159786@kernel.org \
    --to=hansg@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alyssa@rosenzweig.io \
    --cc=asahi@lists.linux.dev \
    --cc=danielt@kernel.org \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=duje.mihanovic@skole.hr \
    --cc=fnkl.kernel@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=j@jannau.net \
    --cc=jessica.zhang@oss.qualcomm.com \
    --cc=jingoohan1@gmail.com \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neal@gompa.dev \
    --cc=neil.armstrong@linaro.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=support.opensource@diasemi.com \
    --cc=sven@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.