All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vyacheslav Yurkov <uvv.mail@gmail.com>
To: Marek Vasut <marek.vasut@mailbox.org>,
	openembedded-devel@lists.openembedded.org
Cc: Alexander Kanavin <alex@linutronix.de>,
	Ankur Tyagi <ankur.tyagi85@gmail.com>,
	Khem Raj <khem.raj@oss.qualcomm.com>
Subject: Re: [meta-filesystems][PATCH] overlayfs-tools: Inhibit tests on configure
Date: Wed, 21 Oct 2026 17:09:55 +0200	[thread overview]
Message-ID: <6f762fe7-ddf1-49bf-96bb-8e1d75f575c8@gmail.com> (raw)
In-Reply-To: <20261021135357.14928-1-marek.vasut@mailbox.org>

Thanks for the patch Marek.

Could you please explain how you hit the issue? I can't reproduce it.
The sudo is required only for tests, which is a custom meson target. 
It's not supposed to be called during configure.

Slava

On 21.10.2026 15:53, Marek Vasut wrote:
> In case the overlayfs-tools are built using meson, a test triggers
> during meson setup phase during do_configure task. The test invokes
> "sudo", which may not be present on the build machine. Skip the test
> at meson setup phase. Tests should be executed separately on demand
> using "meson test" command instead, and invoking "sudo" and expecting
> it to work during do_configure is unusual.
>
> "
> ERROR: overlayfs-tools-v2025.01-r0 do_configure: meson setup failed
> ...
> | Run-time dependency musl-fts found: NO (tried pkgconfig)
> | Library m found: YES
> | Program test_cases/run_tests.py found: YES (/home/oe/build-some-target/tmp/work/arm64-distro-linux/overlayfs-tools/v2025.01/sources/overlayfs-tools-v2025.01/test_cases/run_tests.py)
> |
> | ../sources/overlayfs-tools-v2025.01/meson.build:94:0: ERROR: Program 'sudo' not found or not executable
> |
> | A full log can be found at /home/oe/build-some-target/tmp/work/arm64-distro-linux/overlayfs-tools/v2025.01/build/meson-logs/meson-log.txt
> |
> | Last 10 lines of meson-log.txt:
> | Code:
> | int main(void) { return 0; }
> "
>
> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
> ---
> Cc: Alexander Kanavin <alex@linutronix.de>
> Cc: Ankur Tyagi <ankur.tyagi85@gmail.com>
> Cc: Khem Raj <khem.raj@oss.qualcomm.com>
> Cc: Vyacheslav Yurkov <uvv.mail@gmail.com>
> ---
>   .../recipes-utils/overlayfs/overlayfs-tools_2025.01.bb        | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_2025.01.bb b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_2025.01.bb
> index 8583a0e2cb..3b5963bb26 100644
> --- a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_2025.01.bb
> +++ b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_2025.01.bb
> @@ -14,3 +14,7 @@ UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)"
>   inherit meson pkgconfig
>   
>   DEPENDS:append:libc-musl = " fts"
> +
> +do_configure:prepend() {
> +	sed -i '/Custom targets for testing overlay function/,/command : .*permanent...changes/ d' ${S}/meson.build
> +}


  reply	other threads:[~2026-10-21 15:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 13:53 [meta-filesystems][PATCH] overlayfs-tools: Inhibit tests on configure Marek Vasut
2026-10-21 15:09 ` Vyacheslav Yurkov [this message]
2026-10-21 16:27   ` Marek Vasut
2026-10-22 12:24     ` Vyacheslav Yurkov
2026-10-22 15:13       ` Marek Vasut
2026-10-23  6:24         ` Vyacheslav Yurkov
2026-10-23  7:05           ` [oe] " Khem Raj
     [not found]             ` <47f17a91-d4bf-4259-8995-531483dd8095@gmail.com>
2026-10-23  7:39               ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f762fe7-ddf1-49bf-96bb-8e1d75f575c8@gmail.com \
    --to=uvv.mail@gmail.com \
    --cc=alex@linutronix.de \
    --cc=ankur.tyagi85@gmail.com \
    --cc=khem.raj@oss.qualcomm.com \
    --cc=marek.vasut@mailbox.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.