Re: Re: Re: [PATCH v3] iio: light: ltr501: Added ltr303 driver support

["Dmitry Maslov" <maslovdmitry@seeed.cc>]

> -----Original Messages-----
> From: "Andy Shevchenko" <andy.shevchenko@gmail.com>
> Sent Time: 2021-11-01 16:20:35 (Monday)
> To: "Dmitry Maslov" <maslovdmitry@seeed.cc>
> Cc: "Jonathan Cameron" <jic23@kernel.org>, linux-iio <linux-iio@vger.kernel.org>, "Lars-Peter Clausen" <lars@metafoo.de>, north_sea@qq.com, baozhu.zuo@seeed.cc, jian.xiong@seeed.cc
> Subject: Re: Re: [PATCH v3] iio: light: ltr501: Added ltr303 driver support
> 
> On Mon, Nov 1, 2021 at 3:57 PM Dmitry Maslov <maslovdmitry@seeed.cc> wrote:
> > > From: "Andy Shevchenko" <andy.shevchenko@gmail.com>
> > > Sent Time: 2021-10-31 22:07:09 (Sunday)
> > > On Sun, Oct 31, 2021 at 6:46 PM Maslov Dmitry <maslovdmitry@seeed.cc> wrote:
> 
> ...
> 
> > > > Signed-off-by: Maslov Dmitry <maslovdmitry@seeed.cc>
> > >
> > > I believe it should be Dmitry Maslov, i.e. First name Last name.
> >
> > I could change that, but I do not think there is an international standard for that. The reason I put Maslov Dmitry
> > is to be in line with corporate email address, which belongs to a Chinese company - in China surname is put first
> > on the legal documents.
> 
> Hmm... You are right, there is no such requirement in the Submitting
> Patches document.
> ...
> 
> > > > @@ -1597,6 +1610,7 @@ static const struct acpi_device_id ltr_acpi_match[] = {
> > > >         {"LTER0501", ltr501},
> > > >         {"LTER0559", ltr559},
> > > >         {"LTER0301", ltr301},
> > > > +       {"LTER0303", ltr303},
> > >
> > > Any evidence of this ACPI ID being in the wild, please?
> >
> > I'm sorry, I do not exactly understand the question. Do you mean where that particular sensor is used?
> 
> Can you provide a name of the machine which has this ID in its DSDT
> table, please?

We're submitting this patch specifically for reTerminal.
Here is DTS file for the reTerminal, currently awaiting merge in Raspberry Pi Linux kernel
repository.
https://github.com/raspberrypi/linux/blob/6ef732875d705ff15cc4c25d4d0a0eee87dc2a58/arch/arm/boot/dts/overlays/seeed-reterminal-core-overlay.dts#L99

So, while at the moment ACPI part is not being used, later we might use this sensor for other, x86 based
boards, for example ODYSSEY - X86J4125800.

Is there a particular reason you think this part should be omitted for LTR303?