From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC1D7C19F2A for ; Thu, 11 Aug 2022 19:17:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230133AbiHKTRx (ORCPT ); Thu, 11 Aug 2022 15:17:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbiHKTRw (ORCPT ); Thu, 11 Aug 2022 15:17:52 -0400 Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1356CA0633 for ; Thu, 11 Aug 2022 12:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1660245470; x=1691781470; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=i1r7yEEXd/vdG8XDDEbrhJMfCp/Lk1s/O+GBF8PJNOw=; b=rcHQadE+qs6HtQKNW76njfo5ARpwBQjG5eUx6YgE9+5NgLNlFbnytnUB lyKIyXg+mBy+rqgisWMZmKJArBFK2pLF+4OwCLJ21CF/u13pllL2N6qaQ QebLCjz2piTvD4jdWhm5Lt+lKaqzDvayEjISOyaJe0YCErLl3XUDlU92y o6zbsWRvuJftkL9oJKLbLZM5d43BWEiGhsYC3pr8ymCuyCqQ+Wj3xn1NO JJcJn97ZmFPiv+WwZaj57pZ+KtEgNJDgomvfyps2NkwBD/M8pv/DdGueH rA0jr/hLviTnfvfjtk2vUMITmRnMTGhFcc/qn3TAkGEfyaplc98ipkKi7 Q==; X-IronPort-AV: E=Sophos;i="5.93,230,1654531200"; d="scan'208";a="209027396" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 12 Aug 2022 03:17:50 +0800 IronPort-SDR: L/cUT1bQNrCS7LgTTCqE42bnvn7adVtwW85Xq2M45AOjHNTqitPDSgVa6RFlqyDtazd1ciqgZ6 5bmSh8+s/g+rScA75gtXl60THJmmz+t+AyV8vcSi2c+3n77YmEaZc+AlwALWrke90EGxII/rDO 21z9RubmYrFrY/EI/qE4Ge8891i+CQINfRP1vK1Dyk47B/Fj9RMcTpHG0ho5jT31gFrovDN/iP SS8olyZdejuapPB6iX+mjKNp15IRzGjdw543eAOH9IetuPf6P7W44mI+7IOifL6xYaYROdexLG rdOqJoVJn7wEwUTI6fsgPII1 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Aug 2022 11:38:43 -0700 IronPort-SDR: TTqq4wV6aoMskEikw50//l/tdoLYd57QYMNbNVjmBGhHqRAxC5Zdg9rOQOPbEetYXaFYxBdvjD fuRB7oOdd/2zC0NxrA/Vd3bdqSdHs0QVQgNd9E+dIDZMCCfBb9K8rDoRVA/SKtXqzNhLeYiJcw UcPEABTXOVse9ZOB2h0glEGusXpW9wkimB2IOSRDYVC7cinKh+hToiDBwrf+pKmpKGlU3iUV9H XGsw2wCgU9hDpPqN9h7Nviexfngf0JicQY7eTJ4zqnkpUf94HUS/KMdPolZewQmvQelm5fJ9M8 AGk= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Aug 2022 12:17:50 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4M3c5V1ncrz1Rw4L for ; Thu, 11 Aug 2022 12:17:50 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1660245469; x=1662837470; bh=i1r7yEEXd/vdG8XDDEbrhJMfCp/Lk1s/O+G BF8PJNOw=; b=ZaVC00tQ+lbMuH3EY6NU+VGCcPKVBj7vM5bXMlkvCYYzdvDvunf QV9pNz9uh88dfAkWRiDQnZBz3rmXrAW+LpwCkcf2lNES93Pcbv5KNn5nPKYQ1831 w5H49ssHiAOIyt9u85HXpmgbypWF916wOTEgfIHNF+atDFaG9R8iFq7rlg/Ue95x YcR+bDpxLBwyNh/4W/OKhP2KIJ2ggwawmA9rvn6jKYuqLPMiwXbusNqnD7u7eQfk mWQJtpWGfElk56WHDUe0v5qaQ4GKUfpx3LDD4T1f75m9yBgxwl1WcGCHJB5VxQKI QcchmW4yv8MDIFZO+/L3A6bwRUay6dIShJg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0RZDfaSXkpb8 for ; Thu, 11 Aug 2022 12:17:49 -0700 (PDT) Received: from [10.11.46.122] (c02drav6md6t.sdcorp.global.sandisk.com [10.11.46.122]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4M3c5T06zVz1RtVk; Thu, 11 Aug 2022 12:17:49 -0700 (PDT) Message-ID: <6f7eb148-0506-a0de-3931-962b68d70fad@opensource.wdc.com> Date: Thu, 11 Aug 2022 12:17:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 0/5] Fix mpt3sas driver sparse warnings Content-Language: en-US To: matoro Cc: Sreekanth Reddy , "Martin K. Petersen" , linux-scsi , Sathya Prakash , Suganath Prabu Subramani , PDL-MPT-FUSIONLINUX References: <20220307234854.148145-1-damien.lemoal@opensource.wdc.com> <13f2f53e87ff7b653c46c3da19ea8115@matoro.tk> <840410bd27c152079ea4cd483d58f416@matoro.tk> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <840410bd27c152079ea4cd483d58f416@matoro.tk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2022/08/11 12:05, matoro wrote: > Just a small update, the module stuff turned out to be a separate, > unrelated regression. I bisected that one also (applying these reverts > each time to allow me to boot) and reported it to Masahiro, who put in a > fix for it here: > https://lore.kernel.org/all/20220809141117.641543-1-masahiroy@kernel.org/ > . So you can ignore that stuff. Are these two commits still planned to > be reverted? Revert should be a last resort (I really want to get rid of all these sparse warnings !). Let me first try to generate a fix for you to test. > > -------- Original Message -------- > Subject: Re: [PATCH v3 0/5] Fix mpt3sas driver sparse warnings > Date: 2022-08-02 19:36 > From: Damien Le Moal > To: matoro , Sreekanth Reddy > > > On 8/3/22 05:27, matoro wrote: >> Hi folks, sorry for the lateness, unfortunately this is in fact broken >> on BE. I use mpt3sas on sparc and my drives fail to come up on 5.19, >> bisected to this patchset. Reverting both of the endian-related >> commits, b4efbec4c2a75b619fae4e8768be379e88c78687 and >> 7ab4d2441b952977556672c2fe3f4c2a698cbb37, allows it to boot. However, >> after booting, I can't load any modules - everything errors with >> "disagrees about version of symbol module_layout". I have completely >> wiped out kernel sources, the module tree, and the kernel image, >> rebuilding both from scratch with ONLY the revert patch applied, but I >> still can't load any modules. Presumably it would work with >> CONFIG_MODVERSIONS=n, but these CRC checks are there for a reason and I >> can't tell if it has something to do with the revert or not. > > For b4efbec4c2a75b619fae4e8768be379e88c78687, removing the cpu_to_le32() > call results in the bytes actually being reversed by writel()/readl() > for > your BE machine. So it looks like the values that need to be written to > the HBA have to be in CPU endian, not le32. Should be easy to fix. > And for 7ab4d2441b952977556672c2fe3f4c2a698cbb37, this looks like the > same > problem. > > I will be traveling and busy this week, but I can have a look at a fix > next Monday. If the Broadcom folks can send a fix faster than that, that > is of course welcome :) > >> >> $ modprobe --dump-modversions >> /lib/modules/5.19.0-gentoo-sparc64/kernel/fs/openpromfs/openpromfs.ko >> | >> grep "module_layout" >> 0xa6c23707 module_layout >> $ grep "module_layout" /usr/src/linux/Module.symvers >> 0xa6c23707 module_layout vmlinux EXPORT_SYMBOL >> >> If you need real hardware access and do not have any on hand, please >> reach out and I can provide temporary access! >> >> Here is the full error on vanilla 5.19: >> >> mpt3sas version 42.100.00.00 loaded >> mpt2sas_cm0: 64 BIT PCI BUS DMA ADDRESSING SUPPORTED, total mem >> (32650280 kB) >> mpt2sas_cm0: _base_wait_for_doorbell_not_used: failed due to timeout >> count(5000), doorbell_reg(18000000)! >> mpt2sas_cm0: CurrentHostPageSize is 0: Setting default host page size >> to >> 4k >> mpt2sas_cm0: MSI-X vectors supported: 1 >> no of cores: 64, max_msix_vectors: -1 >> mpt2sas_cm0: 0 1 1 >> mpt2sas_cm0: pci_alloc_irq_vectors failed (r=-22) !!! >> mpt2sas_cm0: High IOPs queues : disabled >> mpt2sas0: IO-APIC enabled: IRQ 4 >> mpt2sas_cm0: iomem(0x0000084100000000), mapped(0x(____ptrval____)), >> size(16384) >> mpt2sas_cm0: ioport(0x0000085100000000), size(256) >> mpt2sas_cm0: doorbell is in use (line=6869) >> mpt2sas_cm0: _base_get_ioc_facts: handshake failed (r=-14) >> mpt2sas_cm0: failure at >> drivers/scsi/mpt3sas/mpt3sas_scsih.c:12336/_scsih_probe()! >> mpt2sas_cm1: 64 BIT PCI BUS DMA ADDRESSING SUPPORTED, total mem >> (32650280 kB) >> mpt2sas_cm1: _base_wait_for_doorbell_not_used: failed due to timeout >> count(5000), doorbell_reg(18000000)! >> mpt2sas_cm1: CurrentHostPageSize is 0: Setting default host page size >> to >> 4k >> mpt2sas_cm1: MSI-X vectors supported: 1 >> no of cores: 64, max_msix_vectors: -1 >> mpt2sas_cm1: 0 1 1 >> mpt2sas_cm1: pci_alloc_irq_vectors failed (r=-22) !!! >> mpt2sas_cm1: High IOPs queues : disabled >> mpt2sas1: IO-APIC enabled: IRQ 5 >> mpt2sas_cm1: iomem(0x0000084120000000), mapped(0x(____ptrval____)), >> size(16384) >> mpt2sas_cm1: ioport(0x0000085100002000), size(256) >> mpt2sas_cm1: doorbell is in use (line=6869) >> mpt2sas_cm1: _base_get_ioc_facts: handshake failed (r=-14) >> mpt2sas_cm1: failure at >> drivers/scsi/mpt3sas/mpt3sas_scsih.c:12336/_scsih_probe()! >> >> -------- Original Message -------- >> Subject: Re: [PATCH v3 0/5] Fix mpt3sas driver sparse warnings >> Date: 2022-03-09 01:35 >> From: Sreekanth Reddy >> To: "Martin K. Petersen" >> >> On Wed, Mar 9, 2022 at 9:26 AM Martin K. Petersen >> wrote: >>> >>> >>> Sreekanth, >>> >>>> This series fix (remove) all sparse warnings generated when compiling >>>> the mpt3sas driver. All warnings are related to __iomem access and >>>> endianness. >>> >>> Please review this series and validate the patch 5 modification. >> >> Martin, >> This patch set looks good, but before acknowledging this patch set I >> just wanted to do some basic testing on a big endian machine. >> Currently I don't have a big endian machine, internally I am checking >> to get access to big endian machines. Meanwhile if anyone does a basic >> testing on any big endian machine then please let me know. I will add >> the acknowledgement signature. >> >> Thanks, >> Sreekanth >> >>> >>> Thanks! >>> >>> -- >>> Martin K. Petersen Oracle Linux Engineering > -- Damien Le Moal Western Digital Research