RE: [PATCH rtw-next 08/16] wifi: rtw89: add IO offload support via firmware

[Ping-Ke Shih <pkshih@realtek.com>]

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> On 20/04/2026 06:40, Ping-Ke Shih wrote:
> > +static void rtw89_fw_cmd_ofld_udelay(struct rtw89_dev *rtwdev, u32 us)
> > +{
> > +     struct rtw89_fw_cmd_ofld_arg cmd = {
> > +             .src = RTW89_FW_CMD_OFLD_SRC_OTHER,
> > +             .type = RTW89_FW_CMD_OFLD_DELAY,
> > +             .value = us,
> > +     };
> > +     int ret;
> > +
> > +     ret = rtw89_fw_cmd_ofld_enqueue(rtwdev, &cmd);
> > +     if (ret)
> > +             udelay(us);
> > +}
> > +
> > +static void rtw89_fw_cmd_ofld_mdelay(struct rtw89_dev *rtwdev, u32 ms)
> > +{
> > +     struct rtw89_fw_cmd_ofld_arg cmd = {
> > +             .src = RTW89_FW_CMD_OFLD_SRC_OTHER,
> > +             .type = RTW89_FW_CMD_OFLD_DELAY,
> > +             .value = ms * 1000,
> > +     };
> > +     int ret;
> > +
> > +     ret = rtw89_fw_cmd_ofld_enqueue(rtwdev, &cmd);
> > +     if (ret)
> > +             mdelay(ms);
> > +}
> This can fail to compile with some kernel configurations because
> RTW89_FW_CMD_OFLD_SRC_OTHER (4) doesn't fit in the mask
> RTW89_H2C_CMD_OFLD_W0_SRC (GENMASK(0, 1)):

Thanks for the report.

I sent a patch [1] with first github link. If this the link isn't good to you,
please let me know. I can change it.

[1] https://lore.kernel.org/linux-wireless/20260714074811.30124-1-pkshih@realtek.com/T/#u