From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: fio max blocksize References: <15f67a56-7f53-cfca-f4e6-289e1d6c2b14@kernel.dk> <4c57a31e-7955-d0b2-ed27-9d494f090651@kernel.dk> From: Jens Axboe Message-ID: <6fae3201-41af-e59e-1f4b-72e17a39f6c2@kernel.dk> Date: Mon, 23 Jul 2018 09:17:52 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit To: Jeff Furlong , "fio@vger.kernel.org" List-ID: On 7/17/18 3:38 PM, Jeff Furlong wrote: >> I'd just convert those helpers to deal with unsigned long long always, that should work fine for the uint case. > Done. I tested with: > > # fio --name=test --ioengine=libaio --direct=1 --rw=trim --iodepth=1 --bssplit=4g/100 --filename=/dev/nvme1n1 --number_ios=2 > > Here's the final patch unless someone finds an issue. I also updated > it so it applies nicely to the latest on git. Tested with bs, ba, > bsrange, bssplit options that have a >32 bit value. Looks pretty good to me, I applied it with various little fixups in terms of style. Please test current -git and ensure that it works properly for you. Ran some basic testing here, and it still seems good. -- Jens Axboe