From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 276C3C3ABC9 for ; Thu, 15 May 2025 10:04:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=618HshYbodIV5qWiJvlchUNmtxsm6SENYo90P5AmmK8=; b=Dn97uIH1gd1dI5HibYgf18BkU7 85R0a7NEidtrEhLMa/nIGGANFQfgMdFE+BhwCUNgmRI3z5bWZ5GJq4ew1NWqWFSyIsSDCnIdFnEIX VE7wEEAP3aTGqvMbvDsrxAsu9YVbdU4WlspkYbaMXRksmVwvgifa3fvr+644gVGNAoQXPH5XJbH7f a8QVaCrG07YGqnA7/PF70idhJFIi4eGv7L4MgSUswJUN1ONnNAhMmwaBK+GosXjZcxCQJhd09d0lm BilxzWBhd/yWSmsimFd3Q2F933BhSaFWgedTmxozIffuftnXLpXCnF3UbYKlieA3M64b1IhUPL+Oc DI14j7YA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uFVRt-00000000FRJ-3tHk; Thu, 15 May 2025 10:04:21 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uFU5O-000000000ob-2mSf for linux-arm-kernel@lists.infradead.org; Thu, 15 May 2025 08:37:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747298221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=618HshYbodIV5qWiJvlchUNmtxsm6SENYo90P5AmmK8=; b=P2wtIeYdCZGTT80wIsWls++DqtzldcQRQ6i1UC963kE9Vq2PHJ77CYLtl15aY2HRdyYAdY sLcL1CQC4tFbQe7cmb5zqO0MUEuVkLo39lTyRoNzxEiIX2xDe1n8DDpGOlkft2BGGF+gyT wtw82Rvq0aopYmxGdZafVDEQ+Q7fJE8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-455-QD_4pRLYM2q5YQbKgQ-USw-1; Thu, 15 May 2025 04:36:59 -0400 X-MC-Unique: QD_4pRLYM2q5YQbKgQ-USw-1 X-Mimecast-MFC-AGG-ID: QD_4pRLYM2q5YQbKgQ-USw_1747298219 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d4d15058dso5906595e9.0 for ; Thu, 15 May 2025 01:36:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747298219; x=1747903019; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=618HshYbodIV5qWiJvlchUNmtxsm6SENYo90P5AmmK8=; b=SK85+ow2X4RsCfuRa1+K2mfYkXbA2kXCwgMyKbwdDONhRrYFZfNBOKKQBqJRW3GVQ9 Cx0GAgaNIuh3V7WB6klXlJwZftUs6mGTkwfNd5NUWbm5QgMBmWPQlAyUnIKIVKu2KL5u D9Crgpc7wjw3AR6NxyDx2xWUnqjJUi3gdr4trskBuUvpHFUtRuqH8VdLJtVcro8gWI5U 92PnjQSwtmh5wv4bPH76Pj8hzrUi3kC+Ir7yyEHDsyyaBFd9/QifkUatPyhE6tpgRtzl Pt+i0dUQ/C8HwieARi3hfFYBgHJw+T7seak8AJnmhht+VIXuqusRQa33joHmbLsWgIsT jFPQ== X-Forwarded-Encrypted: i=1; AJvYcCVeAuuuJJ0f3evH7Yzp8r13zRu8V0GLY5MIjsBIl5R8E6Vcr3x76KT1ie8eo6zUv1AxlcwkLcx7Irkwk6Noly+4@lists.infradead.org X-Gm-Message-State: AOJu0YyU17113BCKJrfZXEIhuTvpneeTO3aFta7+hWSCUP/453Z4jMLX LHpbEaLYbBDMJlW5ArOMEjC+XOTrMIwv9zP6GpcOYpc3vvlungm0VFmjbeJn31EG0RlCZTKHBwG 3C6qkdgL4wtkExGMizyRXU4cWMYa+aRYgg9eHgZ1SXc8pcRkkXDSekJXkxTEQaP7Sllh4vQx5 X-Gm-Gg: ASbGnct3rQi3nzsHi5IkLPGyNbHvSY52q2XLftCeDKzWSbrtDN4+34RBr0Yryv2d2XX ukGTjmNrAXHcOUfNqgt/SBoiZRpALwgaFC9f+Qqs+xjvMxKcU3vbHpmcu+63F7RdAo1/O5Uwfda qUgcgQcMaQ2AW5R5Mo2Anuxbj0zbErTVsWAaORdUZB0PBiBFcM5p4Jg10W/qpS+QddAo9fNMhIS 5Xlmkm8lzs/85nqPLP985TPC7mRDo2GOqeb1ZWMxf8J7wlCMmzlT49PY/8+n/jACE7EvZEi0N/p k425LOsWwE+Mrar9PkawGxCb6dWk8q7V6rLY7GYCwzd7WWBub3mZO7j3G9lyFIkIKQ2GQpAeDgv qazmOEbNfiEfMxNsRIUo/lUc5xZb9AIZ5NYEosaA= X-Received: by 2002:a05:600c:1986:b0:43d:7588:6688 with SMTP id 5b1f17b1804b1-442f4735b63mr54880355e9.12.1747298218732; Thu, 15 May 2025 01:36:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmaKDEjwq5sTQJSB4Qv+uAiPvjMdnBVhhZCqftFPzP7fxRKG6QQImZy6DegzORYPxqNFoxtg== X-Received: by 2002:a05:600c:1986:b0:43d:7588:6688 with SMTP id 5b1f17b1804b1-442f4735b63mr54879905e9.12.1747298218222; Thu, 15 May 2025 01:36:58 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4a:8900:884a:b3af:e3c9:ec88? (p200300d82f4a8900884ab3afe3c9ec88.dip0.t-ipconnect.de. [2003:d8:2f4a:8900:884a:b3af:e3c9:ec88]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442f4a9bed3sm54122425e9.21.2025.05.15.01.36.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 May 2025 01:36:57 -0700 (PDT) Message-ID: <6fe7848c-485e-4639-b65c-200ed6abe119@redhat.com> Date: Thu, 15 May 2025 10:36:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: Check pxd_leaf() instead of !pxd_table() while tearing down page tables To: Dev Jain , catalin.marinas@arm.com, will@kernel.org Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com, mark.rutland@arm.com, yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org References: <20250515063450.86629-1-dev.jain@arm.com> <332ecda7-14c4-4dc3-aeff-26801b74ca04@redhat.com> <4904d02f-6595-4230-a321-23327596e085@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <4904d02f-6595-4230-a321-23327596e085@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6gEUCvcTQO0yya15SLPKlRwi0OTf-zTp61L8WIrL-m0_1747298219 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250515_013702_803174_E1D45C5E X-CRM114-Status: GOOD ( 18.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15.05.25 10:22, Dev Jain wrote: > > > On 15/05/25 1:43 pm, David Hildenbrand wrote: >> On 15.05.25 08:34, Dev Jain wrote: >>> Commit 9c006972c3fe removes the pxd_present() checks because the caller >>> checks pxd_present(). But, in case of vmap_try_huge_pud(), the caller >>> only >>> checks pud_present(); pud_free_pmd_page() recurses on each pmd through >>> pmd_free_pte_page(), wherein the pmd may be none. >> The commit states: "The core code already has a check for pXd_none()", >> so I assume that assumption was not true in all cases? >> >> Should that one problematic caller then check for pmd_none() instead? > > From what I could gather of Will's commit message, my interpretation is > that the concerned callers are vmap_try_huge_pud and vmap_try_huge_pmd. > These individually check for pxd_present(): > > if (pmd_present(*pmd) && !pmd_free_pte_page(pmd, addr)) > return 0; > > The problem is that vmap_try_huge_pud will also iterate on pte entries. > So if the pud is present, then pud_free_pmd_page -> pmd_free_pte_page > may encounter a none pmd and trigger a WARN. Yeah, pud_free_pmd_page()->pmd_free_pte_page() looks shaky. I assume we should either have an explicit pmd_none() check in pud_free_pmd_page() before calling pmd_free_pte_page(), or one in pmd_free_pte_page(). With your patch, we'd be calling pte_free_kernel() on a NULL pointer, which sounds wrong -- unless I am missing something important. > >> >> If you were able to trigger this WARN, it's always a good idea to >> include the splat in the commit. > > I wasn't able to, it is just an observation from code inspection. That better be included in the patch description :) -- Cheers, David / dhildenb