From: "Ulrich Ölmann" <u.oelmann@pengutronix.de>
To: Yocto Project Documentation <docs@lists.yoctoproject.org>
Cc: yocto@pengutronix.de, "Ulrich Ölmann" <u.oelmann@pengutronix.de>
Subject: Re: [PATCH 1/3] ref-manual: classes: kernel-fitimage: fix variable name
Date: Thu, 13 Jul 2023 19:15:39 +0200 [thread overview]
Message-ID: <6r351rt40o.fsf@pengutronix.de> (raw)
In-Reply-To: <20230712220332.1630850-1-u.oelmann@pengutronix.de>
On Thu, Jul 13 2023 at 00:03 +0200, Ulrich Ölmann <u.oelmann@pengutronix.de> wrote:
> The actual code in kernel-fitimage.bbclass checks if "fitImage" is listed in
> KERNEL_IMAGETYPES (see e.g. [1]) whereas the class does not use KERNEL_IMAGETYPE
> at all.
>
> [1] https://git.yoctoproject.org/poky/tree/meta/classes-recipe/kernel-fitimage.bbclass?h=4.3_M1&id=cc97d775cb402df0d4122bf54eab1a5198c98471#n9
I just stumbled across [2] in kernel.bbclass where KERNEL_IMAGETYPE and
KERNEL_ALT_IMAGETYPE are merged into KERNEL_IMAGETYPES so that my
statement in this patch is not correct. Thus, please do not apply this
series, I am going to send a v2.
Best regards
Ulrich
[2] https://git.yoctoproject.org/poky/tree/meta/classes-recipe/kernel.bbclass?h=4.3_M1&id=cc97d775cb402df0d4122bf54eab1a5198c98471#n74
>
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> ---
> documentation/ref-manual/classes.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/documentation/ref-manual/classes.rst b/documentation/ref-manual/classes.rst
> index e555a80b5af9..c3fa9a86966e 100644
> --- a/documentation/ref-manual/classes.rst
> +++ b/documentation/ref-manual/classes.rst
> @@ -1599,8 +1599,8 @@ an optional :term:`Initramfs` bundle, an optional RAM disk, and any number of
> device trees.
>
> To create a FIT image, it is required that :term:`KERNEL_CLASSES`
> -is set to include ":ref:`ref-classes-kernel-fitimage`" and :term:`KERNEL_IMAGETYPE`
> -is set to "fitImage".
> +is set to include ":ref:`ref-classes-kernel-fitimage`" and :term:`KERNEL_IMAGETYPES`
> +is set to include "fitImage".
>
> The options for the device tree compiler passed to ``mkimage -D``
> when creating the FIT image are specified using the
--
Pengutronix e.K. | Ulrich Ölmann |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-07-14 6:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 22:03 [PATCH 1/3] ref-manual: classes: kernel-fitimage: fix variable name Ulrich Ölmann
2023-07-12 22:03 ` [PATCH 2/3] ref-manual: classes: kernel-fitimage: fix typos Ulrich Ölmann
2023-07-12 22:03 ` [PATCH 3/3] ref-manual: classes: kernel-fitimage: refine role of INITRAMFS_IMAGE_BUNDLE Ulrich Ölmann
2023-07-13 17:15 ` Ulrich Ölmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6r351rt40o.fsf@pengutronix.de \
--to=u.oelmann@pengutronix.de \
--cc=docs@lists.yoctoproject.org \
--cc=yocto@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.