Re: [OE-Core][PATCH v2 1/3] kernel: classes: Extract savedefconfig to a class

["Ulrich Ölmann" <u.oelmann@pengutronix.de>]

On Wed, Oct 12 2022 at 20:43 +0100, "Alex Kiernan" <alex.kiernan@gmail.com> wrote:
> On Wed, Oct 12, 2022 at 5:36 PM Ross Burton <Ross.Burton@arm.com> wrote:
>>
>> On 12 Oct 2022, at 08:18, Alex Kiernan via lists.openembedded.org <alex.kiernan=gmail.com@lists.openembedded.org> wrote:
>> >
>> > Move savedefconfig task to a class so we can reuse it in other recipes
>> > which support it.
>>
>> There are three users of cml1 in oe-core: kernel, uboot, and busybox.  Does busybox support savedefconfig?
>>
>
> It doesn't and fairly obviously goes boom...
>
> ERROR: busybox-1.35.0-r0 do_savedefconfig: oe_runmake failed
> ERROR: busybox-1.35.0-r0 do_savedefconfig:
> ExecutionError('/home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/temp/run.do_savedefconfig.12421',
> 1, None, None)
> ERROR: Logfile of failure stored in:
> /home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/temp/log.do_savedefconfig.12421
> Log data follows:
> | DEBUG: Executing shell function do_savedefconfig
> | Saving defconfig to:
> | /home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/busybox-1.35.0/defconfig
> | NOTE: make CC=x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2
> -msse3 -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2
> --sysroot=/home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/recipe-sysroot
> LD=x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
> -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2
> --sysroot=/home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/recipe-sysroot
> V=1 ARCH=x86_64 CROSS_COMPILE=x86_64-poky-linux- SKIP_STRIP=y
> HOSTCC=gcc  HOSTCPP=gcc  -E -C
> /home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/busybox-1.35.0
> savedefconfig
> | make: Entering directory
> '/home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/busybox-1.35.0'
> | make -f scripts/Makefile.build obj=scripts/basic
> | /home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/busybox-1.35.0/scripts/gen_build_files.sh
> /home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/busybox-1.35.0
> /home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/busybox-1.35.0
> | mkdir -p include
> | make -f scripts/Makefile.build obj=scripts/kconfig savedefconfig
> | make[1]: *** No rule to make target 'savedefconfig'.  Stop.
> | make: *** [Makefile:444: savedefconfig] Error 2
> | make: Leaving directory
> '/home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/busybox-1.35.0'
> | ERROR: oe_runmake failed
>
>> I’m thinking to avoid tiny classes we can just add this to
>> cml1.bbclass and make it print a decent error message if it doesn’t
>> work.
>>
>
> So where I started, was adding it to u-boot.inc (which isn't a class,
> I guess an artefact of history), because tiny classes felt like a poor
> choice. I can add it to cml1 instead, at which point I've tried all
> three options, maybe that's the best option and if you have a consumer
> that doesn't do it, you just get a fail as above.
>
> Are there are other users of cml1 other than these three? My suspicion
> is there isn't (though I've only looked at layers I've got checked
> out).

There is the barebox bootloader which supports 'savedefconfig', whose
recipe in meta-ptx uses cml1 via [2] and which would benefit from this
change.

Best regards
Ulrich


[1] https://barebox.org/
[2] https://github.com/pengutronix/meta-ptx/blob/master/recipes-bsp/barebox/barebox.inc#L12
-- 
Pengutronix e.K.                           | Ulrich Ölmann               |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |