From: "Ulrich Ölmann" <u.oelmann@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] common: deep-probe: write deep probe enabled message to log
Date: Thu, 22 Dec 2022 18:04:20 +0100 [thread overview]
Message-ID: <6rr0wr74id.fsf@pengutronix.de> (raw)
In-Reply-To: <20221222143513.3182725-1-a.fatoum@pengutronix.de>
Hi Ahmad,
On Thu, Dec 22 2022 at 15:35 +0100, Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
> The "Deep probe supported due to" was not written to log and thus only
> shown on startup and not in dmesg output. Make it available in both.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> common/deep-probe.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/common/deep-probe.c b/common/deep-probe.c
> index 1020ad93b7f7..931e5a17709d 100644
> --- a/common/deep-probe.c
> +++ b/common/deep-probe.c
> @@ -1,5 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0-only
>
> +#define pr_fmt(fmt) "deep-probe: " fmt
> +
> #include <common.h>
> #include <deep-probe.h>
> #include <of.h>
> @@ -27,7 +29,7 @@ bool deep_probe_is_supported(void)
> for (; matches->compatible; matches++) {
> if (of_machine_is_compatible(matches->compatible)) {
> boardstate = DEEP_PROBE_SUPPORTED;
> - printk("Deep probe supported due to %s\n", matches->compatible);
> + pr_info("supported due to %s\n", matches->compatible);
was it by accident that you removed the message's beginning "Deep probe "?
Best regards
Ulrich
> return true;
> }
> }
--
Pengutronix e.K. | Ulrich Ölmann |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-12-22 17:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 14:35 [PATCH] common: deep-probe: write deep probe enabled message to log Ahmad Fatoum
2022-12-22 15:47 ` Marco Felsch
2022-12-22 15:53 ` Ahmad Fatoum
2022-12-22 16:05 ` Marco Felsch
2022-12-22 17:04 ` Ulrich Ölmann [this message]
2022-12-22 17:32 ` Ahmad Fatoum
2023-01-04 12:16 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6rr0wr74id.fsf@pengutronix.de \
--to=u.oelmann@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.