All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@osdl.com>, "David S. Miller" <davem@davemloft.net>
Cc: ak@suse.de, Jeff Moyer <jmoyer@redhat.com>,
	netdev@oss.sgi.com, linux-kernel@vger.kernel.org, mingo@elte.hu,
	john.ronciak@intel.com, rostedt@goodmis.org
Subject: [PATCH 6/8] netpoll: pre-fill skb pool
Date: Thu, 11 Aug 2005 21:19:11 -0500	[thread overview]
Message-ID: <7.502409567@selenic.com> (raw)
In-Reply-To: <6.502409567@selenic.com>

we could do one thing (see the patch below): i think it would be useful 
to fill up the netlogging skb queue straight at initialization time.  
Especially if netpoll is used for dumping alone, the system might not be 
in a situation to fill up the queue at the point of crash, so better be 
a bit more prepared and keep the pipeline filled.

	Ingo

Signed-off-by: Ingo Molnar <mingo@elte.hu>

I've modified this to be called earlier - mpm

Signed-off-by: Matt Mackall <mpm@selenic.com>

Index: l/net/core/netpoll.c
===================================================================
--- l.orig/net/core/netpoll.c	2005-08-08 23:00:48.000000000 -0500
+++ l/net/core/netpoll.c	2005-08-11 01:50:31.000000000 -0500
@@ -724,6 +724,10 @@ int netpoll_setup(struct netpoll *np)
 		npinfo->rx_np = np;
 		spin_unlock_irqrestore(&npinfo->rx_lock, flags);
 	}
+
+	/* fill up the skb queue */
+	refill_skbs();
+
 	/* last thing to do is link it to the net device structure */
 	ndev->npinfo = npinfo;
 

  reply	other threads:[~2005-08-12  2:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-12  2:18 [PATCH 0/8] netpoll: various bugfixes Matt Mackall
2005-08-12  2:19 ` [PATCH 1/8] netpoll: rx_flags bugfix Matt Mackall
2005-08-12  2:19   ` [PATCH 2/8] netpoll: deadlock bugfix Matt Mackall
2005-08-12  2:19     ` [PATCH 3/8] netpoll: e1000 netpoll tweak Matt Mackall
2005-08-12  2:19       ` [PATCH 4/8] netpoll: netpoll_send_skb simplify Matt Mackall
2005-08-12  2:19         ` [PATCH 5/8] netpoll: add retry timeout Matt Mackall
2005-08-12  2:19           ` Matt Mackall [this message]
2005-08-12  2:19             ` [PATCH 7/8] netpoll: fix initialization/NAPI race Matt Mackall
2005-08-12  2:19               ` [PATCH 8/8] netpoll: remove unused variable Matt Mackall
2005-08-12 19:02       ` [PATCH 3/8] netpoll: e1000 netpoll tweak John Ronciak
2005-08-12 19:02       ` John Ronciak
2005-08-12 19:10         ` David S. Miller
2005-08-12 19:17         ` Matt Mackall
2005-08-12 19:17         ` Matt Mackall
2005-08-12  2:41 ` [PATCH 0/8] netpoll: various bugfixes David S. Miller
2005-08-12 17:21 ` Olaf Hering
2005-08-12 17:21 ` Olaf Hering
2005-08-12 19:21   ` Matt Mackall
2005-08-12 19:31     ` Olaf Hering
2005-08-14 21:00       ` Matt Mackall
2005-08-15  6:16         ` Olaf Hering
2005-08-12 19:31     ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7.502409567@selenic.com \
    --to=mpm@selenic.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.com \
    --cc=davem@davemloft.net \
    --cc=jmoyer@redhat.com \
    --cc=john.ronciak@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@oss.sgi.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.