From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 06 Jun 2012 14:19:02 +0200 (CEST) Received: from mail-ey0-f177.google.com ([209.85.215.177]:41098 "EHLO mail-ey0-f177.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903702Ab2FFMS4 (ORCPT ); Wed, 6 Jun 2012 14:18:56 +0200 Received: by eaaf11 with SMTP id f11so2596690eaa.36 for ; Wed, 06 Jun 2012 05:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding:content-type; bh=35Jv+ojJ3S6a5u+sSR+3ZGDqBmTQhAXuqvw73DEqe1w=; b=cuez03qQ9bnQlmQlnzyfXqH+rxvTQqMZ3MdQEJHGOuZ0r27lZjKEnao/oM5jHW+4tu NEfMox3rgL5ew2XUi4tJFdFqmU7Y/6x8snM9G3fCYItc3+tsEM9gy0dQGgrc8qMyt+Pt cYU/AeoNUwjro+N3KVves4izyEFH/SWa/6ESEv/vjQWfN8SuS+MG7Vax0S99qhDIBVMq 7U0F9wha4poPQZqmJ3o1jy2MPssZ33T9m/NbdbEZ70ow66xgtA6uCz2yz8AMDtHfZ6rI eGwoWg411HedSKscCOWsiMRKjH+TgL2R3aP34USs+0yowbxUMBQ956hSQenKHd4En8J2 F6mw== Received: by 10.14.119.6 with SMTP id m6mr10666121eeh.165.1338985130768; Wed, 06 Jun 2012 05:18:50 -0700 (PDT) Received: from flexo.localnet ([2a01:e34:ec0d:4090:7dc0:e3ad:a3a1:b40c]) by mx.google.com with ESMTPS id f16sm5848565eec.2.2012.06.06.05.18.48 (version=SSLv3 cipher=OTHER); Wed, 06 Jun 2012 05:18:48 -0700 (PDT) From: Florian Fainelli To: linux-mips@linux-mips.org Cc: "Steven J. Hill" , ralf@linux-mips.org Subject: Re: [PATCH 00/35] Cleanup firmware support across multiple platforms. Date: Wed, 06 Jun 2012 14:16:36 +0200 Message-ID: <7001181.e1a1v1VHCx@flexo> User-Agent: KMail/4.8.3 (Linux/3.2.0-24-generic; KDE/4.8.3; x86_64; ; ) In-Reply-To: <1338931179-9611-1-git-send-email-sjhill@mips.com> References: <1338931179-9611-1-git-send-email-sjhill@mips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-archive-position: 33571 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: florian@openwrt.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Return-Path: Hi Steven, On Tuesday 05 June 2012 16:19:04 Steven J. Hill wrote: > From: "Steven J. Hill" > > The firmware/bootloader support code has been duplicated across a lot > of platforms and continues to self-replicate. These patches move the > support code into the common 'arch/mips/fw/lib' directory. All affected > platforms have been built and produce a linked kernel. Any files that > were modified also had their headers cleaned up and the checkpatch > script ran on them. The rationale for your patches look good to me, as well as the impressive diffstat. You seem to be mixing fixes with cleanups however. Otherwise, for the AR7 and RB532 bits, you have my ack. > > Steven J. Hill (35): > MIPS: Add environment variable processing code to firmware library. > MIPS: Alchemy: Cleanup firmware support for Alchemy platforms. > MIPS: Alchemy: Cleanup files effected by firmware changes. > MIPS: AR7: Cleanup firmware support for the AR7 platform. > MIPS: AR7: Cleanup files effected by firmware changes. > MIPS: ath79: Cleanup firmware support for the ath79 platform. > MIPS: ath79: Cleanup files effected by firmware changes. > MIPS: Cobalt: Cleanup firmware support for the Cobalt platform. > MIPS: Cobalt: Cleanup files effected by firmware changes. > MIPS: Emma: Cleanup firmware support for the Emma platform. > MIPS: Emma: Cleanup files effected by firmware changes. > MIPS: jz4740: Cleanup firmware support for the JZ4740 platform. > MIPS: jz4740: Cleanup files effected by firmware changes. > MIPS: lantiq: Cleanup firmware support for the lantiq platform. > MIPS: lantiq: Cleanup files effected by firmware changes. > MIPS: Lasat: Cleanup firmware support for the Lasat platform. > MIPS: Lasat: Cleanup files effected by firmware changes. > MIPS: Loongson: Cleanup firmware support for the Loongson platform. > MIPS: Loongson: Cleanup files effected by firmware changes. > MIPS: Malta: Cleanup firmware support for the Malta platform. > MIPS: Malta: Cleanup files effected by firmware changes. > MIPS: Netlogic: Cleanup firmware support for the XLR platform. > MIPS: Netlogic: Cleanup files effected by firmware changes. > MIPS: MSP71xx, Yosemite: Cleanup firmware support for PMC platforms. > MIPS: MSP71xx, Yosemite: Cleanup files effected by firmware changes. > MIPS: PNX83xx, PNX8550: Cleanup firmware support for PNX platforms. > MIPS: PNX83xx, PNX8550: Cleanup files effected by firmware changes. > MIPS: PowerTV: Cleanup firmware support for PowerTV platform. > MIPS: PowerTV: Cleanup files effected by firmware changes. > MIPS: RB532: Cleanup firmware support for RB532 platform. > MIPS: RB532: Cleanup files effected by firmware changes. > MIPS: txx9: Cleanup firmware support for txx9 platforms. > MIPS: txx9: Cleanup files effected by firmware changes. > MIPS: vr41xx: Cleanup firmware support for vr41xx platforms. > MIPS: vr41xx: Cleanup files effected by firmware changes. > > arch/mips/alchemy/board-gpr.c | 48 ++--- > arch/mips/alchemy/board-mtx1.c | 48 ++--- > arch/mips/alchemy/board-xxs1500.c | 45 ++--- > arch/mips/alchemy/common/platform.c | 30 +-- > arch/mips/alchemy/common/prom.c | 79 ++------ > arch/mips/alchemy/devboards/db1000.c | 1 - > arch/mips/alchemy/devboards/db1300.c | 1 - > arch/mips/alchemy/devboards/db1550.c | 1 - > arch/mips/alchemy/devboards/pb1100.c | 1 - > arch/mips/alchemy/devboards/pb1500.c | 1 - > arch/mips/alchemy/devboards/prom.c | 54 ++--- > arch/mips/ar7/memory.c | 22 +-- > arch/mips/ar7/platform.c | 63 +++--- > arch/mips/ar7/prom.c | 62 ++---- > arch/mips/ar7/setup.c | 26 +-- > arch/mips/ath79/prom.c | 33 +--- > arch/mips/cobalt/setup.c | 42 ++-- > arch/mips/emma/common/prom.c | 44 +---- > arch/mips/fw/lib/Makefile | 2 + > arch/mips/fw/lib/cmdline.c | 86 ++++++++ > arch/mips/include/asm/fw/fw.h | 47 +++++ > arch/mips/include/asm/mach-ar7/prom.h | 25 --- > arch/mips/include/asm/mach-au1x00/au1xxx_eth.h | 1 + > arch/mips/include/asm/mach-au1x00/prom.h | 12 -- > arch/mips/include/asm/mach-loongson/loongson.h | 54 ++--- > arch/mips/include/asm/mips-boards/generic.h | 30 +-- > arch/mips/include/asm/mips-boards/prom.h | 47 ----- > .../mips/include/asm/pmc-sierra/msp71xx/msp_prom.h | 52 +---- > arch/mips/include/asm/txx9/generic.h | 1 - > arch/mips/jz4740/prom.c | 50 ++--- > arch/mips/lantiq/prom.c | 32 +-- > arch/mips/lasat/prom.c | 24 +-- > arch/mips/loongson/common/Makefile | 2 +- > arch/mips/loongson/common/cmdline.c | 48 ----- > arch/mips/loongson/common/env.c | 40 ++-- > arch/mips/loongson/common/init.c | 16 +- > arch/mips/mti-malta/Makefile | 2 +- > arch/mips/mti-malta/malta-cmdline.c | 59 ------ > arch/mips/mti-malta/malta-display.c | 40 ++-- > arch/mips/mti-malta/malta-init.c | 157 +++------------ > arch/mips/mti-malta/malta-memory.c | 108 ++++------ > arch/mips/mti-malta/malta-setup.c | 59 ++---- > arch/mips/mti-malta/malta-time.c | 65 ++---- > arch/mips/netlogic/xlr/setup.c | 82 ++------ > arch/mips/pmc-sierra/msp71xx/msp_prom.c | 207 +++++--------------- > arch/mips/pmc-sierra/msp71xx/msp_serial.c | 69 +++---- > arch/mips/pmc-sierra/msp71xx/msp_setup.c | 43 ++-- > arch/mips/pmc-sierra/msp71xx/msp_time.c | 75 ++----- > arch/mips/pmc-sierra/msp71xx/msp_usb.c | 45 ++--- > arch/mips/pmc-sierra/yosemite/prom.c | 46 ++--- > arch/mips/pnx833x/common/Makefile | 2 +- > arch/mips/pnx833x/common/prom.c | 64 ------ > arch/mips/pnx833x/common/setup.c | 39 ++-- > arch/mips/pnx833x/stb22x/board.c | 70 +++---- > arch/mips/pnx8550/common/Makefile | 2 +- > arch/mips/pnx8550/common/prom.c | 128 ------------ > arch/mips/pnx8550/common/setup.c | 69 +++---- > arch/mips/pnx8550/jbs/init.c | 45 +---- > arch/mips/pnx8550/stb810/prom_init.c | 36 +--- > arch/mips/powertv/asic/asic_int.c | 45 ++--- > arch/mips/powertv/init.c | 81 ++------ > arch/mips/powertv/memory.c | 39 ++-- > arch/mips/powertv/powertv_setup.c | 29 +-- > arch/mips/rb532/prom.c | 69 +++---- > arch/mips/txx9/generic/setup.c | 85 ++------ > arch/mips/vr41xx/common/init.c | 41 +--- > drivers/mtd/maps/pmcmsp-flash.c | 58 ++---- > drivers/net/ethernet/amd/au1000_eth.c | 1 - > 68 files changed, 890 insertions(+), 2240 deletions(-) > create mode 100644 arch/mips/fw/lib/cmdline.c > create mode 100644 arch/mips/include/asm/fw/fw.h > delete mode 100644 arch/mips/include/asm/mach-ar7/prom.h > delete mode 100644 arch/mips/include/asm/mach-au1x00/prom.h > delete mode 100644 arch/mips/include/asm/mips-boards/prom.h > delete mode 100644 arch/mips/loongson/common/cmdline.c > delete mode 100644 arch/mips/mti-malta/malta-cmdline.c > delete mode 100644 arch/mips/pnx833x/common/prom.c > delete mode 100644 arch/mips/pnx8550/common/prom.c > > -- > 1.7.10.3 > > -- Florian