From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] Date: Fri, 25 Nov 2016 16:50:35 +0000 Message-ID: <7005.1480092635@warthog.procyon.org.uk> References: <31374.1480078855@warthog.procyon.org.uk> <147990561294.7576.6464430479448167484.stgit@warthog.procyon.org.uk> <147990565051.7576.9673287945782426886.stgit@warthog.procyon.org.uk> <1480016487.2444.18.camel@HansenPartnership.com> <15173.1480066220@warthog.procyon.org.uk> <16661.1480075392@warthog.procyon.org.uk> <17565.1480077303@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: In-Reply-To: <31374.1480078855@warthog.procyon.org.uk> Content-ID: <7004.1480092635.1@warthog.procyon.org.uk> Sender: owner-linux-security-module@vger.kernel.org Cc: dhowells@redhat.com, Ard Biesheuvel , James Bottomley , "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-security-module , Lukas Wunner , keyrings@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" List-Id: linux-efi@vger.kernel.org David Howells wrote: > + /* UEFI-2.6 requires DeployedMode to be 1. */ > + if (sys_table_arg->hdr.revision == EFI_2_60_SYSTEM_TABLE_REVISION) { Actually, I suspect that this should be '>='. David From mboxrd@z Thu Jan 1 00:00:00 1970 From: dhowells@redhat.com (David Howells) Date: Fri, 25 Nov 2016 16:50:35 +0000 Subject: [PATCH 5/7] efi: Get the secure boot status [ver #3] In-Reply-To: <31374.1480078855@warthog.procyon.org.uk> References: <31374.1480078855@warthog.procyon.org.uk> <147990561294.7576.6464430479448167484.stgit@warthog.procyon.org.uk> <147990565051.7576.9673287945782426886.stgit@warthog.procyon.org.uk> <1480016487.2444.18.camel@HansenPartnership.com> <15173.1480066220@warthog.procyon.org.uk> <16661.1480075392@warthog.procyon.org.uk> <17565.1480077303@warthog.procyon.org.uk> Message-ID: <7005.1480092635@warthog.procyon.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org David Howells wrote: > + /* UEFI-2.6 requires DeployedMode to be 1. */ > + if (sys_table_arg->hdr.revision == EFI_2_60_SYSTEM_TABLE_REVISION) { Actually, I suspect that this should be '>='. David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933009AbcKYQuv (ORCPT ); Fri, 25 Nov 2016 11:50:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52824 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932680AbcKYQuj (ORCPT ); Fri, 25 Nov 2016 11:50:39 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <31374.1480078855@warthog.procyon.org.uk> References: <31374.1480078855@warthog.procyon.org.uk> <147990561294.7576.6464430479448167484.stgit@warthog.procyon.org.uk> <147990565051.7576.9673287945782426886.stgit@warthog.procyon.org.uk> <1480016487.2444.18.camel@HansenPartnership.com> <15173.1480066220@warthog.procyon.org.uk> <16661.1480075392@warthog.procyon.org.uk> <17565.1480077303@warthog.procyon.org.uk> Cc: dhowells@redhat.com, Ard Biesheuvel , James Bottomley , "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-security-module , Lukas Wunner , keyrings@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 5/7] efi: Get the secure boot status [ver #3] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <7004.1480092635.1@warthog.procyon.org.uk> Date: Fri, 25 Nov 2016 16:50:35 +0000 Message-ID: <7005.1480092635@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 25 Nov 2016 16:50:38 +0000 (UTC) To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Howells wrote: > + /* UEFI-2.6 requires DeployedMode to be 1. */ > + if (sys_table_arg->hdr.revision == EFI_2_60_SYSTEM_TABLE_REVISION) { Actually, I suspect that this should be '>='. David