All of lore.kernel.org
 help / color / mirror / Atom feed
From: github at wilberforce.co.nz <github@wilberforce.co.nz>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] lirc-tools: new package
Date: Tue, 24 Mar 2015 22:39:29 +1300	[thread overview]
Message-ID: <700a74f7$7d4735db$6227ce58$@com> (raw)


>>In this case the package should depend on BR2_LINUX_KERNEL. But are you 
sure 
of this? The text at http://www.lirc.org/html/install.html


What I'm trying to say is that there is no point in selecting tools 
package, untless you have selected the lirc

Kernel package.



Thanks
Rhys

----------------------------------------
From: "Baruch Siach" <baruch@tkos.co.il>
Sent: Tuesday, March 24, 2015 7:17 PM
To: "Rhys Williams" <github@wilberforce.co.nz>
Subject: Re: [Buildroot] [PATCH v3] lirc-tools: new package 

Hi Rhys,

On Tue, Mar 24, 2015 at 02:40:08AM +1300, Rhys Williams wrote:
> This package adds the userspace tools LIRC - Linux remote control.
> The Kernel package will need to be selected.

In this case the package should depend on BR2_LINUX_KERNEL. But are you 
sure 
of this? The text at http://www.lirc.org/html/install.html#compiling says:

	As of 0.9.1+, lirc uses the kernel modules from the official kernel. Some 

	of these are formerly lirc modules which are now part of the kernel. Thus, 

	building lirc does not involve building kernel modules (as it used to 
be).

> Thanks to Baruch for help so far.

This line should not be part of the commit log that is kept forever in the 

Buildroot git history. You may add "personal" comments below the --- 
separator...

> Signed-off-by: Rhys Williams 
> ---

... here.

>  package/Config.in                  |  1 +
>  package/lirc-tools/Config.in       | 15 +++++++++++++++
>  package/lirc-tools/S25lircd        | 38 
++++++++++++++++++++++++++++++++++++++
>  package/lirc-tools/lirc-tools.hash |  2 ++
>  package/lirc-tools/lirc-tools.mk   | 20 ++++++++++++++++++++
>  5 files changed, 76 insertions(+)
>  create mode 100644 package/lirc-tools/Config.in
>  create mode 100755 package/lirc-tools/S25lircd
>  create mode 100644 package/lirc-tools/lirc-tools.hash
>  create mode 100644 package/lirc-tools/lirc-tools.mk

[...]

> diff --git a/package/lirc-tools/lirc-tools.mk 
> b/package/lirc-tools/lirc-tools.mk
> new file mode 100644
> index 0000000..791ed8d
> --- /dev/null
> +++ b/package/lirc-tools/lirc-tools.mk
> @@ -0,0 +1,20 @@
> 
+###########################################################################
#####
> +#
> +# lirc-tools
> +#
> 
+###########################################################################
#####
> +
> +LIRC_TOOLS_VERSION = 0.9.2
> +LIRC_TOOLS_SOURCE = lirc-$(LIRC_TOOLS_VERSION).tar.bz2
> +LIRC_TOOLS_SITE = 
http://downloads.sourceforge.net/project/lirc/LIRC/$(LIRC_TOOLS_VERSION)/

I forgot to mention that earlier, but please add license information here. 
See 
the description of _LICENSE and _LICENSE_FILES in the manual at 
http://nightly.buildroot.org/manual.html#_infrastructure_for_packages_with_s
pecific_build_systems.

> +
> +LIRC_TOOLS_CONF_OPTS = --without-x --enable-sandboxed 
--with-driver=userspace
> +
> +define LIRC_TOOLS_INSTALL_INIT_SYSV
> +	$(INSTALL) -D -m 0755 package/lirc-tools/S25lircd 
$(TARGET_DIR)/etc/init.d/
> +endef
> +
> +$(eval $(autotools-package))
> +#
> +# lcdproc

> +#

Please remove this part.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open 
Systems
=}------------------------------------------------ooO--U--Ooo------------{=


   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

             reply	other threads:[~2015-03-24  9:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24  9:39 github at wilberforce.co.nz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-03-24  9:36 [Buildroot] [PATCH v3] lirc-tools: new package github at wilberforce.co.nz
2015-03-24 11:52 ` Baruch Siach
2015-03-23 13:40 Rhys Williams
2015-03-24  6:16 ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='700a74f7$7d4735db$6227ce58$@com' \
    --to=github@wilberforce.co.nz \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.