From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9F53C46CD4 for ; Tue, 26 Dec 2023 16:40:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lyZb7ne+2ShIvdfOtjtol+/KrT3St9WgXbkOs+TOLUs=; b=kSHvC3HuJzeMYm JkNex2sd8fUXrqdk4iudLinAC+4qEj3o1dVRDvXsCiZfsmZzDJibmncNtXQAW7bdbKIzJ+3PZr2DZ YqGZsr0c4Mg9+E5fz6VX92wr9gfW8uPOJObryj20VqOBVuDHCoUt/EJx0ZN9oPX/YdieN99MHc5gZ IHyhqgfMAHmeybnVD3oAc2vtXcq8ICNHkIgV5xs41HTj1PjoMe/VjRtaR0fcevI0gHuNq94uPRlSH 5IlpUReetfmTA7n4eN/msClDCfZr7fRjgXXLjl4FaYTDMcwJJjX60+LqaSD3J8FfyVvdPuAmHN/jU Tk1YQv+lwkP0UQT3Bsew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rIAT9-00DH9s-13; Tue, 26 Dec 2023 16:39:51 +0000 Received: from mail-ve1eur01on0613.outbound.protection.outlook.com ([2a01:111:f400:fe1f::613] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rIAT6-00DH9U-11 for linux-arm-kernel@lists.infradead.org; Tue, 26 Dec 2023 16:39:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CzWNtNngaHcAkPJnBurXhYlmJW78JmK7T34hDt9zHWjCIXArt9F0fJst11dsnAZiurGuuCBYSIsJM7P2bT3KrePJ7B9LiRlVM4X68ZCrsE0nga6MHpza8Z4/tecjSlWe5PCqL3qVmK/Rl5uKeBebbYm8iedqEBx9qn1LxCU7eJT708aVPXl4ZWY5om/lqj006zDuPfig+5SR1JO6aFyuTwu4JHLZuVs34Y4rcwvaYtq2Jqbh5hna/t+HsGpKw+LdKmFRWyY9fZz1ZnjXBmXyttVAep1jpm79bf+ervYmku1zmILBc3boUK7s8ZkaCWNbO7JMnSku878WyPS2dKGWnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y2StVbqB3YmgMrcRhrTKKsV36SDNdRwtm3r7NjCzhxk=; b=D5rPkEt2OISzlLge9wPNEMKfwITGZluvY/7wmzlN28xjRDCmnGKTrcwH+gCzuPGCYQ1cpBDcjmTgmWylXSqi9SrE0X41AhG+zrK/DwI5NM0uyHc97LVJJk9r6HcoBtmt6vtWF7s5teqwPkg4ehgbUgrWsnumgMwZoeTpb/eXpP60blsv+zJtJKnFW6Kggmh7Y3asW+ucvnQbEYic44NSaghpd6A0UeF9Mmu+xgOOdIFwM/w6Cbqy3LuAjiXek8Yyj2fBr6o9zAFCP93B1ChXac2jZkZMqlITsIcghSFpIH1Y4gFxOFwpJIOioZUJ4TyYebmncWkHP47hpf3AmmmJnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=solid-run.com; dmarc=pass action=none header.from=solid-run.com; dkim=pass header.d=solid-run.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solidrn.onmicrosoft.com; s=selector1-solidrn-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y2StVbqB3YmgMrcRhrTKKsV36SDNdRwtm3r7NjCzhxk=; b=PiAUhpxSYAlpb6VOM2RVBIqtdcbIvJlbBeP/I8Xwyb+fORLmEFv4RGOpRj3WnpSDQzRXBKRe4d0iAx0DvEBOyxwCvdSbq0K0aHpNyo6AJ+ptp+VSR/yIUqRM/NraDMgwcC54OhXlEYbIunPNccwa/VX7ICqoeqPBmDufjODBO+s= Received: from AS8PR04MB8963.eurprd04.prod.outlook.com (2603:10a6:20b:42e::18) by DU0PR04MB9348.eurprd04.prod.outlook.com (2603:10a6:10:358::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.27; Tue, 26 Dec 2023 16:39:36 +0000 Received: from AS8PR04MB8963.eurprd04.prod.outlook.com ([fe80::4db1:aae8:c643:2e73]) by AS8PR04MB8963.eurprd04.prod.outlook.com ([fe80::4db1:aae8:c643:2e73%6]) with mapi id 15.20.7113.027; Tue, 26 Dec 2023 16:39:36 +0000 From: Josua Mayer To: Conor Dooley CC: "linux-arm-kernel@lists.infradead.org" , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH v2 3/8] dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards Thread-Topic: [PATCH v2 3/8] dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards Thread-Index: AQHaNnb4VbvR/2YnzkueHbA1o8KwvLC4gfgAgAAVGgCAAuUNgIAASyqA Date: Tue, 26 Dec 2023 16:39:36 +0000 Message-ID: <701c3157-cfd8-42ec-bdb0-5be58fef4197@solid-run.com> References: <20231224143850.5671-3-josua@solid-run.com> <20231224143850.5671-4-josua@solid-run.com> <20231224-tibia-thursday-bea9dde2fbf1@spud> <655855b6-ff68-4a3c-9ec7-fc72967b702a@solid-run.com> <20231226-dictate-spearman-0fe1ec4bee3b@spud> In-Reply-To: <20231226-dictate-spearman-0fe1ec4bee3b@spud> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=solid-run.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR04MB8963:EE_|DU0PR04MB9348:EE_ x-ms-office365-filtering-correlation-id: 1097faba-5f09-4a20-59e4-08dc06313f14 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mk720ztxtlxOZaLrmDNK2ZFe5o57F94Vfg1yI/EyktrMHvpDa4dkp/I/PKz62kODrTHvQM+rNWL0yEdysZM2dG9xjaBjffsJsR3YWzf1YAr4QIzYb4mOaDfSBpFMljuGaD5r8oo5va8I7qVKG2J8ZsTD1Mjozvg6dBbWsq26l7+jxycaHGmTjzzLj10ABU7QwvbXNXww9gls75D2iZFdY5VelVtUM+unnM2hFollVOS/mlI09GDGeOZm+WT+rGOmDOKg4B6NbJifBfsW5NDyiwO5l5SFr6xrNqZmvddVESjduP0EazyugsRK/4A7NLAFuMKhUP2H3aGWQRNuMVGJsR/PY7U/Gqfl26jeL6pjNS0waMFYXFd8FHc1PZnLWHyawYmWDvxM+IT1Rgy4QcoatgIUslbyNhN83Lb7MbbSjpoQnqrXumUIdm8bNWqDWvi4aTSSgHMZIoJ4U6+XRWNDeA2inpLHqHd2owj2JcW2g7l70qWt8+BJU8IsG/w1rbwqaWUDsTY9IVJ0lH6qAoi3etsiR0Qx+gmJ6+3dOlKn/an1kWGZCn33jOiSQ4jVqkgvlNti/8768P0RHb2pvPc4VXuRUkk+pDX83z5MrYvoFLDN05GMUixlWWiVh4WklfrxpUSPSYL1yWwrnZMUCC+fMg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8963.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39840400004)(136003)(376002)(396003)(346002)(366004)(230922051799003)(186009)(451199024)(1800799012)(64100799003)(38070700009)(91956017)(6916009)(76116006)(64756008)(54906003)(316002)(66946007)(66556008)(66476007)(66446008)(6506007)(8936002)(4326008)(8676002)(6512007)(71200400001)(478600001)(26005)(2616005)(38100700002)(6486002)(41300700001)(5660300002)(2906002)(122000001)(31696002)(86362001)(36756003)(31686004)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eE94SXdlNWtBK0NTaisrVURsbStmdlR1TkV3cVNjV0hrK3NNT1RMcm11anRW?= =?utf-8?B?Y3dVVDJvV2FVT2ZKUXdxeUh5MkttOHI5c29oWnBobzdEL0hLL0dSQjA4akpn?= =?utf-8?B?Y1hTRW03L1VOaHdvWXYweDZpMytuUUJCa3ZLL01SdUt3TkNpQnBHVTY5SFd6?= =?utf-8?B?M25UTXVPUjVteXpzdnZUcVVkaFQvMW1SS3BCemZkZDdwWFQwaENyS2VyYXdK?= =?utf-8?B?WXZKbXhVR2NOQm1TNlllZHJnbGpWL1p2RHVaK0tYNXFQWW0wV2R5V2c0MG1N?= =?utf-8?B?UkU4ei9jaUdPKyt5SzhMeDBjMS9adXF6WXZicTgybWgrS0Z3K1hFTG0zNjN0?= =?utf-8?B?bjAxS1lIVllkL29nU3Z4VkRpeXRXaGc5Qk92V3VINk1LcHp5RjBhL0N3RTVs?= =?utf-8?B?U1V0N2k4V2oxWjZsSnhRcTBuaGErSUJZOWZ2aVduTmh3KzVkVnZJWURDVi9J?= =?utf-8?B?ZitCaWdqb2dLdTZBdVJZUUI5U0JNN3MwLzQ2VzhlcWlnSGdPdFFPNm9zMXhM?= =?utf-8?B?a2Zpc1NyVjlMTmFzOXYwVGkvcVJKZi91M2ZwTVdFamVIeDVUengyZkxJbVBk?= =?utf-8?B?R3prM2t0T3hJTVlqOVpYRHBYMU1VRmI5THkxWnJ0cHByUncwYTlFU0Y2cDdr?= =?utf-8?B?bHJuckU2WEhTS00rTnZMUXFNVjNhem1zSVR4VGtUS2piS0RDcTBqai9FbWpa?= =?utf-8?B?Vm03YkdMVEIxMHhzeGphdWpjSW94Zld0WXNFT2lUSGdQMHVva2gxekY2NnNn?= =?utf-8?B?S0J6VUIwdm5tdkNJRVVzTFZuSTlLV285OVJlYUJ2M1plbEpGWW5xUlNNSE9m?= =?utf-8?B?dGZRMWxZWm1QUjFxeWNRQzZWYmZUY280WHlSRm41dVhFM1FleGJhVVNEcS9S?= =?utf-8?B?azV3Q1p6YVRyRmdTWm9haE95ekxwTk92TGhkYTkrWEZTY1oydHdiSjRWUmNV?= =?utf-8?B?S0ZRWHNReW9YU2dKRFJrZnNDaTZpcGczNkVBQjkvQnYvMmcwRTFyU0xEbThY?= =?utf-8?B?TjE0bjg3ejRIdnJrWG5NelpsRzBCaFhwYmpqL2tldXdreFp5L3l4dVJMVXhC?= =?utf-8?B?NkU3bGdNY3I4MFIwZEsyaGoxUVFLd0kxTVJvQXFDYlBmallhZ1dZVzVlbGY2?= =?utf-8?B?Njg5VkFtK1B5RjBNMTJMaWJhNktjYkd4ZzY3c2Y3U3ZvOHZPR2VmamNnSTFs?= =?utf-8?B?SmxYWk80eG9HNlFIUk5MSFZDQmV5ZjErdmh2b1c5MGdSRFZuNWxLMW5YNmMv?= =?utf-8?B?a2hpaVFMcnBnNlhzdVpCTVlnY0VEVkp6QnhsOW5mNmNlTXFaZmpHTVpXU1NI?= =?utf-8?B?QW9MbXhqUW5pbk1nK001MEJWMGZjRiswT0UzdGorWTQ4NGdpNjdGeHBFbWRD?= =?utf-8?B?c2ZqRy9jNXY1L2ErSmJZaVNtVG5BdlhvbjhBeGxHVDFPbjF3enZhNThNdTBw?= =?utf-8?B?cUZ6a3BicFlaMEdJbWJaMnVrY3FOdlFEdnREUlF5dzdMQVRZNDJUTFROY09q?= =?utf-8?B?RUtoK1lDUEJGMHBnOFVlY3BUTjlQZFVzQ1lyZFRMeWRCZVBPaEdwLzBqS0Nm?= =?utf-8?B?TW9MR2RqY1lYYXBha3RsNW5TdmU5TVVucGdxaFZjTUtaNkoyT3dSL04vcFJ0?= =?utf-8?B?SEVUR2lsSVJpQlB1NHdTaGJRVGhNbmd3aDc5UlpUQVJrbjQyb3JsclZHbE9h?= =?utf-8?B?SmloUzBGVHNkelF1aTBncDVob3hLM21MbXA3NDdiMkNRZEw4cC9wdjFoRVRM?= =?utf-8?B?NVNNT3JONFRtR2p6ZTdRR2diem1kTVZCMVg3SnNTK2RMOHNuemduNmZ3V0FR?= =?utf-8?B?bzNMZC9meThzbVZUa04wVHBGd1dkVG0wdllMMURvRHpwTU9YU3ZldW03TGFF?= =?utf-8?B?TnplS0ZWWk4wNkRyR0RjQVdiMEQvRjJLeVlVRUU3ZjRRT3VZMjFHUVZZR2NZ?= =?utf-8?B?RkNydnErazRZNWlMb1RTY09NeklBWnhxOVI2VXNzTmluRDIvTGRMUGRlMWFn?= =?utf-8?B?b3hqMEgveEdqSTMzSXkyNi8vM0p1b2gyY1VVMG1xRXpNSkhqeHMrOVJ1cjQ4?= =?utf-8?B?N1JBQ1QvUm8rQzJicm1Pb0dUN1dIN0dEck5hL21lNktLUFdRL0x0ZFk5TWQz?= =?utf-8?Q?o4Rs=3D?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: solid-run.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8963.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1097faba-5f09-4a20-59e4-08dc06313f14 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2023 16:39:36.0710 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a4a8aaf3-fd27-4e27-add2-604707ce5b82 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vxD4KJyAjZz8fHV1L5ybOQJDh/aCKNyBuYw7DUHqZjZ2crriwDu/Y7zed5hjxXcl4BCaKe/nN1+pHOE1HrS/1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9348 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_083948_407557_298EB03D X-CRM114-Status: GOOD ( 21.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 26.12.23 um 13:10 schrieb Conor Dooley: > On Sun, Dec 24, 2023 at 03:58:14PM +0000, Josua Mayer wrote: >> Am 24.12.23 um 15:42 schrieb Conor Dooley: >> >> On Sun, Dec 24, 2023 at 03:38:45PM +0100, Josua Mayer wrote: >> >> >> Add DT compatible for SolidRun Armada-388 based Clearfog Base and Pro >> boards. >> >> While they are just two variants, we have 3 device-tree: >> - armada-388-clearfog.dts >> - armada-388-clearfog-base.dts >> - armada-388-clearfog-pro.dts >> >> While the first one is identical to the pro variant, the filename is >> not, and neither are the compatible strings. >> >> The first is compatible to armada-380, 385, 388 and >> solidrun,clearfog-a1. >> The other two are compatible to the same, plus an additional string >> including the pro/base as suffix. >> >> Add two bindings, one for the explicit pro and base variants using a >> total of 5 compatibles, and one for the generic name using just 4. >> >> Signed-off-by: Josua Mayer >> >> >> >> There's nothing here that explains to me _why_ there are three sets of >> compatibles for only two boards. Why is this the case? >> >> I have no idea how we ended up with these 3 combinations: >> clearfog-a1, armada388, ... >> clearfog-base-a1, clearfog-base-a1, armada388, ... >> clearfog-pro-a1, clearfog-base-a1, armada388, ... >> I can only assume it is because these boards are so similar they can boot >> from each others device-tree without large functional impact. > I think Krzysztof has dug more into this, but please just create two > combinations that make sense and have common elements (which they > already do to be fair). It doesn't really matter if some combination > that doesn't make sense is used out of tree. Okay, thanks. I will create another revision and rewrite descriptions to be more clear, especially considering questions raised by Krzysztof. > > Cheers, > Conor. > >> Note we did end up with 3 individual filenames because the Pro was supported first, >> without a suffix - and then both were supported with specific suffix. >> >> >> Also, binding patches need to be sent to the devicetree mailing list. >> get_maintainer.pl should have told you that, no? >> >> I will fix it in v3, or do a resend. >> It did tell me, but I wrongly decided to pick only linux-arm-kernel. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel