From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Ansuel Smith <ansuelsmth@gmail.com>
Subject: Re: [PATCH net-next 2/3] net: dsa: sja1105: fix broken connection with the sja1110 tagger
Date: Mon, 13 Dec 2021 20:34:49 -0800 [thread overview]
Message-ID: <701ea34d-d94c-9ea7-16dc-eb066e71780f@gmail.com> (raw)
In-Reply-To: <20211214014536.2715578-3-vladimir.oltean@nxp.com>
On 12/13/2021 5:45 PM, Vladimir Oltean wrote:
> The driver was incorrectly converted assuming that "sja1105" is the only
> tagger supported by this driver. This results in SJA1110 switches
> failing to probe:
>
> sja1105 spi1.0: Unable to connect to tag protocol "sja1110": -EPROTONOSUPPORT
> sja1105: probe of spi1.2 failed with error -93
>
> Add DSA_TAG_PROTO_SJA1110 to the list of supported taggers by the
> sja1105 driver. The sja1105_tagger_data structure format is common for
> the two tagging protocols.
>
> Fixes: c79e84866d2a ("net: dsa: tag_sja1105: convert to tagger-owned data")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2021-12-14 4:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 1:45 [PATCH net-next 0/3] DSA tagger-owned storage fixups Vladimir Oltean
2021-12-14 1:45 ` [PATCH net-next 1/3] net: dsa: tag_sja1105: fix zeroization of ds->priv on tag proto disconnect Vladimir Oltean
2021-12-14 4:34 ` Florian Fainelli
2021-12-14 1:45 ` [PATCH net-next 2/3] net: dsa: sja1105: fix broken connection with the sja1110 tagger Vladimir Oltean
2021-12-14 4:34 ` Florian Fainelli [this message]
2021-12-14 1:45 ` [PATCH net-next 3/3] net: dsa: make tagging protocols connect to individual switches from a tree Vladimir Oltean
2021-12-14 13:00 ` [PATCH net-next 0/3] DSA tagger-owned storage fixups patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=701ea34d-d94c-9ea7-16dc-eb066e71780f@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.