From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] Fix rte_is_power_of_2 Date: Mon, 19 Jan 2015 10:13:10 +0100 Message-ID: <7022282.sJULtgJP1R@xps13> References: <1419694115-1892-1-git-send-email-rkerur@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: David Marchand Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-01-19 08:21, David Marchand: > On Mon, Jan 19, 2015 at 3:45 AM, Zhang, Helin wrote: > > > It seems that your fix result in cannot launching applications. > > I don't suspect the correction of your fix, but somewhere else needs to be > > corrected together with your fix. > > > > Logs: > > /************************************************************ > > RING: Cannot reserve memory for tailq > > I have a quick fix for this one (rte_malloc_socket refuses 0 alignment), > but looking at the change, I would say there are a lot of places to be > checked. > Were those places checked during review ? http://dpdk.org/browse/dpdk/commit/?id=2fc8d6daa4c7a This case demonstrates that an Acked-by line is not always sufficient to apply a patch. > Kerur, did you run a make test ? > All tests fail for me because of rte_malloc_socket. My dream would be to have a machine receiving patches, applying them in a sandbox, run some basic tests and reports failures. It should be fixed now: http://dpdk.org/browse/dpdk/commit/?id=8e3e06501660 -- Thomas