From: Luca Vizzarro <Luca.Vizzarro@arm.com>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>,
thomas@monjalon.net, Honnappa.Nagarahalli@arm.com,
jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com,
npratte@iol.unh.edu
Cc: dev@dpdk.org
Subject: Re: [PATCH v1 0/4] node and inheritance improvements
Date: Tue, 23 Apr 2024 11:07:16 +0100 [thread overview]
Message-ID: <7031d5c4-af27-435d-9451-50e40cc43356@arm.com> (raw)
In-Reply-To: <20240423091252.62924-1-juraj.linkes@pantheon.tech>
On 23/04/2024 10:12, Juraj Linkeš wrote:
> There are two areas that are unified:
> The super() calls, where the arguments were removed as they're not
> needed in single inheritance.
> The classes derived from object don't need to explicitly state that.
>
> The tg node execution setup and teardown was omitted and is fixed in
> this series.
>
> And probably the most important part if the cleanup of execution and
> build target setup and teardown. Build targets are relevant only for sut
> nodes, so it's been moved there, same for vdevs. The execution
> setup/teardown code was modified so that subclasses use super() to
> extend the base methods.
Hi Juraj,
Thank you for your submission and improvements. It all looks good to me!
Best,
Luca
next prev parent reply other threads:[~2024-04-23 10:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 9:12 [PATCH v1 0/4] node and inheritance improvements Juraj Linkeš
2024-04-23 9:12 ` [PATCH v1 1/4] dts: add tg node execution setup and teardown Juraj Linkeš
2024-04-23 9:18 ` Luca Vizzarro
2024-04-30 16:15 ` Jeremy Spewock
2024-04-23 9:12 ` [PATCH v1 2/4] dts: unify class inheritance from object Juraj Linkeš
2024-04-23 9:19 ` Luca Vizzarro
2024-04-23 14:53 ` Patrick Robb
2024-04-30 16:15 ` Jeremy Spewock
2024-04-23 9:12 ` [PATCH v1 3/4] dts: unify super calls Juraj Linkeš
2024-04-23 10:06 ` Luca Vizzarro
2024-04-23 14:57 ` Patrick Robb
2024-04-30 16:15 ` Jeremy Spewock
2024-04-23 9:12 ` [PATCH v1 4/4] dts: refine pre-test setup and teardown steps Juraj Linkeš
2024-04-23 9:19 ` Luca Vizzarro
2024-04-30 16:15 ` Jeremy Spewock
2024-04-23 10:07 ` Luca Vizzarro [this message]
2024-06-19 13:35 ` [PATCH v2 0/5] node and inheritance improvements Juraj Linkeš
2024-06-19 13:35 ` [PATCH v2 1/5] dts: add tg node test run setup and teardown Juraj Linkeš
2024-06-19 13:35 ` [PATCH v2 2/5] dts: unify class inheritance from object Juraj Linkeš
2024-06-19 13:35 ` [PATCH v2 3/5] dts: unify super calls Juraj Linkeš
2024-06-19 13:35 ` [PATCH v2 4/5] dts: refine pre-test setup and teardown steps Juraj Linkeš
2024-06-19 13:35 ` [PATCH v2 5/5] dts: clean up close in remote session Juraj Linkeš
2024-06-20 2:43 ` [PATCH v2 0/5] node and inheritance improvements Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7031d5c4-af27-435d-9451-50e40cc43356@arm.com \
--to=luca.vizzarro@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=jspewock@iol.unh.edu \
--cc=juraj.linkes@pantheon.tech \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.