From: Cezary Rojewski <cezary.rojewski@intel.com>
To: <phucduc.bui@gmail.com>
Cc: Kees Cook <kees@kernel.org>, Dan Carpenter <error27@gmail.com>,
Cen Zhang <zzzccc427@gmail.com>, Len Bao <len.bao@gmx.us>,
Mehul Rao <mehulrao@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<cassiogabrielcontato@gmail.com>
Subject: Re: [PATCH 0/6] Return -ENODEV instead of -EFAULT on module-get failure
Date: Mon, 6 Jul 2026 11:42:41 +0200 [thread overview]
Message-ID: <703ea25d-6c74-495f-8d0b-e48e5868a96e@intel.com> (raw)
In-Reply-To: <20260706084950.49331-1-phucduc.bui@gmail.com>
On 7/6/2026 10:49 AM, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> Hi all,
>
> Several ALSA open/allocate paths call try_module_get() on the owning card
> module and return -EFAULT when it fails. However, try_module_get() fails
> when the module is no longer live (i.e. it is going away), meaning the
> device is no longer usable.
> This series updates only those paths, making the error code consistent
> with the existing "device unavailable" checks in the same functions.
> Other -EFAULT returns are left unchanged.
> No functional change is intended.
Changing a return code _is_ a functional change, so the last statement
is bogus.
Now, there is a benefit of having a different error code in
try_module_get() case: easier to find the offending bit when viewing
logs. All the functions in the area have rather low log-coverage so
distinct error codes help.
Regardless, as you mentioned, -EFAULT isn't exactly the right return
code either so the direction of the patchset is good.
next prev parent reply other threads:[~2026-07-06 9:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 8:49 [PATCH 0/6] Return -ENODEV instead of -EFAULT on module-get failure phucduc.bui
2026-07-06 8:49 ` [PATCH 1/6] ALSA: control: Return -ENODEV instead of -EFAULT in snd_ctl_open() phucduc.bui
2026-07-06 9:35 ` Cezary Rojewski
2026-07-06 9:40 ` Bui Duc Phuc
2026-07-07 8:26 ` Bui Duc Phuc
2026-07-09 14:41 ` Dan Carpenter
2026-07-10 2:51 ` Bui Duc Phuc
2026-07-06 8:49 ` [PATCH 2/6] ALSA: hwdep: Return -ENODEV instead of -EFAULT in snd_hwdep_open() phucduc.bui
2026-07-06 8:49 ` [PATCH 3/6] ALSA: info: Return -ENODEV instead of -EFAULT in alloc_info_private() phucduc.bui
2026-07-06 8:49 ` [PATCH 4/6] ALSA: mixer: oss: Return -ENODEV instead of -EFAULT in snd_mixer_oss_open() phucduc.bui
2026-07-06 8:49 ` [PATCH 5/6] ALSA: pcm: oss: Return -ENODEV instead of -EFAULT in snd_pcm_oss_open() phucduc.bui
2026-07-06 8:49 ` [PATCH 6/6] ALSA: pcm: Return -ENODEV instead of -EFAULT in snd_pcm_open() phucduc.bui
2026-07-06 9:42 ` Cezary Rojewski [this message]
2026-07-06 12:31 ` [PATCH 0/6] Return -ENODEV instead of -EFAULT on module-get failure Bui Duc Phuc
2026-07-06 13:13 ` Cezary Rojewski
2026-07-06 13:26 ` Takashi Iwai
2026-07-07 8:06 ` Bui Duc Phuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=703ea25d-6c74-495f-8d0b-e48e5868a96e@intel.com \
--to=cezary.rojewski@intel.com \
--cc=bigeasy@linutronix.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=error27@gmail.com \
--cc=kees@kernel.org \
--cc=len.bao@gmx.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mehulrao@gmail.com \
--cc=perex@perex.cz \
--cc=phucduc.bui@gmail.com \
--cc=tiwai@suse.com \
--cc=zzzccc427@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.