From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v2] arm64: dts: rockchip: Add support for Khadas Edge/Edge-V/Captain boards Date: Fri, 21 Jun 2019 15:08:08 +0200 Message-ID: <7040262.Yu9PGCMTeE@phil> References: <1558696796-10745-1-git-send-email-xieqinick@gmail.com> <5485782.mvTjYBxPra@phil> <54387ddeae322fba@bloch.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <54387ddeae322fba@bloch.sibelius.xs4all.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" To: Mark Kettenis Cc: linux-rockchip@lists.infradead.org, maxime.ripard@bootlin.com, u-boot@lists.denx.de, nick@khadas.com, linux-amarula@amarulasolutions.com, xieqinick@gmail.com List-Id: linux-rockchip.vger.kernel.org QW0gRnJlaXRhZywgMjEuIEp1bmkgMjAxOSwgMTQ6NTI6MTcgQ0VTVCBzY2hyaWViIE1hcmsgS2V0 dGVuaXM6Cj4gPiBGcm9tOiBIZWlrbyBTdHVlYm5lciA8aGVpa29Ac250ZWNoLmRlPgo+ID4gRGF0 ZTogRnJpLCAyMSBKdW4gMjAxOSAxMzozNDoxNiArMDIwMAo+ID4gCj4gPiBIaSwKPiA+IAo+ID4g QW0gRG9ubmVyc3RhZywgMjAuIEp1bmkgMjAxOSwgMDU6MjQ6MzIgQ0VTVCBzY2hyaWViIEtldmVy IFlhbmc6Cj4gPiA+IE9uIDA2LzIwLzIwMTkgMTI6NTQgQU0sIFBhdWwgS29jaWFsa293c2tpIHdy b3RlOgo+ID4gPiA+IExlIG1lcmNyZWRpIDE5IGp1aW4gMjAxOSDDoCAwOTo0MiArMDgwMCwgS2V2 ZXIgWWFuZyBhIMOpY3JpdCA6Cj4gPiA+ID4+IE9uIDA2LzE5LzIwMTkgMTI6MTIgQU0sIE1hcmsg S2V0dGVuaXMgd3JvdGU6Cj4gPiA+ID4+Pj4gRnJvbTogUGF1bCBLb2NpYWxrb3dza2kgPHBhdWwu a29jaWFsa293c2tpQGJvb3RsaW4uY29tPgo+ID4gPiA+Pj4+IERhdGU6IFR1ZSwgMTggSnVuIDIw MTkgMTQ6NDc6MzMgKzAyMDAKPiA+ID4gPj4+PiBPbiBUdWUsIDIwMTktMDYtMTggYXQgMTg6MDgg KzA4MDAsIEtldmVyIFlhbmcgd3JvdGU6Cj4gPiA+ID4+Pj4+IE9uIDA2LzE4LzIwMTkgMDU6MDMg UE0sIFBhdWwgS29jaWFsa293c2tpIHdyb3RlOgo+ID4gPiA+Pj4+Pj4gT24gVHVlLCAyMDE5LTA2 LTE4IGF0IDE0OjI3ICswNTMwLCBKYWdhbiBUZWtpIHdyb3RlOgo+ID4gPiA+Pj4+Pj4+IE9uIFR1 ZSwgSnVuIDE4LCAyMDE5IGF0IDE6NTUgUE0gUGF1bCBLb2NpYWxrb3dza2kKPiA+ID4gPj4+Pj4+ PiA8cGF1bC5rb2NpYWxrb3dza2lAYm9vdGxpbi5jb20+IHdyb3RlOgo+ID4gPiA+Pj4+Pj4+PiBP biBNb24sIDIwMTktMDYtMTcgYXQgMTU6MjQgKzA4MDAsIHhpZXFpbmlja0BnbWFpbC5jb20gd3Jv dGU6Cj4gPiA+ID4+Pj4+Pj4+PiBGcm9tOiBOaWNrIFhpZSA8bmlja0BraGFkYXMuY29tPgo+ID4g PiA+Pj4+Pj4+PiBXYXMgdGhpcyB0ZXN0ZWQgd2l0aCBTUEwgc3VwcG9ydD8gSSBkb24ndCBzZWUg RFJBTSBjb25maWd1cmF0aW9uIGhlcmUKPiA+ID4gPj4+Pj4+Pj4gc28gaXQgc2VlbXMgdGhhdCBp dCByZWxpZXMgb24gdGhlIG5vbi1mcmVlIHJvY2tjaGlwIGxvYWRlci4KPiA+ID4gPj4+Pj4+Pj4K PiA+ID4gPj4+Pj4+Pj4gSWYgdGhhdCBpcyB0aGUgY2FzZSwgY291bGQgeW91IHBsZWFzZSBpbmRp Y2F0ZSB0aGF0IGluIHRoZSBjb21taXQKPiA+ID4gPj4+Pj4+Pj4gbWVzc2FnZT8KPiA+ID4gPj4+ Pj4+Pj4KPiA+ID4gPj4+Pj4+Pj4gVG8gbWFpbnRhaW5lcnM6IHBsZWFzZSBkbyBub3QgbWVyZ2Ug dGhpcyBzZXJpZXMgYmVmb3JlIERSQU0gaW5pdCBhbmQKPiA+ID4gPj4+Pj4+Pj4gU1BMIHN1cHBv cnQgaXMgYXZhaWxhYmxlIGZvciB0aGVzZSBib2FyZHMuCj4gPiA+ID4+Pj4+Pj4+Cj4gPiA+ID4+ Pj4+Pj4+IEl0IHNlZW1zIHRoYXQgb3RoZXIgUkszMzk5IGJvYXJkcyB3ZXJlIG1lcmdlZCB3aXRo b3V0IFNQTCBzdXBwb3J0IGFuZAo+ID4gPiA+Pj4+Pj4+PiBzb2ZhciwgSSBoYXZlIHRoZSBmZWVs aW5nIHRoYXQgbm9ib2R5IGNhcmVkIHRvIGV4cGxhaW4gaG93IHdlIGdvdCBpbnRvCj4gPiA+ID4+ Pj4+Pj4+IHRoaXMgYnJva2VuIHNpdHVhdGlvbi4gUGxlYXNlIGRvbid0IG1lcmdlIGFueSBtb3Jl IHN1Y2ggYm9hcmQuCj4gPiA+ID4+Pj4+Pj4gZnlpOiBubyByazMzOTkgYm9hcmRzIHdlcmUgbWVy Z2VkIHcvbyBTUEwuIGxwZGRyNCBib2FyZHMgd2VyZSBtZXJnZWQKPiA+ID4gPj4+Pj4+PiB3aXRo IFRQTC1lbmFibGVkICh3aGljaCB3YXMgZGlzY3Vzc2VkIG9uIHRoZSB0aHJlYWRzLCBpZiB5b3Ug cmVtZW1iZXIpCj4gPiA+ID4+Pj4+Pj4gd2l0aCBiZWxvdyBib290IGNoYWluLgo+ID4gPiA+Pj4+ Pj4+Cj4gPiA+ID4+Pj4+Pj4gcmtiaW4gKFRQTCkgLT4gU1BMIC0+IFUtQm9vdCBwcm9wZXIKPiA+ ID4gPj4+Pj4+Pgo+ID4gPiA+Pj4+Pj4+IFNhbWUgY2FzZSBmb3IgdGhpcyBib2FyZCBhcyB3ZWxs Lgo+ID4gPiA+Pj4+Pj4gSGVyZSBpcyBhIHF1b3RlIGZyb20gUGhpbGlwcCBUb21zaWNoIG9uIHRo ZSB0aHJlYWQgd2UgZGlzY3Vzc2VkIHRoaXM6Cj4gPiA+ID4+Pj4+Pgo+ID4gPiA+Pj4+Pj4gIiBP biBzb21lIGJvYXJkcywgdGhlcmUgd2lsbCBiZSBubyBUUEwgYW5kIG9ubHkgYSBTUEwgc3RhZ2Ug dGhhdCB3aWxsCj4gPiA+ID4+Pj4+PiBpbml0aWFsaXNlIERSQU0gKGFzIHRoZSBtb3ZlIHRvIGhh dmluZyBUUEwgb24gdGhlIFJLMzM5OSBpcyBvcHRpb25hbCkuCj4gPiA+ID4+Pj4+Pgo+ID4gPiA+ Pj4+Pj4gSSBhZ3JlZSB3aXRoIFBhdWwgdGhhdCB0aGUgRFJBTSBpbml0IHNob3VsZCBiZSBwYXJ0 IG9mIFUtQm9vdCB3aGVuZXZlcgo+ID4gPiA+Pj4+Pj4gd2UgYWRkIG5ldyBib2FyZHMgYW5kIG1h a2UgYW4gb3BlbiBEUkFNIGluaXQgYSBwcmVyZXF1aXNpdGUuICIKPiA+ID4gPj4+Pj4+Cj4gPiA+ ID4+Pj4+PiBTbyBldmVuIGlmIEkgZnJlcXVlbnRseSBjb25mdXNlIFNQTCBhbmQgVFBMLCBpdCBk b2Vzbid0IGNoYW5nZSB0aGUgZmFjdAo+ID4gPiA+Pj4+Pj4gdGhhdCBubyBib2FyZCBzaG91bGQg YmUgbWVyZ2VkIHdpdGhvdXQgcHJvcGVyIERSQU0gaW5pdC4KPiA+ID4gPj4+Pj4+Cj4gPiA+ID4+ Pj4+PiBQbGVhc2Ugc3RvcCBwdXNoaW5nIGZvciBtZXJnaW5nIHRoZXNlIGJvYXJkcy4gSSdtIG5v dCBzdXJlIHdoYXQgd2UKPiA+ID4gPj4+Pj4+IHNob3VsZCBkbyBhYm91dCB0aGUgYm9hcmRzIHRo YXQgd2VyZSBtZXJnZWQgYWxyZWFkeSB3aXRob3V0IERSQU0gaW5pdCwKPiA+ID4gPj4+Pj4+IGJ1 dCBtYXliZSB0aGV5IHNob3VsZCBiZSByZXZlcnRlZC4KPiA+IAo+ID4gPiA+Pj4+PiBJIGRvbid0 IHRoaW5rIHdlIGhhdmUgdG8gaGF2ZSBmdWxsIERSQU0gaW5pdCBzb3VyY2UgY29kZSBmb3IgZWFj aAo+ID4gPiA+Pj4+PiBib2FyZCBiZWZvcmUgd2UgY2FuIG1lcmdlIGl0LCBJIGJlbGlldmUgbW9z dCBvZiB0aGUgYm9hcmQgb24gVS1Cb290Cj4gPiA+ID4+Pj4+IG1haW5saW5lIG5lZWQgdG8gcmVt b3ZlZCBkdWUgdG8gdGhpcyBydWxlLiBUaGVyZSBhcmUgc28gbWFueSBib2FyZHMKPiA+ID4gPj4+ Pj4gZnJvbSBkaWZmZXJlbnQgdmVuZG9yIG5lZWQgYSBiaW5hcnkgbG9hZGVyIGJlZm9yZSBVLUJv b3QsIGFuZCBJIGNhbgo+ID4gPiA+Pj4+PiBzZWUgb25seSB2ZXJ5IGZldyBkcml2ZXJzIGZvciBk cmFtIGF0IGRyaXZlci9yYW0vLCBhbmQgSSBiZWxpZXZlIHJvY2tjaGlwCj4gPiA+ID4+Pj4+IGlz IGFscmVhZHkgdGhlIG1vc3Qgb3BlbiB2ZW5kb3Igb24gdGhpcyBhcmVhLgo+ID4gCj4gPiA+ID4+ Pj4gV2VsbCwgSSBhbSBub3QgdGFsa2luZyBhYm91dCBmdWxsIERSQU0gaW5pdCBzb3VyY2UgY29k ZSBhcyBpbiBkeW5hbWljCj4gPiA+ID4+Pj4gbGluayB0cmFpbmluZy4gSSBhbSB0YWxraW5nIGFi b3V0IGhhdmluZyBhdCBsZWFzdCBzdGF0aWMgRFJBTSByZWdpc3Rlcgo+ID4gPiA+Pj4+IGNvbmZp Z3VyYXRpb24gdmFsdWVzLCAKPiA+IAo+ID4gPiA+PiBJIGNhbiB0ZWxsIHlvdSB0aGF0IHRoaXMg aXMgbm8gd29yayBmb3IgYWxsIHRoZSBib2FyZHMsIHlvdSBjYW4gc2VlIGhvdwo+ID4gPiA+PiBy b2NrY2hpcCBscGRkcjQoV0lQLCBzZW5kIGJ5IEphZ2FuKSBkcml2ZXIgd29ya3MuCj4gPiAKPiA+ ID4gPiBJIHRob3VnaHQgdGhhdCBMUEREUjQgd29ya3MgdGhlIHNhbWUgYXMgb3RoZXIgdHlwZXMg b2YgRFJBTSB3aGVyZSB3ZQo+ID4gPiA+IGhhdmUgYSBkdHNpIGFycmF5IHdpdGggdGltaW5ncyBj b25maWd1cmF0aW9uLiBPZiBjb3Vyc2UsIHNvbWUgbW9yZQo+ID4gPiA+IHJlZ2lzdGVycyBuZWVk IHRvIGJlIHNldCB1cCwgYnV0IHdlIGFscmVhZHkgaGF2ZSBzdXBwb3J0IGZvciB0aGF0IG9yCj4g PiA+ID4gaXQncyBxdWl0ZSBjbG9zZSAoZm9yIExQRERSNCkuCj4gPiA+Cj4gPiA+ID4+Pj4gd2hp Y2ggaXMgcHJlc2VudCBmb3IgYSBnb29kIG51bWJlciBvZiByb2NrY2hpcAo+ID4gPiA+Pj4+IGJv YXJkcy4KPiA+ID4gPj4gTm8sIHRoZXJlIGlzIG5vIHJvY2tjaGlwIGJvYXJkIG9ubHkgaGF2ZSBz dGF0aWMgRFJBTSByZWdpc3Rlcgo+ID4gPiA+PiBjb25maWd1cmF0aW9uIHZhbHVlcywgdGhhdCBt YXliZSBoYXBwZW5zIGluIG90aGVyIHZlbmRvci4KPiA+ID4KPiA+ID4gPiBJIHdhcyBpbXBseWlu ZyB0aGF0LCBhcyBmYXIgYXMgSSBrbm93LCBpdCBpcyB0aGUgY2FzZSBmb3IgRFJBTSB0aW1pbmdz Cj4gPiA+ID4gb24gUm9ja2NoaXAgYXMgd2VsbCBhcyBtb3N0IG9mIHRoZSBwbGF0Zm9ybXMgdGhh dCBJIGtub3cgb2YuIEluIHRoZQo+ID4gPiA+IGVuZCwgYW55IGNvZGUgaGFuZGxpbmcgRFJBTSB3 aWxsIGVuZCB1cCB3cml0aW5nIHRpbWluZ3MgdG8gdGhlCj4gPiA+ID4gY29udHJvbGxlcidzIHJl Z2lzdGVycy4gSWYgdGhlIERSQU0gaXMgcGFydCBvZiB0aGUgUENCIGFuZCBkb2Vzbid0Cj4gPiA+ ID4gY2hhbmdlL21vdmUsIHRoZW4gdGhlIHRpbWluZ3MgZG9uJ3QgY2hhbmdlIGluIHBhcnRpY3Vs YXIuCj4gPiA+ID4KPiA+ID4gPiBJcyB0aGVyZSBzb21ldGhpbmcgc3BlY2lmaWMgYWJvdXQgUm9j a2NoaXAgdGhhdCBtYWtlcyBpdCByZXF1aXJlCj4gPiA+ID4gZGlmZmVyZW50IERSQU0gdGltaW5n cyBhdCBlYWNoIGJvb3Q/Cj4gPiA+Cj4gPiA+ID4+Pj4gT2YgY291cnNlLCBpdCB3b3VsZCBiZSBi ZXN0IGlmIFJvY2tjaGlwIHdvdWxkIGNvbnNpZGVyIHJlbGVhc2luZyB0aGlzCj4gPiA+ID4+Pj4g c291cmNlIGNvZGUsIAo+ID4gPiA+PiBSb2NrY2hpcCBhbHJlYWR5IHJlbGVhc2UgYWxsIHRoZSBE UkFNIGluaXQgc291cmNlIGNvZGUsIGluY2x1ZGluZyBERFIzICwKPiA+ID4gPj4gTFBERFIzLAo+ ID4gPiA+PiBhbmQgTFBERFI0KHdpcCkuIFlvdSBjYW4gc2VlIHRoZSBkcml2ZXIgYXQgZHJpdmVy L3JhbS9yb2NrY2hpcC8gZm9yCj4gPiA+ID4+IGV2ZXJ5dGhpbmcsCj4gPiA+ID4+IHdoaWNoIGlz IG5vdCBvbmx5IHN0YXRpYyByZWdpc3RlciBjb25maWd1cmF0aW9uLgo+ID4gPiA+PiBBcyBJIGhh dmUgc2FpZCwgcm9ja2NoaXAgaXMgYWxyZWFkeSB0aGUgbW9zdCBvcGVuIHZlbmRvciBpbiB0aGlz IGFyZWEKPiA+ID4gPj4gdGlsbCBub3csIEkgZG9uJ3Qga25vdwo+ID4gPiA+PiBpZiB5b3UgaGF2 ZSB3b3JraW5nIG9uIHJvY2tjaGlwIFNvQyBiYXNlZCBib2FyZHMuCj4gPiA+ID4gWW91IGFyZSBx dWl0ZSByaWdodCBhYm91dCB0aGF0LCBidXQgSSB3YXMgdGhpbmtpbmcgYWJvdXQgdGhlIGNvZGUg dG8KPiA+ID4gPiBjYWxjdWxhdGUgRFJBTSB0aW1pbmdzICh3aXRoIGxpbmstdHJhaW5pbmcgYW5k IHN1Y2gpIHdoaWNoIGlzIG9mdGVuIG5vdAo+ID4gPiA+IGF2YWlsYWJsZSBhcyBmcmVlIHNvZnR3 YXJlLCBhbmQgSSBhbSBub3QgYXdhcmUgb2YgUm9ja2NoaXAgaGF2aW5nCj4gPiA+ID4gcmVsZWFz ZWQgdGhhdCBjb2RlIChidXQgZmVlbCBmcmVlIHRvIGNvcnJlY3QgbWUgaWYgSSdtIHdyb25nKS4K PiA+ID4gPgo+ID4gPiA+Pj4+IHdoaWNoIHdvdWxkIGJlIHRoZSBlYXNpZXN0IGFuZCBmcmllbmRs aWVzdCBzb2x1dGlvbgo+ID4gPiA+Pj4+IHRvd2FyZHMgdGhlIGNvbW11bml0eSBoZXJlLiBBcmUg dGhlcmUgaW50ZXJuYWwgZGlzY3Vzc2lvbnMgb25nb2luZwo+ID4gPiA+Pj4+IGFib3V0IHRoaXM/ IElmIG5vdCwgaXQgd291bGQgYmUgZ3JlYXRseSBhcHByZWNpYXRlZCB0byBzdGFydCBzdWNoCj4g PiA+ID4+Pj4gZGlzY3Vzc2lvbnMgYW5kIGNsZWFybHkgaWRlbnRpZnkgd2hhdCB0aGUgYmxvY2tp bmcgcG9pbnRzIGFyZS4KPiA+ID4gPj4+Pgo+ID4gPiA+Pj4+PiBJIHdvbid0IHVzZSB0aGlzIHJ1 bGUgdG8gc3RvcCBkZXZlbG9wZXJzIGNvbnRyaWJ1dGUgdGhlcmUgc291cmNlIGNvZGUsCj4gPiA+ ID4+Pj4gVGhpcyBpcyByZWFsbHkgc2FkIGFuZCBJIHRoaW5rIHRoYXQgUGhpbGlwcCB3YXMsIGxp a2UgbWUsIGluY2xpbmVkIHRvCj4gPiA+ID4+Pj4gZ28gdG93YXJkcyB0aGUgb3RoZXIgZGlyZWN0 aW9uLgo+ID4gPiA+Pj4+Cj4gPiA+ID4+Pj4+IGZvciBhIGJvYXJkIHN1cHBvcnQsIHdlIG9ubHkg bmVlZCB0aGUgYm9hcmQgdG8gaGF2ZSB0aGUgZnVsbCBkb2N1bWVudGF0aW9uCj4gPiA+ID4+Pj4+ IGFib3V0IGhvdyB0byBzZXR1cCBhbmQgYm9vdCB3aXRoIHVwc3RyZWFtIFUtQm9vdC4gYW5kIEkg dGhpbmsgdGhlCj4gPiA+ID4+Pj4+IG1vc3Qgb2YgcGVvcGxlIGNhcmVzIG1vcmUgYWJvdXQgZmVh dHVyZXMgaW4gVS1Cb290IHByb3Blci4gRXZlcnl0aGluZwo+ID4gPiA+Pj4+PiBiZWZvcmUgVS1C b290IHByb3BlciwgeW91IGNhbiB1c2UgVFBML1NQTCBvciBhbHRlcm5hdGl2ZSB0byB1c2UgYmlu YXJ5Cj4gPiA+ID4+Pj4+IGZyb20gdmVuZG9yLCBhcyB5b3UgY2FuIHNlZSBhbGwgb3ZlciB0aGUg VS1Cb290IG1haW5saW5lIG5vdywgYWx0aG91Z2gKPiA+ID4gPj4+Pj4gd2UgZW5jb3VyYWdlIHBl b3BsZSB0byB1c2UgZnVsbCBvcGVuIHNvdXJjZSBUUEwvU1BMLgo+ID4gPiA+Pj4+PiBTcGVjaWZp Y2FsbHkgZm9yIFUtQm9vdCBSb2NrY2hpcCBwbGF0Zm9ybSwgSSB3b3VsZCBsaWtlIHBlb3BsZSB0 bwo+ID4gPiA+Pj4+PiBzdXBwb3J0IG5vdCBvbmx5IFUtQm9vdAo+ID4gPiA+Pj4+PiBwcm9wZXIs IGJ1dCBhbHNvIGZvciBmdWxsIFNQTChBVEYsIE9QLVRFRSBzdXBwb3J0LCBpdGIgaW1hZ2UgYW5k IG90aGVyCj4gPiA+ID4+Pj4+IGZlYXR1cmVzKQo+ID4gPiA+Pj4+PiBzdXBwb3J0LiBBbmQgZm9y IERSQU0gaW5pdCwKPiA+ID4gPj4+Pj4gLSBpZiB0aGlzIGJlbG9uZ3MgdG8gU1BMIGZvciB0aGlz IGJvYXJkLCB5b3UgbXVzdCBpbXBsZW1lbnQgaXQgb3IgZWxzZQo+ID4gPiA+Pj4+PiBTUEwgd29u J3Qgd29yazsKPiA+ID4gPj4+Pj4gLSBpZiB0aGlzIGRvZXMgbm90IGJlbG9uZyB0byBTUEwgZm9y IHRoaXMgYm9hcmQsIHlvdSBuZWVkIGltcGxlbWVudCBmdWxsCj4gPiA+ID4+Pj4+IGZ1bmN0aW9u IFNQTDsKPiA+ID4gPj4+Pj4gICAgIGFuZCB5b3UgY2FuIGVpdGhlciB0byBoYXZlIGZ1bGwgZnVu Y3Rpb24gVFBMIHdpdGggRFJBTSBpbml0KHdoaWNoIGlzCj4gPiA+ID4+Pj4+IHByZWZlcmVkKQo+ ID4gPiA+Pj4+PiAgICAgb3IgYWx0ZXJuYXRpdmVseSB1c2UgYmluYXJ5IGxvYWRlciBmcm9tIHZl bmRvci4KPiA+ID4gPj4+PiBUaGlzIGlzIG5vdCByZWFsbHkgYSB0ZWNobmljYWwgYXJndW1lbnQg aGVyZSwgbW9yZSBvZiBhIHBvbGljeSBhcmd1bWVudAo+ID4gPiA+Pj4+IHRoYXQgZW5zdXJlcyB3 ZSBoYXZlIGZ1bGwgZnJlZSBzb2Z0d2FyZSBzdXBwb3J0IGZvciB0aGUgYm9hcmRzIHdlCj4gPiA+ ID4+Pj4gc3VwcG9ydCwgYW5kIG5vdCBvbmx5IGhhbGYtY29va2VkIHN1cHBvcnQgKHRoYXQgd2ls bCBtb3N0IGxpa2VseSBuZXZlcgo+ID4gPiA+Pj4+IGJlIGNvbXBsZXRlZCBhcyBzb29uIGFzIHNv bWV0aGluZyB0aGF0IHdvcmtzIGdldHMgbWVyZ2VkKS4gU28gaXQgaXMgYQo+ID4gPiA+Pj4+IHN0 cmF0ZWdpY2FsIGRlY2lzaW9uLCBub3QgYSBzdHJpY3RseSBwcmFnbWF0aWMgb25lLgo+ID4gCj4g PiA+ID4+PiBXaGlsZSBoYXZpbmcgZnVsbCBvcGVuIHNvdXJjZSBzb2Z0d2FyZSBzdXBwb3J0IGZv ciBib2FyZHMgaXMgYSBub2JsZQo+ID4gPiA+Pj4gZ29hbCwgSSB0aGluayB0aGVyZSBzaG91bGQg YmUgc29tZSByb29tIGZvciBwcmFnbWF0aXNtIGhlcmUuICBBCj4gPiA+ID4+PiBzaWduaWZpY2Fu dCBudW1iZXIgb2YgdV9ib290IHRhcmdldHMgcmVseSBvbiBjbG9zZWQgc291cmNlIGNvbXBvbmVu dHMuCj4gPiA+ID4+PiBJbiB0aGUgcGFydGljdWxhciBjYXNlIG9mIFJLMzM5OSB0aGUgc2l0dWF0 aW9uIGlzIGJldHRlciB0aGFuIGZvcgo+ID4gPiA+Pj4gb3RoZXIgYm9hcmRzIHNpbmNlIHlvdSBj YW4gY29tYmluZSB0aGUgYmluYXJ5IGxvYWRlciBmcm9tIHRoZSB2ZW5kb3IKPiA+ID4gPj4+IHdp dGggbWFpbmxpbmUgVS1Cb290IGFuZCBtYWlubGluZSBBVEYgdG8gY3JlYXRlIGEgZmlybXdhcmUg d2hlcmUgKGFzCj4gPiA+ID4+PiBmYXIgYXMgd2UgY2FuIHRlbGwpIG5vIGNsb3NlZCBzb3VyZSBj b21wb25lbnQgcmVtYWlucyBhY3RpdmUgYWZ0ZXIKPiA+ID4gPj4+IFUtQm9vdCBhbmQgQVRGIHRh a2Ugb3ZlciBjb250cm9sLgo+ID4gPiA+Pj4KPiA+ID4gPj4+PiBJIHRoaW5rIHJldmVydGluZyBw YXRjaGVzIGFkZGluZyBzdXBwb3J0IGZvciBib2FyZHMgd2l0aCBubyBEUkFNCj4gPiA+ID4+Pj4g Y29uZmlndXJhdGlvbiBhdCBhbGwgd291bGQgc2VuZCBhIG1lc3NhZ2UgaW4gdGhlIHJpZ2h0IGRp cmVjdGlvbiBoZXJlLgo+ID4gPiA+PiBBcyBhIGRldmVsb3BlciwgSSBhZ3JlZSBvbiB0aGlzLCBi dXQgYXMgYSBtYWludGFpbmVyLCBJIGtub3cgdG9vIG1hbnkKPiA+ID4gPj4gZGV2ZWxvcGVycyBu b3QgYWJsZSB0byBkbyBpdCBhbmQgd2hhdCBtb3N0IG9mIGRldmVsb3BlcnMgbmVlZCBpcyBvdGhl cgo+ID4gPiA+PiBmZWF0dXJlcyBpbiBVLUJvb3Qgb3IgU1BMLCBhbmQgSSB3b3VsZCBsaWtlIHRo ZSBVLUJvb3QgbWFpbmxpbmUgaXMgbW9yZQo+ID4gPiA+PiBhY3RpdmUgd2l0aCBtb3JlIGFuZCBt b3JlIGRldmVsb3BlcnMuIFNvIEknbSBhZnJhaWQgSSBhZ3JlZSB3aXRoIE1hcmsKPiA+ID4gPj4g YXQgdGhpcyB0aW1lIGZvciB0aGUgcG9saWN5Lgo+ID4gPiA+IE1heWJlIHdlIG5lZWQgdG8gcHJv dmlkZSB0b29scyBvdCBtYWtlIHRoYXQgcHJvY2VzcyBlYXNpZXIgZm9yIGV2ZXJ5b25lCj4gPiA+ ID4gaWYgaXQgaXMgcmVhbGx5IHRoYXQgaGFyZC4gSSBkb24ndCByZWFsbHkgc2VlIHdoYXQgaXMg c28gc3BlY2lhbCBhYm91dAo+ID4gPiA+IERSQU0gdGltaW5ncyB0aGF0IHdvdWxkIGltcGx5IHRo YXQgYSByZWd1bGFyIGRldmVsb3BlciBkb2luZyBhIFUtQm9vdAo+ID4gPiA+IGJyaW5ndXAgY291 bGRuJ3QgZmlndXJlIHRoaW5ncyBvdXQsIGFzaWRlIGZyb20gdGhlIGFiaWxpdHkgdG8gZHVtcCBz YWlkCj4gPiA+ID4gdGltaW5ncy4KPiA+ID4gPgo+ID4gPiA+PiBJZiBhbGwgdGhlIG90aGVyIFNv QyBwbGF0Zm9ybXMgY2FuIGhhdmUgdGhlIHNhbWUgcnVsZSBmb3IgRFJBTSBpbml0IGRyaXZlcgo+ ID4gPiA+PiBpcyBhIG1hbmRhdG9yeSBpbnN0ZWFkIG9mIG9wdGlvbiwgZWcuIGJyY29tLCBxY29t LCBtdGssIG9tYXAsIHRlZ3JhLCBzdG0sCj4gPiA+ID4+IGlteCwgYW1sLCBhbmQgYWxsIG90aGVy cywgdGhlbiBJIHdvdWxkIHZlcnkgaGFwcHkgdG8gZm9sbG93IHRoZSBydWxlLgo+ID4gPiA+PiBS b2NrY2hpcCBpcyBvcGVuIGZvciBvcGVuIHNvdXJjZSB0aGUgRFJBTSBkcml2ZXIsIHlvdSBoYXZl IHRvIGtub3cgdGhpcwo+ID4gPiA+PiBpcyB0aGUgZGVjaXNpb24gYnkgdGhlIHZlbmRvciwgYnV0 IG5vdCBhbnkgb2YgZGV2ZWxvcGVycy4KPiA+ID4gPj4gT24gcm9ja2NoaXAgcGxhdGZvcm0sIGRl dmVsb3BlcnMgbm8gbmVlZCB0byBjb25jZXJuIGFib3V0IHRoZSBEUkFNCj4gPiA+ID4+IGRyaXZl cih3aGljaCBpcyBwcmV0dHkgaGFyZCBmb3IgbW9zdCBkZXZlbG9wZXJzKSBiZWNhdXNlIHJvY2tj aGlwCj4gPiA+ID4+IGFscmVhZHkgY29udHJpYnV0ZSBpdC4KPiA+ID4gPiBSb2NrY2hpcCBpcyBp bmRlZWQgaW4gYSBiZXR0ZXIgcG9zaXRpb24gdGhhbiBvdGhlciB2ZW5kb3JzIHdoZXJlIERSQU0K PiA+ID4gPiBpbml0IG1heSBub3QgYmUgYXZhaWxhYmxlIChvciB3aGVuIGl0J3MgaW1wb3NzaWJs ZSB0byBydW4gVS1Cb290IHJpZ2h0Cj4gPiA+ID4gYWZ0ZXIgdGhlIGJvb3Ryb20gYW5kIGRvIHRo ZSBEUkFNIGluaXQgaXRzZWxmIGJlY2F1c2Ugb2YgZS5nLiBhYnVzaXZlCj4gPiA+ID4gc2lnbmF0 dXJlIHZlcmlmaWNhdGlvbiBvciBsYWNrIG9mIGRvY3VtZW50YXRpb24pLgo+ID4gPiA+Cj4gPiA+ ID4gU2luY2UgdGhlcmUgaXMgZ29vZCBEUkFNIHN1cHBvcnQgZm9yIFJvY2tjaGlwIGluIHBsYWNl LCB3ZSBoYXZlIGFuCj4gPiA+ID4gb3Bwb3J0dW5pdHkgdG8gcHVzaCBkZXZlbG9wZXJzIHRvIGRv IHRoZSByaWdodCB0aGluZyBhbmQgY29udHJpYnV0ZQo+ID4gPiA+IGZ1bGwgc3VwcG9ydCBmb3Ig dGhlIGJvYXJkLiBUbyBtZSBpdCBpcyBzaW1wbHkgYSBtYXR0ZXIgb2YKPiA+ID4gPiBhY2tub3ds ZWRnaW5nIHRoYXQgYm9vdGxvYWRlciBzdXBwb3J0IGZvciBhIGJvYXJkIHdpdGhvdXQgRFJBTSBp bml0IGlzCj4gPiA+ID4gbm90IHVzZWZ1bCBib290bG9hZGVyIHN1cHBvcnQuIFNpbmNlIHdlIGhh dmUgdGhlIGNvZGUgaW4gcGxhY2UgdG8KPiA+ID4gPiBzdXBwb3J0IHRoYXQsIHdlIGNhbiB0YWtl IHRoZSBleHRyYSBzdGVwIGFuZCByZXF1aXJlIHRoYXQgZWFjaCBib2FyZAo+ID4gPiA+IGNvbnRy aWJ1dGlvbiBiZSB1c2VmdWwgaW4gdGhhdCBhc3BlY3QuCj4gPiA+ID4KPiA+ID4gPj4gRm9yIHRo ZSB0aW1lIG5vdywgSSBrbm93IHRoZXJlIHdpbGwgYmUgZnVsbCBEUkFNIGRyaXZlciBmb3Igcm9j a2NoaXAgU29DLAo+ID4gPiA+PiBzbyB0aGUgU29DL2JvYXJkIHN1cHBvcnQgY291bGQgYmUgc3Rl cCBieSBzdGVwOgo+ID4gPiA+PiBVLUJvb3QgcHJvcGVyIC0+IFUtQm9vdCArIFNQTChubyBEUkFN IGluaXQpIC0+VS1Cb290ICsgU1BMICsgVFBMLgo+ID4gCj4gPiBLZWVwaW5nIGFsbG93aW5nIGEg c3RlcC1ieS1zdGVwIGFwcHJvYWNoIGNvdWxkIGJlIGJlbmVmaWNpYWwgSSB0aGluaywKPiA+IGlu IHRoZSBrZXJuZWwgd2UgYWxzbyBkb24ndCByZXF1aXJlIGZ1bGwgc3VwcG9ydCBmb3IgYWxsIHBl cmlwaGVyYWxzIG9uCj4gPiBpbml0aWFsIHN1Ym1pc3Npb24gOy0pIC4KPiA+IAo+ID4gQW5kIGFs c28gZm9yIHBlb3BsZSBzdGFydGluZyBvdXQgb24gYSBzcGVjaWZpYyBib2FyZCBoYXZpbmcgYXQg bGVhc3QgcGFydGlhbAo+ID4gc3VwcG9ydCBpcyB3YXkgZWFzaWVyIHRoYW4gdHJ5aW5nIHRvIGZp Z3VyZSBvdXQgZm9yIGV4YW1wbGUgdGhlIHZlbmRvcgo+ID4gdS1ib290LiAKPiA+IAo+ID4gTWF5 YmUgd2UgY291bGQgZ2l2ZSB0aGlzIHNvbWUgc29ydCBvZiB0aW1lIGxpbWl0YXRpb24gbGlrZQo+ ID4gImJpbmFyeSBkZHItaW5pdCBhbGxvd2VkIHRpbGwgMjAxOS0xMC0zMSIgaW4gS2NvbmZpZyBv ciBzb21ld2hlcmUKPiA+IHRvIGdpdmUgcGVvcGxlIHRoZSBjaGFuY2UgdG8gZG8gdGhpbmdzIHBp ZWNlIGJ5IHBpZWNlIGJ1dCBzdGlsbCBmb3JjZSB0aGVtCj4gPiB0byBhY3R1YWxseSB3b3JrIG9u IGltcHJvdmluZyB0aGUgc2l0dWF0aW9uLgo+ID4gCj4gPiBBcyBkcml2ZXItc2lkZSBjaGFuZ2Vz IHdpbGwgZ2VuZXJhbGx5IGJlbmVmaXQgbW9yZSBzb2NzL2JvYXJkcyBwb3RlbnRpYWwKPiA+IHJl bW92YWwgYWZ0ZXIgdGhlIHRpbWUgbGltaXQgd291bGQgb25seSBhZmZlY3QgdGhlIGJvYXJkK2R0 cyBpdHNlbGYuCj4gPiAKPiA+IFNvIHNvbWV3aGF0IHNpbWlsYXIgdG8gd2hhdCB0aGUga2VybmVs IGRvZXMgd2l0aCAic3RhZ2luZyIsIGlmIHlvdQo+ID4ga2VlcCB3b3JraW5nIG9uIGltcHJvdmlu ZyBpdCwgaXQgaXMgYWxsb3dlZCB0byBzdGF5Lgo+ID4gCj4gPiBUaGlzIGNvdWxkIGJlIGFsc28g YXBwbGllZCB0byBhbHJlYWR5IGluY2x1ZGVkIGJvYXJkcywgbGlrZQo+ID4gImdpdmUgaXQgYSB3 b3JraW5nIGRkci1pbml0IHRpbGwgMjAxOS0xMi0zMSBvciBpdCBnZXRzIHJlbW92ZWQiLCBzaW1p bGFybHkKPiA+IHRvIGhvdyBUb20gaGFuZGxlcyBkZXZpY2VtYW5hZ2VyIGNvbnZlcnNpb25zIGN1 cnJlbnRseQo+IAo+IFN0aWxsIGRvZXNuJ3QgbWFrZSBzZW5zZSB0byBtZSB1bmxlc3MgeW91J3Jl IGdvaW5nIHRvIGVuZm9yY2Ugc3VjaCBhCj4gcnVsZSBmb3IgYWxsIGluY2x1ZGVkIGJvYXJkcyB0 aGF0IGxhY2sgdXNhYmxlIG9wZW4tc291cmNlIERSQU0KPiBpbml0aWFsaXphdGlvbiBjb2RlLiAg T3RoZXJ3aXNlIHlvdSdyZSBqdXN0IHB1bmlzaGluZyBSb2NrY2hpcCBmb3IKPiBoYXZpbmcgYSBw YXJ0aWFsIERSQU0gaW5pdGlhbGl6YXRpb24gY29kZSBhbmQgYXJlIHBvdGVudGlhbGx5IHNlbmRp bmcKPiB0aGUgbWVzc2FnZSB0aGF0IGl0J3MgYmV0dGVyIG5vdCB0byBhdHRlbXB0IGNyZWF0ZSBv cGVuIHNvdXJjZSBEUkFNCj4gZHJpdmVycy4KCmhtbSwgSSdtIG5vdCBzdXJlIGlmIEkgd29yZGVk IG15IHJlcGx5IGp1c3QgcG9vcmx5PyBJIHdhcyB0YWxraW5nIGFib3V0CnRpbWUtbGltaXRpbmcg dGhlIHVzZSBvZiB0aGUgX2JpbmFyeV8gbG9hZGVyIChhcyBUUEwgb3Igd2hhdGV2ZXIpIGZyb20K Um9ja2NoaXAncyBya2JpbiByZXBvIFswXS4gV2hpY2ggd291bGQgbWVhbiBubyBzb3VyY2VmdWwg ZGRyLWRyaXZlciBhdCBhbGwuCgpUaGF0IGNhc2UgKHVzaW5nIHRoZSBiaW5hcnkpIGlzIGEgbmlj ZSBzdGVwcGluZyBzdG9uZSB0byBpdGVyYXRpdmUKZGV2ZWxvcG1lbnQsIGFzIHlvdSBjYW4gY29u Y2VudHJhdGUgb24gb3RoZXIgcGFydHMgb2YgdGhlIGJvb3QgcHJvY2VzcywKYnV0IHdoZW4gaXQg b3ZlcnN0YXlzIGl0cyB3ZWxjb21lIHRoaW5ncyBiZWdpbiB0byByb3QuCgpBbiBleGFtcGxlIGNv dWxkIGJlIHRoZSByazMxMjggaW5jbHVkZWQgaW4gdS1ib290LCBubyBkZHItaW5pdCBhdCBhbGwK KHJlcXVpcmluZyB0aGUgYmluYXJ5IGRkci1pbml0KSBhbmQgYWxzbyBubyBwbGFucyBhdCBhbGwg dG8gY3JlYXRlIHUtYm9vdC0KYmFzZWQgZGRyLWluaXQgaW4gdGhlIGZ1dHVyZS4gQW5kIHRoZSBz b2MgaXMgc28gbmljaGUsIHRoYXQgaXQgc2VlcyBubyByZWFsCmRldmVsb3BtZW50LgoKSW4gdHVy biBJIHdvdWxkIHdlbGNvbWUgYW55IGFwcHJvYWNoIGZvciBhIHNvdXJjZWZ1bCBkZHItaW5pdCBh cyB2YWxpZC4KQmVjYXVzZSBvbmNlIHlvdSBoYXZlIHNvbWV0aGluZyB0aGF0IGF0IGxlYXN0IHdv cmtzLCB5b3UgY2FuIGl0ZXJhdGUKb24gaW1wcm92aW5nIGl0LgoKClswXSBodHRwczovL2dpdGh1 Yi5jb20vcm9ja2NoaXAtbGludXgvcmtiaW4vdHJlZS9tYXN0ZXIvYmluL3JrMzMKQWxsIHRoZSBm b29iYXJfZGRyX2Zvb01Iei5iaW4gZmlsZXMKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KVS1Cb290IG1haWxpbmcgbGlzdApVLUJvb3RAbGlzdHMuZGVu eC5kZQpodHRwczovL2xpc3RzLmRlbnguZGUvbGlzdGluZm8vdS1ib290Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Date: Fri, 21 Jun 2019 15:08:08 +0200 Subject: [U-Boot] [PATCH v2] arm64: dts: rockchip: Add support for Khadas Edge/Edge-V/Captain boards In-Reply-To: <54387ddeae322fba@bloch.sibelius.xs4all.nl> References: <1558696796-10745-1-git-send-email-xieqinick@gmail.com> <5485782.mvTjYBxPra@phil> <54387ddeae322fba@bloch.sibelius.xs4all.nl> Message-ID: <7040262.Yu9PGCMTeE@phil> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de Am Freitag, 21. Juni 2019, 14:52:17 CEST schrieb Mark Kettenis: > > From: Heiko Stuebner > > Date: Fri, 21 Jun 2019 13:34:16 +0200 > > > > Hi, > > > > Am Donnerstag, 20. Juni 2019, 05:24:32 CEST schrieb Kever Yang: > > > On 06/20/2019 12:54 AM, Paul Kocialkowski wrote: > > > > Le mercredi 19 juin 2019 à 09:42 +0800, Kever Yang a écrit : > > > >> On 06/19/2019 12:12 AM, Mark Kettenis wrote: > > > >>>> From: Paul Kocialkowski > > > >>>> Date: Tue, 18 Jun 2019 14:47:33 +0200 > > > >>>> On Tue, 2019-06-18 at 18:08 +0800, Kever Yang wrote: > > > >>>>> On 06/18/2019 05:03 PM, Paul Kocialkowski wrote: > > > >>>>>> On Tue, 2019-06-18 at 14:27 +0530, Jagan Teki wrote: > > > >>>>>>> On Tue, Jun 18, 2019 at 1:55 PM Paul Kocialkowski > > > >>>>>>> wrote: > > > >>>>>>>> On Mon, 2019-06-17 at 15:24 +0800, xieqinick at gmail.com wrote: > > > >>>>>>>>> From: Nick Xie > > > >>>>>>>> Was this tested with SPL support? I don't see DRAM configuration here > > > >>>>>>>> so it seems that it relies on the non-free rockchip loader. > > > >>>>>>>> > > > >>>>>>>> If that is the case, could you please indicate that in the commit > > > >>>>>>>> message? > > > >>>>>>>> > > > >>>>>>>> To maintainers: please do not merge this series before DRAM init and > > > >>>>>>>> SPL support is available for these boards. > > > >>>>>>>> > > > >>>>>>>> It seems that other RK3399 boards were merged without SPL support and > > > >>>>>>>> sofar, I have the feeling that nobody cared to explain how we got into > > > >>>>>>>> this broken situation. Please don't merge any more such board. > > > >>>>>>> fyi: no rk3399 boards were merged w/o SPL. lpddr4 boards were merged > > > >>>>>>> with TPL-enabled (which was discussed on the threads, if you remember) > > > >>>>>>> with below boot chain. > > > >>>>>>> > > > >>>>>>> rkbin (TPL) -> SPL -> U-Boot proper > > > >>>>>>> > > > >>>>>>> Same case for this board as well. > > > >>>>>> Here is a quote from Philipp Tomsich on the thread we discussed this: > > > >>>>>> > > > >>>>>> " On some boards, there will be no TPL and only a SPL stage that will > > > >>>>>> initialise DRAM (as the move to having TPL on the RK3399 is optional). > > > >>>>>> > > > >>>>>> I agree with Paul that the DRAM init should be part of U-Boot whenever > > > >>>>>> we add new boards and make an open DRAM init a prerequisite. " > > > >>>>>> > > > >>>>>> So even if I frequently confuse SPL and TPL, it doesn't change the fact > > > >>>>>> that no board should be merged without proper DRAM init. > > > >>>>>> > > > >>>>>> Please stop pushing for merging these boards. I'm not sure what we > > > >>>>>> should do about the boards that were merged already without DRAM init, > > > >>>>>> but maybe they should be reverted. > > > > > >>>>> I don't think we have to have full DRAM init source code for each > > > >>>>> board before we can merge it, I believe most of the board on U-Boot > > > >>>>> mainline need to removed due to this rule. There are so many boards > > > >>>>> from different vendor need a binary loader before U-Boot, and I can > > > >>>>> see only very few drivers for dram at driver/ram/, and I believe rockchip > > > >>>>> is already the most open vendor on this area. > > > > > >>>> Well, I am not talking about full DRAM init source code as in dynamic > > > >>>> link training. I am talking about having at least static DRAM register > > > >>>> configuration values, > > > > > >> I can tell you that this is no work for all the boards, you can see how > > > >> rockchip lpddr4(WIP, send by Jagan) driver works. > > > > > > I thought that LPDDR4 works the same as other types of DRAM where we > > > > have a dtsi array with timings configuration. Of course, some more > > > > registers need to be set up, but we already have support for that or > > > > it's quite close (for LPDDR4). > > > > > > >>>> which is present for a good number of rockchip > > > >>>> boards. > > > >> No, there is no rockchip board only have static DRAM register > > > >> configuration values, that maybe happens in other vendor. > > > > > > > I was implying that, as far as I know, it is the case for DRAM timings > > > > on Rockchip as well as most of the platforms that I know of. In the > > > > end, any code handling DRAM will end up writing timings to the > > > > controller's registers. If the DRAM is part of the PCB and doesn't > > > > change/move, then the timings don't change in particular. > > > > > > > > Is there something specific about Rockchip that makes it require > > > > different DRAM timings at each boot? > > > > > > >>>> Of course, it would be best if Rockchip would consider releasing this > > > >>>> source code, > > > >> Rockchip already release all the DRAM init source code, including DDR3 , > > > >> LPDDR3, > > > >> and LPDDR4(wip). You can see the driver at driver/ram/rockchip/ for > > > >> everything, > > > >> which is not only static register configuration. > > > >> As I have said, rockchip is already the most open vendor in this area > > > >> till now, I don't know > > > >> if you have working on rockchip SoC based boards. > > > > You are quite right about that, but I was thinking about the code to > > > > calculate DRAM timings (with link-training and such) which is often not > > > > available as free software, and I am not aware of Rockchip having > > > > released that code (but feel free to correct me if I'm wrong). > > > > > > > >>>> which would be the easiest and friendliest solution > > > >>>> towards the community here. Are there internal discussions ongoing > > > >>>> about this? If not, it would be greatly appreciated to start such > > > >>>> discussions and clearly identify what the blocking points are. > > > >>>> > > > >>>>> I won't use this rule to stop developers contribute there source code, > > > >>>> This is really sad and I think that Philipp was, like me, inclined to > > > >>>> go towards the other direction. > > > >>>> > > > >>>>> for a board support, we only need the board to have the full documentation > > > >>>>> about how to setup and boot with upstream U-Boot. and I think the > > > >>>>> most of people cares more about features in U-Boot proper. Everything > > > >>>>> before U-Boot proper, you can use TPL/SPL or alternative to use binary > > > >>>>> from vendor, as you can see all over the U-Boot mainline now, although > > > >>>>> we encourage people to use full open source TPL/SPL. > > > >>>>> Specifically for U-Boot Rockchip platform, I would like people to > > > >>>>> support not only U-Boot > > > >>>>> proper, but also for full SPL(ATF, OP-TEE support, itb image and other > > > >>>>> features) > > > >>>>> support. And for DRAM init, > > > >>>>> - if this belongs to SPL for this board, you must implement it or else > > > >>>>> SPL won't work; > > > >>>>> - if this does not belong to SPL for this board, you need implement full > > > >>>>> function SPL; > > > >>>>> and you can either to have full function TPL with DRAM init(which is > > > >>>>> prefered) > > > >>>>> or alternatively use binary loader from vendor. > > > >>>> This is not really a technical argument here, more of a policy argument > > > >>>> that ensures we have full free software support for the boards we > > > >>>> support, and not only half-cooked support (that will most likely never > > > >>>> be completed as soon as something that works gets merged). So it is a > > > >>>> strategical decision, not a strictly pragmatic one. > > > > > >>> While having full open source software support for boards is a noble > > > >>> goal, I think there should be some room for pragmatism here. A > > > >>> significant number of u_boot targets rely on closed source components. > > > >>> In the particular case of RK3399 the situation is better than for > > > >>> other boards since you can combine the binary loader from the vendor > > > >>> with mainline U-Boot and mainline ATF to create a firmware where (as > > > >>> far as we can tell) no closed soure component remains active after > > > >>> U-Boot and ATF take over control. > > > >>> > > > >>>> I think reverting patches adding support for boards with no DRAM > > > >>>> configuration at all would send a message in the right direction here. > > > >> As a developer, I agree on this, but as a maintainer, I know too many > > > >> developers not able to do it and what most of developers need is other > > > >> features in U-Boot or SPL, and I would like the U-Boot mainline is more > > > >> active with more and more developers. So I'm afraid I agree with Mark > > > >> at this time for the policy. > > > > Maybe we need to provide tools ot make that process easier for everyone > > > > if it is really that hard. I don't really see what is so special about > > > > DRAM timings that would imply that a regular developer doing a U-Boot > > > > bringup couldn't figure things out, aside from the ability to dump said > > > > timings. > > > > > > > >> If all the other SoC platforms can have the same rule for DRAM init driver > > > >> is a mandatory instead of option, eg. brcom, qcom, mtk, omap, tegra, stm, > > > >> imx, aml, and all others, then I would very happy to follow the rule. > > > >> Rockchip is open for open source the DRAM driver, you have to know this > > > >> is the decision by the vendor, but not any of developers. > > > >> On rockchip platform, developers no need to concern about the DRAM > > > >> driver(which is pretty hard for most developers) because rockchip > > > >> already contribute it. > > > > Rockchip is indeed in a better position than other vendors where DRAM > > > > init may not be available (or when it's impossible to run U-Boot right > > > > after the bootrom and do the DRAM init itself because of e.g. abusive > > > > signature verification or lack of documentation). > > > > > > > > Since there is good DRAM support for Rockchip in place, we have an > > > > opportunity to push developers to do the right thing and contribute > > > > full support for the board. To me it is simply a matter of > > > > acknowledging that bootloader support for a board without DRAM init is > > > > not useful bootloader support. Since we have the code in place to > > > > support that, we can take the extra step and require that each board > > > > contribution be useful in that aspect. > > > > > > > >> For the time now, I know there will be full DRAM driver for rockchip SoC, > > > >> so the SoC/board support could be step by step: > > > >> U-Boot proper -> U-Boot + SPL(no DRAM init) ->U-Boot + SPL + TPL. > > > > Keeping allowing a step-by-step approach could be beneficial I think, > > in the kernel we also don't require full support for all peripherals on > > initial submission ;-) . > > > > And also for people starting out on a specific board having at least partial > > support is way easier than trying to figure out for example the vendor > > u-boot. > > > > Maybe we could give this some sort of time limitation like > > "binary ddr-init allowed till 2019-10-31" in Kconfig or somewhere > > to give people the chance to do things piece by piece but still force them > > to actually work on improving the situation. > > > > As driver-side changes will generally benefit more socs/boards potential > > removal after the time limit would only affect the board+dts itself. > > > > So somewhat similar to what the kernel does with "staging", if you > > keep working on improving it, it is allowed to stay. > > > > This could be also applied to already included boards, like > > "give it a working ddr-init till 2019-12-31 or it gets removed", similarly > > to how Tom handles devicemanager conversions currently > > Still doesn't make sense to me unless you're going to enforce such a > rule for all included boards that lack usable open-source DRAM > initialization code. Otherwise you're just punishing Rockchip for > having a partial DRAM initialization code and are potentially sending > the message that it's better not to attempt create open source DRAM > drivers. hmm, I'm not sure if I worded my reply just poorly? I was talking about time-limiting the use of the _binary_ loader (as TPL or whatever) from Rockchip's rkbin repo [0]. Which would mean no sourceful ddr-driver at all. That case (using the binary) is a nice stepping stone to iterative development, as you can concentrate on other parts of the boot process, but when it overstays its welcome things begin to rot. An example could be the rk3128 included in u-boot, no ddr-init at all (requiring the binary ddr-init) and also no plans at all to create u-boot- based ddr-init in the future. And the soc is so niche, that it sees no real development. In turn I would welcome any approach for a sourceful ddr-init as valid. Because once you have something that at least works, you can iterate on improving it. [0] https://github.com/rockchip-linux/rkbin/tree/master/bin/rk33 All the foobar_ddr_fooMHz.bin files