diff for duplicates of <7041bf01-d91f-3149-e8ba-5db4ba59f9bb@linux.microsoft.com> diff --git a/a/1.txt b/N1/1.txt index c86c9bc..42c87e3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,20 +1,20 @@ On 7/12/2022 10:32 PM, Dhananjay Phadke wrote: >> +static void aspeed_ahash_iV(struct aspeed_sham_reqctx *rctx) >> +{ ->> +??? if (rctx->flags & SHA_FLAGS_SHA1) ->> +??????? memcpy(rctx->digest, sha1_iv, 32); ->> +??? else if (rctx->flags & SHA_FLAGS_SHA224) ->> +??????? memcpy(rctx->digest, sha224_iv, 32); ->> +??? else if (rctx->flags & SHA_FLAGS_SHA256) ->> +??????? memcpy(rctx->digest, sha256_iv, 32); ->> +??? else if (rctx->flags & SHA_FLAGS_SHA384) ->> +??????? memcpy(rctx->digest, sha384_iv, 64); ->> +??? else if (rctx->flags & SHA_FLAGS_SHA512) ->> +??????? memcpy(rctx->digest, sha512_iv, 64); ->> +??? else if (rctx->flags & SHA_FLAGS_SHA512_224) ->> +??????? memcpy(rctx->digest, sha512_224_iv, 64); ->> +??? else if (rctx->flags & SHA_FLAGS_SHA512_256) ->> +??????? memcpy(rctx->digest, sha512_256_iv, 64); +>> + if (rctx->flags & SHA_FLAGS_SHA1) +>> + memcpy(rctx->digest, sha1_iv, 32); +>> + else if (rctx->flags & SHA_FLAGS_SHA224) +>> + memcpy(rctx->digest, sha224_iv, 32); +>> + else if (rctx->flags & SHA_FLAGS_SHA256) +>> + memcpy(rctx->digest, sha256_iv, 32); +>> + else if (rctx->flags & SHA_FLAGS_SHA384) +>> + memcpy(rctx->digest, sha384_iv, 64); +>> + else if (rctx->flags & SHA_FLAGS_SHA512) +>> + memcpy(rctx->digest, sha512_iv, 64); +>> + else if (rctx->flags & SHA_FLAGS_SHA512_224) +>> + memcpy(rctx->digest, sha512_224_iv, 64); +>> + else if (rctx->flags & SHA_FLAGS_SHA512_256) +>> + memcpy(rctx->digest, sha512_256_iv, 64); >> +} > > Can use the "digsize" from reqctx to memcpy() instead lots of if..else diff --git a/a/content_digest b/N1/content_digest index 9582753..5584a29 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,28 +2,45 @@ "ref\020220705020936.1751771-2-neal_liu@aspeedtech.com\0" "ref\045058512-0661-5d34-7faf-ddf3eb6142ec@linux.microsoft.com\0" "From\0Dhananjay Phadke <dphadke@linux.microsoft.com>\0" - "Subject\0[PATCH v7 1/5] crypto: aspeed: Add HACE hash driver\0" + "Subject\0Re: [PATCH v7 1/5] crypto: aspeed: Add HACE hash driver\0" "Date\0Wed, 13 Jul 2022 00:24:45 -0700\0" - "To\0linux-aspeed@lists.ozlabs.org\0" + "To\0Neal Liu <neal_liu@aspeedtech.com>" + Corentin Labbe <clabbe.montjoie@gmail.com> + Christophe JAILLET <christophe.jaillet@wanadoo.fr> + Randy Dunlap <rdunlap@infradead.org> + Herbert Xu <herbert@gondor.apana.org.au> + David S . Miller <davem@davemloft.net> + Rob Herring <robh+dt@kernel.org> + Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> + Joel Stanley <joel@jms.id.au> + Andrew Jeffery <andrew@aj.id.au> + Dhananjay Phadke <dhphadke@microsoft.com> + " Johnny Huang <johnny_huang@aspeedtech.com>\0" + "Cc\0linux-aspeed@lists.ozlabs.org" + linux-crypto@vger.kernel.org + devicetree@vger.kernel.org + linux-arm-kernel@lists.infradead.org + linux-kernel@vger.kernel.org + " BMC-SW@aspeedtech.com\0" "\00:1\0" "b\0" "On 7/12/2022 10:32 PM, Dhananjay Phadke wrote:\n" ">> +static void aspeed_ahash_iV(struct aspeed_sham_reqctx *rctx)\n" ">> +{\n" - ">> +??? if (rctx->flags & SHA_FLAGS_SHA1)\n" - ">> +??????? memcpy(rctx->digest, sha1_iv, 32);\n" - ">> +??? else if (rctx->flags & SHA_FLAGS_SHA224)\n" - ">> +??????? memcpy(rctx->digest, sha224_iv, 32);\n" - ">> +??? else if (rctx->flags & SHA_FLAGS_SHA256)\n" - ">> +??????? memcpy(rctx->digest, sha256_iv, 32);\n" - ">> +??? else if (rctx->flags & SHA_FLAGS_SHA384)\n" - ">> +??????? memcpy(rctx->digest, sha384_iv, 64);\n" - ">> +??? else if (rctx->flags & SHA_FLAGS_SHA512)\n" - ">> +??????? memcpy(rctx->digest, sha512_iv, 64);\n" - ">> +??? else if (rctx->flags & SHA_FLAGS_SHA512_224)\n" - ">> +??????? memcpy(rctx->digest, sha512_224_iv, 64);\n" - ">> +??? else if (rctx->flags & SHA_FLAGS_SHA512_256)\n" - ">> +??????? memcpy(rctx->digest, sha512_256_iv, 64);\n" + ">> +\302\240\302\240\302\240 if (rctx->flags & SHA_FLAGS_SHA1)\n" + ">> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 memcpy(rctx->digest, sha1_iv, 32);\n" + ">> +\302\240\302\240\302\240 else if (rctx->flags & SHA_FLAGS_SHA224)\n" + ">> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 memcpy(rctx->digest, sha224_iv, 32);\n" + ">> +\302\240\302\240\302\240 else if (rctx->flags & SHA_FLAGS_SHA256)\n" + ">> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 memcpy(rctx->digest, sha256_iv, 32);\n" + ">> +\302\240\302\240\302\240 else if (rctx->flags & SHA_FLAGS_SHA384)\n" + ">> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 memcpy(rctx->digest, sha384_iv, 64);\n" + ">> +\302\240\302\240\302\240 else if (rctx->flags & SHA_FLAGS_SHA512)\n" + ">> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 memcpy(rctx->digest, sha512_iv, 64);\n" + ">> +\302\240\302\240\302\240 else if (rctx->flags & SHA_FLAGS_SHA512_224)\n" + ">> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 memcpy(rctx->digest, sha512_224_iv, 64);\n" + ">> +\302\240\302\240\302\240 else if (rctx->flags & SHA_FLAGS_SHA512_256)\n" + ">> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 memcpy(rctx->digest, sha512_256_iv, 64);\n" ">> +}\n" "> \n" "> Can use the \"digsize\" from reqctx to memcpy() instead lots of if..else\n" @@ -35,4 +52,4 @@ "Thanks,\n" Dhananjay -fe2aa85757018ea529469ebb35c3fcc75c208bac5c1d3f22310373de33dbb6d3 +82c19fc5b1890df676a920c3bf80253d1ae8f1bde3509df01f9a223007c10134
diff --git a/a/1.txt b/N2/1.txt index c86c9bc..e50248e 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,20 +1,20 @@ On 7/12/2022 10:32 PM, Dhananjay Phadke wrote: >> +static void aspeed_ahash_iV(struct aspeed_sham_reqctx *rctx) >> +{ ->> +??? if (rctx->flags & SHA_FLAGS_SHA1) ->> +??????? memcpy(rctx->digest, sha1_iv, 32); ->> +??? else if (rctx->flags & SHA_FLAGS_SHA224) ->> +??????? memcpy(rctx->digest, sha224_iv, 32); ->> +??? else if (rctx->flags & SHA_FLAGS_SHA256) ->> +??????? memcpy(rctx->digest, sha256_iv, 32); ->> +??? else if (rctx->flags & SHA_FLAGS_SHA384) ->> +??????? memcpy(rctx->digest, sha384_iv, 64); ->> +??? else if (rctx->flags & SHA_FLAGS_SHA512) ->> +??????? memcpy(rctx->digest, sha512_iv, 64); ->> +??? else if (rctx->flags & SHA_FLAGS_SHA512_224) ->> +??????? memcpy(rctx->digest, sha512_224_iv, 64); ->> +??? else if (rctx->flags & SHA_FLAGS_SHA512_256) ->> +??????? memcpy(rctx->digest, sha512_256_iv, 64); +>> + if (rctx->flags & SHA_FLAGS_SHA1) +>> + memcpy(rctx->digest, sha1_iv, 32); +>> + else if (rctx->flags & SHA_FLAGS_SHA224) +>> + memcpy(rctx->digest, sha224_iv, 32); +>> + else if (rctx->flags & SHA_FLAGS_SHA256) +>> + memcpy(rctx->digest, sha256_iv, 32); +>> + else if (rctx->flags & SHA_FLAGS_SHA384) +>> + memcpy(rctx->digest, sha384_iv, 64); +>> + else if (rctx->flags & SHA_FLAGS_SHA512) +>> + memcpy(rctx->digest, sha512_iv, 64); +>> + else if (rctx->flags & SHA_FLAGS_SHA512_224) +>> + memcpy(rctx->digest, sha512_224_iv, 64); +>> + else if (rctx->flags & SHA_FLAGS_SHA512_256) +>> + memcpy(rctx->digest, sha512_256_iv, 64); >> +} > > Can use the "digsize" from reqctx to memcpy() instead lots of if..else @@ -25,3 +25,8 @@ in alg wrapper structure (aspeed_hace_alg). Thanks, Dhananjay + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N2/content_digest index 9582753..36b58b5 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,28 +2,45 @@ "ref\020220705020936.1751771-2-neal_liu@aspeedtech.com\0" "ref\045058512-0661-5d34-7faf-ddf3eb6142ec@linux.microsoft.com\0" "From\0Dhananjay Phadke <dphadke@linux.microsoft.com>\0" - "Subject\0[PATCH v7 1/5] crypto: aspeed: Add HACE hash driver\0" + "Subject\0Re: [PATCH v7 1/5] crypto: aspeed: Add HACE hash driver\0" "Date\0Wed, 13 Jul 2022 00:24:45 -0700\0" - "To\0linux-aspeed@lists.ozlabs.org\0" + "To\0Neal Liu <neal_liu@aspeedtech.com>" + Corentin Labbe <clabbe.montjoie@gmail.com> + Christophe JAILLET <christophe.jaillet@wanadoo.fr> + Randy Dunlap <rdunlap@infradead.org> + Herbert Xu <herbert@gondor.apana.org.au> + David S . Miller <davem@davemloft.net> + Rob Herring <robh+dt@kernel.org> + Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> + Joel Stanley <joel@jms.id.au> + Andrew Jeffery <andrew@aj.id.au> + Dhananjay Phadke <dhphadke@microsoft.com> + " Johnny Huang <johnny_huang@aspeedtech.com>\0" + "Cc\0linux-aspeed@lists.ozlabs.org" + linux-crypto@vger.kernel.org + devicetree@vger.kernel.org + linux-arm-kernel@lists.infradead.org + linux-kernel@vger.kernel.org + " BMC-SW@aspeedtech.com\0" "\00:1\0" "b\0" "On 7/12/2022 10:32 PM, Dhananjay Phadke wrote:\n" ">> +static void aspeed_ahash_iV(struct aspeed_sham_reqctx *rctx)\n" ">> +{\n" - ">> +??? if (rctx->flags & SHA_FLAGS_SHA1)\n" - ">> +??????? memcpy(rctx->digest, sha1_iv, 32);\n" - ">> +??? else if (rctx->flags & SHA_FLAGS_SHA224)\n" - ">> +??????? memcpy(rctx->digest, sha224_iv, 32);\n" - ">> +??? else if (rctx->flags & SHA_FLAGS_SHA256)\n" - ">> +??????? memcpy(rctx->digest, sha256_iv, 32);\n" - ">> +??? else if (rctx->flags & SHA_FLAGS_SHA384)\n" - ">> +??????? memcpy(rctx->digest, sha384_iv, 64);\n" - ">> +??? else if (rctx->flags & SHA_FLAGS_SHA512)\n" - ">> +??????? memcpy(rctx->digest, sha512_iv, 64);\n" - ">> +??? else if (rctx->flags & SHA_FLAGS_SHA512_224)\n" - ">> +??????? memcpy(rctx->digest, sha512_224_iv, 64);\n" - ">> +??? else if (rctx->flags & SHA_FLAGS_SHA512_256)\n" - ">> +??????? memcpy(rctx->digest, sha512_256_iv, 64);\n" + ">> +\302\240\302\240\302\240 if (rctx->flags & SHA_FLAGS_SHA1)\n" + ">> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 memcpy(rctx->digest, sha1_iv, 32);\n" + ">> +\302\240\302\240\302\240 else if (rctx->flags & SHA_FLAGS_SHA224)\n" + ">> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 memcpy(rctx->digest, sha224_iv, 32);\n" + ">> +\302\240\302\240\302\240 else if (rctx->flags & SHA_FLAGS_SHA256)\n" + ">> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 memcpy(rctx->digest, sha256_iv, 32);\n" + ">> +\302\240\302\240\302\240 else if (rctx->flags & SHA_FLAGS_SHA384)\n" + ">> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 memcpy(rctx->digest, sha384_iv, 64);\n" + ">> +\302\240\302\240\302\240 else if (rctx->flags & SHA_FLAGS_SHA512)\n" + ">> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 memcpy(rctx->digest, sha512_iv, 64);\n" + ">> +\302\240\302\240\302\240 else if (rctx->flags & SHA_FLAGS_SHA512_224)\n" + ">> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 memcpy(rctx->digest, sha512_224_iv, 64);\n" + ">> +\302\240\302\240\302\240 else if (rctx->flags & SHA_FLAGS_SHA512_256)\n" + ">> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 memcpy(rctx->digest, sha512_256_iv, 64);\n" ">> +}\n" "> \n" "> Can use the \"digsize\" from reqctx to memcpy() instead lots of if..else\n" @@ -33,6 +50,11 @@ "in alg wrapper structure (aspeed_hace_alg).\n" "\n" "Thanks,\n" - Dhananjay + "Dhananjay\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -fe2aa85757018ea529469ebb35c3fcc75c208bac5c1d3f22310373de33dbb6d3 +5ba2aa111aa7a72f068ee298a335a7fede8f84d80a39c9d126810505f8301779
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.