Re: [PATCH 01/14] hob: labelling changes in Hob

[Paul Eggleton <paul.eggleton@linux.intel.com>]

Hi Cristiana,

On Wednesday 17 July 2013 13:35:31 Cristiana Voicu wrote:
> When the design document for templates in Hob was created, we've noticed
> that some labels need to change.
> 
> [YOCTO #4193]
> Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
> ---
>  bitbake/lib/bb/ui/crumbs/hobeventhandler.py        |    2 +-
>  bitbake/lib/bb/ui/crumbs/hoblistmodel.py           |    2 +-
>  bitbake/lib/bb/ui/crumbs/imageconfigurationpage.py |   16 ++++++----------
>  bitbake/lib/bb/ui/crumbs/imagedetailspage.py       |    5 +++++
>  4 files changed, 13 insertions(+), 12 deletions(-)
> 
> diff --git a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
> b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py index 8788083..ebcb846 100644
> --- a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
> +++ b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
> @@ -174,7 +174,7 @@ class HobHandler(gobject.GObject):
>                  targets.append(self.toolchain)
>              if targets[0] == "hob-image":
>                  hobImage = self.runCommand(["matchFile", "hob-image.bb"])
> -                if self.base_image != "Create your own image":
> +                if self.base_image != "Create a new base image":

I've been talking with Belen today, and it seems like we have a bit of a 
terminology problem here. What we're dealing with here are "image recipes" 
rather than "base images". (The "base" part was just in context for the 
initial selection when we're selecting what to base our custom image on and 
then modify its contents.). Could you work with Belen to get the appropriate 
minor changes for this solidified?

Thanks,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre