From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EDA1C433DF for ; Thu, 28 May 2020 12:10:30 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 107DA2063A for ; Thu, 28 May 2020 12:10:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ht9aeBKO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 107DA2063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9C4564B20E; Thu, 28 May 2020 08:10:29 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KV7mo2-MNxGM; Thu, 28 May 2020 08:10:28 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 385F54B235; Thu, 28 May 2020 08:10:28 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 064CA4B20C for ; Thu, 28 May 2020 08:10:27 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IR8HyZSIieVE for ; Thu, 28 May 2020 08:10:26 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id D16504B20D for ; Thu, 28 May 2020 08:10:25 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A250C2063A; Thu, 28 May 2020 12:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590667824; bh=d+BX6Yu8bblCkc+YNytpyy6IyNc3spMni5yB2tDpCBo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ht9aeBKOOs2qT1O/Jvk9zPAOcwXArR2X6BqtFlTRNkhygdQL6r7LWzmyaWb1t3W8h UqL6mOfc0/m5+zw2y/OBxfwIasqR7K5PEpKjOHGYp4+m2sY25Oc9jSCCDK8KjpZOvF ib1gW6SFhgUu7PfBzWBFDbczaL8jB4B44mtPq0fU= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jeHMd-00Fyr7-3o; Thu, 28 May 2020 13:10:23 +0100 MIME-Version: 1.0 Date: Thu, 28 May 2020 13:10:23 +0100 From: Marc Zyngier To: James Morse Subject: Re: [PATCH 1/3] KVM: arm64: Stop writing aarch32's CSSELR into ACTLR In-Reply-To: <09dca8e9-c548-43fd-a95b-747a77f19e02@arm.com> References: <20200526161834.29165-1-james.morse@arm.com> <20200526161834.29165-2-james.morse@arm.com> <4be0c0b654f7d7c1efe9f52efb856bd8@kernel.org> <09dca8e9-c548-43fd-a95b-747a77f19e02@arm.com> User-Agent: Roundcube Webmail/1.4.4 Message-ID: <705687e37c5d5339a6baafa9e31675cb@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: james.morse@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: stable@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gMjAyMC0wNS0yOCAxMjo1OSwgSmFtZXMgTW9yc2Ugd3JvdGU6Cj4gSGkgTWFyYywKPiAKPiBP biAyOC8wNS8yMDIwIDA5OjU3LCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+IE9uIDIwMjAtMDUtMjYg MTc6MTgsIEphbWVzIE1vcnNlIHdyb3RlOgo+Pj4gYWNjZXNzX2Nzc2VscigpIHVzZXMgdGhlIDMy Yml0IHItPnJlZyB2YWx1ZSB0byBhY2Nlc3MgdGhlIDY0Yml0IAo+Pj4gYXJyYXksCj4+PiBzbyBy ZWFkcyBhbmQgd3JpdGUgdGhlIHdyb25nIHZhbHVlLiBzeXNfcmVnc1s0XSwgaXMgQUNUTFJfRUwx LCB3aGljaAo+Pj4gaXMgc3Vic2VxdWVudGx5IHNhdmUvcmVzdG9yZWQgd2hlbiB3ZSBlbnRlciB0 aGUgZ3Vlc3QuCj4gCj4+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYyBi L2FyY2gvYXJtNjQva3ZtL3N5c19yZWdzLmMKPj4+IGluZGV4IDUxZGI5MzQ3MDJiNi4uMmVkYTUz OWYzMjgxIDEwMDY0NAo+Pj4gLS0tIGEvYXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYwo+Pj4gKysr IGIvYXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYwo+Pj4gQEAgLTIwNjAsNyArMjA2MCw3IEBAIHN0 YXRpYyBjb25zdCBzdHJ1Y3Qgc3lzX3JlZ19kZXNjIGNwMTVfcmVnc1tdID0gCj4+PiB7Cj4+PiAK Pj4+IMKgwqDCoMKgIHsgT3AxKDEpLCBDUm4oIDApLCBDUm0oIDApLCBPcDIoMCksIGFjY2Vzc19j Y3NpZHIgfSwKPj4+IMKgwqDCoMKgIHsgT3AxKDEpLCBDUm4oIDApLCBDUm0oIDApLCBPcDIoMSks IGFjY2Vzc19jbGlkciB9LAo+Pj4gLcKgwqDCoCB7IE9wMSgyKSwgQ1JuKCAwKSwgQ1JtKCAwKSwg T3AyKDApLCBhY2Nlc3NfY3NzZWxyLCBOVUxMLCAKPj4+IGMwX0NTU0VMUiB9LAo+Pj4gK8KgwqDC oCB7IE9wMSgyKSwgQ1JuKCAwKSwgQ1JtKCAwKSwgT3AyKDApLCBhY2Nlc3NfY3NzZWxyX2VsMSwg TlVMTCwgCj4+PiBDU1NFTFJfRUwxIH0sCj4+PiDCoH07Cj4gCj4+IFRoaXMgaXMgYSBkZXBhcnR1 cmUgZnJvbSB0aGUgd2F5IHdlIGRlYWwgd2l0aCAzMmJpdCBDUDE1IHJlZ2lzdGVycy4KPj4gV2Ug ZGVhbCB3aXRoIHRoaXMgZXhhY3QgaXNzdWUgaW4gYSB2ZXJ5IGRpZmZlcmVudCB3YXkgZm9yIG90 aGVyCj4+IENQMTUgcmVncywgYnkgYWRqdXN0aW5nIHRoZSBpbmRleCBpbiB0aGUgc3lzX3JlZ3Mg YXJyYXkgKHNlZSB0aGUKPj4gd2F5IHdlIGhhbmRsZSB0aGUgVk0gcmVncykuCj4+IAo+PiBIb3cg YWJvdXQgc29tZXRoaW5nIGxpa2UgdGhpcyAodW50ZXN0ZWQpOgo+IAo+IFtsaWtlIGFjY2Vzc192 bV9yZWcoKSBkb2VzXQo+IAo+IFN1cmUsIEknbGwgZ2l2ZSB0aGF0IGEgdGVzdCBhbmQgcmUtcG9z dCBpdC4KClRoYW5rcyEKCj4gCj4gCj4+IElkZWFsbHksIEknZCBsaWtlIHRoZSBjb3JlIHN5c19y ZWcgY29kZSB0byBkZWFsIHdpdGggdGhpcyBzb3J0Cj4+IG9mIGZ1bm5pZXMsIGJ1dCBJJ20gdHJ5 aW5nIHRvIGtlZXAgdGhlIGNoYW5nZSBtaW5pbWFsLi4uCj4gCj4gUm9sbCB0aGlzICcvMicgYW5k IHVwcGVyL2xvd2VyIGJpdHMgc3R1ZmYgaW50byBhIHZjcHVfd3JpdGVfY3AxNV9yZWcoKQo+IHRo YXQgY2FsbHMKPiB2Y3B1X3dyaXRlX3N5c19yZWcoKT8gKC9tZSBodW50cyBvdXQgdGhlIHRvZG8g bGlzdCkKCkkgd2FzIHRoaW5raW5nIG9mIGhpZGluZyBpdCBkaWZmZXJlbnRseTogaW4gZW11bGF0 ZV9jcCwgc3Vic3RpdHV0ZSB0aGUKc3lzX3JlZ19kZXNjIHN0cnVjdHVyZSBmb3IgYSB0ZW1wb3Jh cnkgb25lIHRoYXQgcmVwcmVzZW50cyB0aGUgNjRiaXQKdmVyc2lvbiwgYW5kIG1ha2UgaXQgY29t cGxldGVseSB0cmFuc3BhcmVudC4KCkknbSBzdXJlIHRoZXJlIGlzIGEgY291cGxlIG9mIG5pdHMg YXJvdW5kIHRoYXQgdGhvdWdoLi4uCgogICAgICAgICBNLgotLSAKSmF6eiBpcyBub3QgZGVhZC4g SXQganVzdCBzbWVsbHMgZnVubnkuLi4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1i aWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGluZm8va3Zt YXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB57CC433E1 for ; Thu, 28 May 2020 12:10:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7304521BE5 for ; Thu, 28 May 2020 12:10:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BHGO7oO3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ht9aeBKO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7304521BE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3lhfjJgvrEVzo5+mtYZ/tXSJBrSV9Y9NTN6KyJ85/9U=; b=BHGO7oO3eFL7t4LUogvGUZYMa lWz6+uCUxNORK0Cvh08ObPOX122FyBKLqFLZLS2SsjY/wH8HTxkAHxzjUNgA8ixHZ6y+yeuONkiP4 88PBHy0Zm1vR13MK8wTWVC4h4jHTEGT/YwOLqN4tljRSUy8EAudKQZOjOPTNO4yqyYjTYlkhWa/sT YdT6LN+Y0KeNGXz25cY9Yab54EPFPh/sUNvC73wFVLIClfECXU9lkt/SslyIyfNyh99qIm19sYARG 8mrwDbP2tQuFlP4yVxlXFHEcz1YLGS2lMOnwVA1Kh1Os3C1d4idKPcoTfOPUIFdLIcTeSewL6FMHg UDLrxr2Eg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeHMn-0006hx-MO; Thu, 28 May 2020 12:10:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeHMf-0006dm-TD for linux-arm-kernel@lists.infradead.org; Thu, 28 May 2020 12:10:27 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A250C2063A; Thu, 28 May 2020 12:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590667824; bh=d+BX6Yu8bblCkc+YNytpyy6IyNc3spMni5yB2tDpCBo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ht9aeBKOOs2qT1O/Jvk9zPAOcwXArR2X6BqtFlTRNkhygdQL6r7LWzmyaWb1t3W8h UqL6mOfc0/m5+zw2y/OBxfwIasqR7K5PEpKjOHGYp4+m2sY25Oc9jSCCDK8KjpZOvF ib1gW6SFhgUu7PfBzWBFDbczaL8jB4B44mtPq0fU= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jeHMd-00Fyr7-3o; Thu, 28 May 2020 13:10:23 +0100 MIME-Version: 1.0 Date: Thu, 28 May 2020 13:10:23 +0100 From: Marc Zyngier To: James Morse Subject: Re: [PATCH 1/3] KVM: arm64: Stop writing aarch32's CSSELR into ACTLR In-Reply-To: <09dca8e9-c548-43fd-a95b-747a77f19e02@arm.com> References: <20200526161834.29165-1-james.morse@arm.com> <20200526161834.29165-2-james.morse@arm.com> <4be0c0b654f7d7c1efe9f52efb856bd8@kernel.org> <09dca8e9-c548-43fd-a95b-747a77f19e02@arm.com> User-Agent: Roundcube Webmail/1.4.4 Message-ID: <705687e37c5d5339a6baafa9e31675cb@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: james.morse@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_051025_995352_BB30C5A0 X-CRM114-Status: GOOD ( 14.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Julien Thierry , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Suzuki K Poulose Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0wNS0yOCAxMjo1OSwgSmFtZXMgTW9yc2Ugd3JvdGU6Cj4gSGkgTWFyYywKPiAKPiBP biAyOC8wNS8yMDIwIDA5OjU3LCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+IE9uIDIwMjAtMDUtMjYg MTc6MTgsIEphbWVzIE1vcnNlIHdyb3RlOgo+Pj4gYWNjZXNzX2Nzc2VscigpIHVzZXMgdGhlIDMy Yml0IHItPnJlZyB2YWx1ZSB0byBhY2Nlc3MgdGhlIDY0Yml0IAo+Pj4gYXJyYXksCj4+PiBzbyBy ZWFkcyBhbmQgd3JpdGUgdGhlIHdyb25nIHZhbHVlLiBzeXNfcmVnc1s0XSwgaXMgQUNUTFJfRUwx LCB3aGljaAo+Pj4gaXMgc3Vic2VxdWVudGx5IHNhdmUvcmVzdG9yZWQgd2hlbiB3ZSBlbnRlciB0 aGUgZ3Vlc3QuCj4gCj4+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYyBi L2FyY2gvYXJtNjQva3ZtL3N5c19yZWdzLmMKPj4+IGluZGV4IDUxZGI5MzQ3MDJiNi4uMmVkYTUz OWYzMjgxIDEwMDY0NAo+Pj4gLS0tIGEvYXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYwo+Pj4gKysr IGIvYXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYwo+Pj4gQEAgLTIwNjAsNyArMjA2MCw3IEBAIHN0 YXRpYyBjb25zdCBzdHJ1Y3Qgc3lzX3JlZ19kZXNjIGNwMTVfcmVnc1tdID0gCj4+PiB7Cj4+PiAK Pj4+IMKgwqDCoMKgIHsgT3AxKDEpLCBDUm4oIDApLCBDUm0oIDApLCBPcDIoMCksIGFjY2Vzc19j Y3NpZHIgfSwKPj4+IMKgwqDCoMKgIHsgT3AxKDEpLCBDUm4oIDApLCBDUm0oIDApLCBPcDIoMSks IGFjY2Vzc19jbGlkciB9LAo+Pj4gLcKgwqDCoCB7IE9wMSgyKSwgQ1JuKCAwKSwgQ1JtKCAwKSwg T3AyKDApLCBhY2Nlc3NfY3NzZWxyLCBOVUxMLCAKPj4+IGMwX0NTU0VMUiB9LAo+Pj4gK8KgwqDC oCB7IE9wMSgyKSwgQ1JuKCAwKSwgQ1JtKCAwKSwgT3AyKDApLCBhY2Nlc3NfY3NzZWxyX2VsMSwg TlVMTCwgCj4+PiBDU1NFTFJfRUwxIH0sCj4+PiDCoH07Cj4gCj4+IFRoaXMgaXMgYSBkZXBhcnR1 cmUgZnJvbSB0aGUgd2F5IHdlIGRlYWwgd2l0aCAzMmJpdCBDUDE1IHJlZ2lzdGVycy4KPj4gV2Ug ZGVhbCB3aXRoIHRoaXMgZXhhY3QgaXNzdWUgaW4gYSB2ZXJ5IGRpZmZlcmVudCB3YXkgZm9yIG90 aGVyCj4+IENQMTUgcmVncywgYnkgYWRqdXN0aW5nIHRoZSBpbmRleCBpbiB0aGUgc3lzX3JlZ3Mg YXJyYXkgKHNlZSB0aGUKPj4gd2F5IHdlIGhhbmRsZSB0aGUgVk0gcmVncykuCj4+IAo+PiBIb3cg YWJvdXQgc29tZXRoaW5nIGxpa2UgdGhpcyAodW50ZXN0ZWQpOgo+IAo+IFtsaWtlIGFjY2Vzc192 bV9yZWcoKSBkb2VzXQo+IAo+IFN1cmUsIEknbGwgZ2l2ZSB0aGF0IGEgdGVzdCBhbmQgcmUtcG9z dCBpdC4KClRoYW5rcyEKCj4gCj4gCj4+IElkZWFsbHksIEknZCBsaWtlIHRoZSBjb3JlIHN5c19y ZWcgY29kZSB0byBkZWFsIHdpdGggdGhpcyBzb3J0Cj4+IG9mIGZ1bm5pZXMsIGJ1dCBJJ20gdHJ5 aW5nIHRvIGtlZXAgdGhlIGNoYW5nZSBtaW5pbWFsLi4uCj4gCj4gUm9sbCB0aGlzICcvMicgYW5k IHVwcGVyL2xvd2VyIGJpdHMgc3R1ZmYgaW50byBhIHZjcHVfd3JpdGVfY3AxNV9yZWcoKQo+IHRo YXQgY2FsbHMKPiB2Y3B1X3dyaXRlX3N5c19yZWcoKT8gKC9tZSBodW50cyBvdXQgdGhlIHRvZG8g bGlzdCkKCkkgd2FzIHRoaW5raW5nIG9mIGhpZGluZyBpdCBkaWZmZXJlbnRseTogaW4gZW11bGF0 ZV9jcCwgc3Vic3RpdHV0ZSB0aGUKc3lzX3JlZ19kZXNjIHN0cnVjdHVyZSBmb3IgYSB0ZW1wb3Jh cnkgb25lIHRoYXQgcmVwcmVzZW50cyB0aGUgNjRiaXQKdmVyc2lvbiwgYW5kIG1ha2UgaXQgY29t cGxldGVseSB0cmFuc3BhcmVudC4KCkknbSBzdXJlIHRoZXJlIGlzIGEgY291cGxlIG9mIG5pdHMg YXJvdW5kIHRoYXQgdGhvdWdoLi4uCgogICAgICAgICBNLgotLSAKSmF6eiBpcyBub3QgZGVhZC4g SXQganVzdCBzbWVsbHMgZnVubnkuLi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6B7FC433E1 for ; Thu, 28 May 2020 12:10:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7C0A2063A for ; Thu, 28 May 2020 12:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590667828; bh=d+BX6Yu8bblCkc+YNytpyy6IyNc3spMni5yB2tDpCBo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=qNhYBhxHxVeygE+xi0tW9L9tk4cCgC/STM7glQJJ63n7CVl/YtcjaUAmXJwGstzNY TtJnZulJN4bj6pxor1IAb7ELgzAczft2Qbwwj0962pf5WBLKGYNkr17ZDpNEaWwoAy 7uK9u70j7HJCYab5NkKVfxl0KE1LisyAcT1MoK8o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388686AbgE1MK1 (ORCPT ); Thu, 28 May 2020 08:10:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:33144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389705AbgE1MKZ (ORCPT ); Thu, 28 May 2020 08:10:25 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A250C2063A; Thu, 28 May 2020 12:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590667824; bh=d+BX6Yu8bblCkc+YNytpyy6IyNc3spMni5yB2tDpCBo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ht9aeBKOOs2qT1O/Jvk9zPAOcwXArR2X6BqtFlTRNkhygdQL6r7LWzmyaWb1t3W8h UqL6mOfc0/m5+zw2y/OBxfwIasqR7K5PEpKjOHGYp4+m2sY25Oc9jSCCDK8KjpZOvF ib1gW6SFhgUu7PfBzWBFDbczaL8jB4B44mtPq0fU= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jeHMd-00Fyr7-3o; Thu, 28 May 2020 13:10:23 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 28 May 2020 13:10:23 +0100 From: Marc Zyngier To: James Morse Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Julien Thierry , Suzuki K Poulose , stable@vger.kernel.org Subject: Re: [PATCH 1/3] KVM: arm64: Stop writing aarch32's CSSELR into ACTLR In-Reply-To: <09dca8e9-c548-43fd-a95b-747a77f19e02@arm.com> References: <20200526161834.29165-1-james.morse@arm.com> <20200526161834.29165-2-james.morse@arm.com> <4be0c0b654f7d7c1efe9f52efb856bd8@kernel.org> <09dca8e9-c548-43fd-a95b-747a77f19e02@arm.com> User-Agent: Roundcube Webmail/1.4.4 Message-ID: <705687e37c5d5339a6baafa9e31675cb@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: james.morse@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 2020-05-28 12:59, James Morse wrote: > Hi Marc, > > On 28/05/2020 09:57, Marc Zyngier wrote: >> On 2020-05-26 17:18, James Morse wrote: >>> access_csselr() uses the 32bit r->reg value to access the 64bit >>> array, >>> so reads and write the wrong value. sys_regs[4], is ACTLR_EL1, which >>> is subsequently save/restored when we enter the guest. > >>> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c >>> index 51db934702b6..2eda539f3281 100644 >>> --- a/arch/arm64/kvm/sys_regs.c >>> +++ b/arch/arm64/kvm/sys_regs.c >>> @@ -2060,7 +2060,7 @@ static const struct sys_reg_desc cp15_regs[] = >>> { >>> >>>      { Op1(1), CRn( 0), CRm( 0), Op2(0), access_ccsidr }, >>>      { Op1(1), CRn( 0), CRm( 0), Op2(1), access_clidr }, >>> -    { Op1(2), CRn( 0), CRm( 0), Op2(0), access_csselr, NULL, >>> c0_CSSELR }, >>> +    { Op1(2), CRn( 0), CRm( 0), Op2(0), access_csselr_el1, NULL, >>> CSSELR_EL1 }, >>>  }; > >> This is a departure from the way we deal with 32bit CP15 registers. >> We deal with this exact issue in a very different way for other >> CP15 regs, by adjusting the index in the sys_regs array (see the >> way we handle the VM regs). >> >> How about something like this (untested): > > [like access_vm_reg() does] > > Sure, I'll give that a test and re-post it. Thanks! > > >> Ideally, I'd like the core sys_reg code to deal with this sort >> of funnies, but I'm trying to keep the change minimal... > > Roll this '/2' and upper/lower bits stuff into a vcpu_write_cp15_reg() > that calls > vcpu_write_sys_reg()? (/me hunts out the todo list) I was thinking of hiding it differently: in emulate_cp, substitute the sys_reg_desc structure for a temporary one that represents the 64bit version, and make it completely transparent. I'm sure there is a couple of nits around that though... M. -- Jazz is not dead. It just smells funny...