All of lore.kernel.org
 help / color / mirror / Atom feed
From: Parvathi Pudi <parvathi@couthit.com>
To: nm <nm@ti.com>, Kevin Hilman <khilman@baylibre.com>
Cc: basharath <basharath@couthit.com>, ssantosh <ssantosh@kernel.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 pratheesh <pratheesh@ti.com>, Prajith Jayarajan <prajith@ti.com>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 danishanwar <danishanwar@ti.com>, praneeth <praneeth@ti.com>,
	 srk <srk@ti.com>, rogerq <rogerq@ti.com>, afd <afd@ti.com>,
	 krishna <krishna@couthit.com>, pmohan <pmohan@couthit.com>,
	 mohan <mohan@couthit.com>, parvathi <parvathi@couthit.com>
Subject: Re: [PATCH v2 1/1] soc: ti: PRUSS OCP configuration
Date: Wed, 2 Apr 2025 17:19:19 +0530 (IST)	[thread overview]
Message-ID: <706306271.973226.1743594559548.JavaMail.zimbra@couthit.local> (raw)
In-Reply-To: <1365068627.843903.1742210370862.JavaMail.zimbra@couthit.local>

Hi Nishanth,
 
>> On 18:29-20250108, Basharath Hussain Khaja wrote:
>>> From: Roger Quadros <rogerq@ti.com>
>>> 
>>> Updates OCP master port configuration to enable memory access outside
>>> of the PRU-ICSS subsystem.
>>> 
>>> This set of changes configures PRUSS_SYSCFG.STANDBY_INIT bit either
>>> to enable or disable the OCP master ports (applicable only on SoCs
>>> using OCP interconnect like the OMAP family).
>>> 
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>>> Signed-off-by: Parvathi Pudi <parvathi@couthit.com>
>>> Signed-off-by: Basharath Hussain Khaja <basharath@couthit.com>
>> 
>> On the verge of applying this patch, looking deeper, I noticed
>> drivers/bus/ti-sysc.c managing the sysc controls. infact, I wonder if
>> b2745d92bb015cc4454d4195c4ce6e2852db397e ("bus: ti-sysc: Add support
>> for PRUSS SYSC type") could be merged with this?
>> 
>> 
>> Could you say why drivers/bus/ti-sysc.c would'nt be the right solution?
>> 
>> Ccying Kevin if he has any ideas about this.
>> 
> 
> Thank you for the feedback.
> 
> We will analyze ti-sysc and revert back with an update shortly.
> 

We've reviewed the code and decided to bypass the SOC patch posted here.
Instead, we have implemented the required changes in the "drivers/bus/ti-sysc.c"
file to enable OCMC access to the PRU-ICSS and verified the Ethernet
functionality over PRUETH on AM335x, AM437x and AM57x platforms.

This patch will be abandoned and a new patch will be posted with
"drivers/bus/ti-sysc.c" changes shortly.


Thanks and Regards,
Parvathi.


  reply	other threads:[~2025-04-02 11:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08 12:59 [PATCH v2 0/1] Add AM57xx Support to PRUSS driver Basharath Hussain Khaja
2025-01-08 12:59 ` [PATCH v2 1/1] soc: ti: PRUSS OCP configuration Basharath Hussain Khaja
2025-03-07 21:05   ` Nishanth Menon
2025-03-17 11:19     ` Parvathi Pudi
2025-04-02 11:49       ` Parvathi Pudi [this message]
2025-04-02 12:05         ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=706306271.973226.1743594559548.JavaMail.zimbra@couthit.local \
    --to=parvathi@couthit.com \
    --cc=afd@ti.com \
    --cc=basharath@couthit.com \
    --cc=danishanwar@ti.com \
    --cc=khilman@baylibre.com \
    --cc=krishna@couthit.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mohan@couthit.com \
    --cc=nm@ti.com \
    --cc=pmohan@couthit.com \
    --cc=prajith@ti.com \
    --cc=praneeth@ti.com \
    --cc=pratheesh@ti.com \
    --cc=rogerq@ti.com \
    --cc=srk@ti.com \
    --cc=ssantosh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.