From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"techboard@dpdk.org" <techboard@dpdk.org>
Subject: RE: [PATCH] doc: announce changes in structure alignments for UBSan
Date: Thu, 10 Jul 2025 08:24:13 +0000 [thread overview]
Message-ID: <70844e94235d40f09a375e10b2d50a35@huawei.com> (raw)
In-Reply-To: <20250709124022.4105481-1-david.marchand@redhat.com>
> As part of the effort to limit undefined behaviors in DPDK code, some
> structure alignments revealed not to be accurate enough.
> At the moment two structures have been identified but others may be
> found while running more parts of DPDK with UBSan.
>
> Though the calling code can explicitly request alignment,
> we would prefer to put the alignment constraints as part of the
> structure definition itself.
>
> Such changes are ABI breakages.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index e2d4125308..4ae561d670 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -57,6 +57,10 @@ Deprecation Notices
> ``__atomic_thread_fence`` must be used for patches that need to be merged in
> 20.08 onwards. This change will not introduce any performance degradation.
>
> +* lib: multiple issues relating to unaligned accesses have been detected using the UBSan checker.
> + As part of resolving those issues, alignment in some structures will be updated in 25.11,
> + namely (but not exhaustively): ``struct rte_stack_lf_head`` and ``struct rte_mp_msg``.
> +
> * lib: will fix extending some enum/define breaking the ABI. There are multiple
> samples in DPDK that enum/define terminated with a ``.*MAX.*`` value which is
> used by iterators, and arrays holding these values are sized with this
> --
> 2.50.0
Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
next prev parent reply other threads:[~2025-07-10 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 12:40 [PATCH] doc: announce changes in structure alignments for UBSan David Marchand
2025-07-09 12:49 ` Bruce Richardson
2025-07-09 12:58 ` Morten Brørup
2025-07-10 8:24 ` Konstantin Ananyev [this message]
2025-07-21 20:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70844e94235d40f09a375e10b2d50a35@huawei.com \
--to=konstantin.ananyev@huawei.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.