From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: "Goswami, Sanket" <Sanket.Goswami@amd.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>,
Narasimhan.V@amd.com, Borislav Petkov <bp@alien8.de>,
Kim Phillips <kim.phillips@amd.com>,
Shyam-sundar.S-k@amd.com
Subject: Re: [PATCH v2 1/1] i2c: designware: Consolidate PM ops
Date: Fri, 30 Aug 2024 08:32:09 +0300 [thread overview]
Message-ID: <708aabde-58fb-48ea-80af-bcbf60d95a81@linux.intel.com> (raw)
In-Reply-To: <9d424592-c157-417a-9d6e-d12d80e19829@amd.com>
On 8/29/24 5:55 PM, Goswami, Sanket wrote:
> Adding Shyam (as he asked me to check this change on AMD systems)
>
> On 8/27/2024 8:30 PM, Andy Shevchenko wrote:
>> We have the same (*) PM ops in the PCI and plaform drivers.
>> Instead, consolidate that PM ops under exported variable and
>> deduplicate them.
>>
>> *)
>> With the subtle ACPI and P-Unit behaviour differences in PCI case.
>> But this is not a problem as for ACPI we need to take care of the
>> P-Unit semaphore anyway and calling PM ops for PCI makes sense as
>> it might provide specific operation regions in ACPI (however there
>> are no known devices on market that are using it with PCI enabled I2C).
>> Note, the clocks are not in use in the PCI case.
>>
>> Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Tested-by: Sanket Goswami <Sanket.Goswami@amd.com>
>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2024-08-30 5:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 15:00 [PATCH v2 1/1] i2c: designware: Consolidate PM ops Andy Shevchenko
2024-08-29 14:55 ` Goswami, Sanket
2024-08-30 5:32 ` Jarkko Nikula [this message]
2024-08-30 18:36 ` Andy Shevchenko
2024-09-03 14:30 ` Andi Shyti
2024-09-03 15:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=708aabde-58fb-48ea-80af-bcbf60d95a81@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=Narasimhan.V@amd.com \
--cc=Sanket.Goswami@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=jsd@semihalf.com \
--cc=kim.phillips@amd.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.