From: Krzysztof Kozlowski <krzk@kernel.org>
To: Paul Handrigan <paulha@opensource.cirrus.com>,
broonie@kernel.org, lgirdwood@gmail.com,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: cirrus,cs530x: Add initial DT binding
Date: Sat, 15 Jun 2024 11:51:06 +0200 [thread overview]
Message-ID: <709292bc-e4ce-47e8-a8fc-2c91f72fdb8e@kernel.org> (raw)
In-Reply-To: <20240614183632.861575-1-paulha@opensource.cirrus.com>
On 14/06/2024 20:36, Paul Handrigan wrote:
> Add the YAML DT bindings for the cs530x high performance
> audio ADCs.
>
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cs5304: cs5304@48 {
What happened here? This was different.
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
audio-codec? audio-adc? adc?
Best regards,
Krzysztof
prev parent reply other threads:[~2024-06-15 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 18:36 [PATCH v2 1/2] ASoC: dt-bindings: cirrus,cs530x: Add initial DT binding Paul Handrigan
2024-06-14 18:36 ` [PATCH v2 2/2] ASoC: cs530x: Support for cs530x ADCs Paul Handrigan
2024-06-15 9:57 ` Krzysztof Kozlowski
2024-06-15 9:51 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=709292bc-e4ce-47e8-a8fc-2c91f72fdb8e@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=paulha@opensource.cirrus.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.