From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id A3E13B7E59 for ; Wed, 19 Aug 2009 19:38:46 +1000 (EST) Received: from mx2.redhat.com (unknown [66.187.237.31]) by ozlabs.org (Postfix) with ESMTP id 3331DDDD1B for ; Wed, 19 Aug 2009 19:38:45 +1000 (EST) From: David Howells In-Reply-To: References: To: Thomas Gleixner Subject: Re: spin_is_locked() broken for uniprocessor? Date: Wed, 19 Aug 2009 10:38:06 +0100 Message-ID: <7099.1250674686@redhat.com> Sender: dhowells@redhat.com Cc: Peter Zijlstra , Steven Rostedt , Linux-Kernel List , linuxppc-dev list , Ingo Molnar List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Thomas Gleixner wrote: > > which implies to me that spin_is_locked() will always return false. Is this > > expected behavior. > > That's wrong. spin_is_locked should always return true on UP. Surely it's not that simple? Maybe spin_is_lock() should be undefined on UP. David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751518AbZHSJit (ORCPT ); Wed, 19 Aug 2009 05:38:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751441AbZHSJir (ORCPT ); Wed, 19 Aug 2009 05:38:47 -0400 Received: from mx2.redhat.com ([66.187.237.31]:48983 "EHLO mx2.redhat.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751439AbZHSJio (ORCPT ); Wed, 19 Aug 2009 05:38:44 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: To: Thomas Gleixner Cc: dhowells@redhat.com, Kumar Gala , Peter Zijlstra , Linux-Kernel List , Steven Rostedt , linuxppc-dev list , Ingo Molnar Subject: Re: spin_is_locked() broken for uniprocessor? Date: Wed, 19 Aug 2009 10:38:06 +0100 Message-ID: <7099.1250674686@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thomas Gleixner wrote: > > which implies to me that spin_is_locked() will always return false. Is this > > expected behavior. > > That's wrong. spin_is_locked should always return true on UP. Surely it's not that simple? Maybe spin_is_lock() should be undefined on UP. David