From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B7C0C982D2 for ; Thu, 17 Sep 2026 07:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C6qX4ApRGScG9KTQXUmC7XfvGp9lT5GXJMi7q4w0B0M=; b=10ds1qiBbmMyrc iSH7+A6c1ZQx+nnhb2ClgqDqn2U2Axx6kLCy7EHKwHkmSI0Fch8WOZM/XpvQ64VAbB6QafVmbmou2 wW9QifUM1+fjD8xjNQvB4ry9HUzve6uiZT402h8oWmJNaVXS4EqGi/hvY3LHS94Nl2xI2hrdt8CfS VwShNOMB+Vbu0eHkDnytuV7H3/ftLaBndku4Wvhb5dysqp2EaB97vDcZdRP5z1w4h7iXG2Njd4cyP pDvopG5ifBUP0d+mbFh/06G0Y18ih0BHmesifCcZ1u/DTlazKWg4RMFpeNJxV4EB3DWQPDAcs+9dN 6X0qIdozgfCGM3CYaxJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x76Mw-0000000Akd5-2YqR; Thu, 17 Sep 2026 07:17:18 +0000 Received: from mail-wm2-x10.google.com ([2a00:1450:4864:31::10]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x76Mr-0000000AkaD-11sE for linux-mtd@lists.infradead.org; Thu, 17 Sep 2026 07:17:14 +0000 Received: by mail-wm2-x10.google.com with SMTP id 5b1f17b1804b1-49e66390995so2433275e9.2 for ; Thu, 17 Sep 2026 00:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789629431; x=1790234231; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6sjRq5JwkomwjePlQI1kfNhFczaltRdPXNsYjKkX5UM=; b=bQVDISv3Ld4g72+2uP9zNSEHyvha/cQ++KDOTNXu0TbcSR34MtVwUMYNVIcCRFQ6QA 2j4DfOutr8TdvohiUcTNPBflb+SCnnLZiQrrbZPHuvrTDmdKVZV7jtKNH5OvRmsge4xB JERkV37plHzO3TXWWnQlWyrtMKGp1bpbpZVdz0QiY5/Gwi1YwtcxRYgHLgTBl+XC9eww bq2KdkCoAjT/WXONMn4zLcqvjsbkjb4yxIuR1+6bddqiNlE0zRvKVxjmW7QezTi8A44l 4Yz8yd0nSPzeOo84ItepEEp0CwRmFDS4CLDIbe1Nin1B1eYHSDABqT331h1eAknp6STq YzFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789629431; x=1790234231; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6sjRq5JwkomwjePlQI1kfNhFczaltRdPXNsYjKkX5UM=; b=eNCyQumR59jJ73lbkxM6KTICyH0aI32KS/GIAGGS9Oh+N+NtfnEUlbqiHlCEMF4pxz aHngBsh5EWEmYPEgrkVniJn3gh84cD2f5YUJCXoe5Zp5WyIboWq5XZzfEwtih+KKpiwS zhErp7hwCioC/tCUJFfgNgnBXJIlr7QkGkvYjYgk4NdTCyMZ6W5RVgk8rtTXWe9eJw3/ siAZGSKcg2A8kBrSobYnyuotag+Kx3SyZR9xoT3WzIGfTUikRuIJOl+BPiAKyu/n7/z1 9hfRytkr6QXgQb9voQqWA/iSci+ivFOMwIkrH5/q6snlqoqsd48jvOm2FQ2hGQj9O6T1 3asQ== X-Forwarded-Encrypted: i=1; AKwUvBynNGoKBm8wA/vVa4hJ2aIIpVCmv4yi3hBRBqzH3803TMSAzwBgNS+KRE3wW3HeCWZ2eF7rCNqIU9Y=@lists.infradead.org X-Gm-Message-State: AFuF++m0GayXTPlArRwoyC2vzowRXNKwCDFOx+b2A3MEQNLBJ3yBD81i jxwZC5Ezp0svZgpnigKHRMLMBlhseoD3mu68mr6s0ysS1xu3CA2cxfn7 X-Gm-Gg: AYBFou3WWIF4r8w2gtRis/zp3CSPd9YIxhg2UZ1VVREmyK93VFuqR4thSrQw7Lg/O4p 5P/ltzdk4gEyJVEfgEI4Btih3qjnmyYQG/YCb83p7kXPhDUSq0Lc+i+tUZziYRfdpbfVsaxXeSm fhkp+zydy23eUeTZhcelSfqGpBvpVRephzKi24/PFdk25f7Qg7Dz18xBcPF+gmZlBZmynmCTm8J lTYfWBy2IpxsxE931MrpMfhUxjREAoANnLqY2h+sJMh7t+4ShUq0moS6UdOfseOYEGCbW2z1DYP TdFEAcs/nmRDvQYVHjjazt+/u01VJGxFExISI8Ij92hQIKUBDhz6TeovEBl06csil5qv/GeY0Y0 /9Dlkt8sU9qLrzNWPuRX3oQSXKtHrlLG8o3otRo+Ue5jTBrKhG1QLVV1N8+WEIV0MrzYg6qOMBl i6RTbcTZ6Wy34BgE/xBe8b7RNhb72zcmJbL+6FanvAu+s4rXoWWeegYsqS33eOr/130fIviz8se /f5fFw7ITvAMjvKZq3yM9vPp0srTTkV/gf/X08= X-Received: by 2002:a05:600c:4ec6:b0:49c:fea3:8633 with SMTP id 5b1f17b1804b1-49eb732aec0mr62000005e9.24.1789629430773; Thu, 17 Sep 2026 00:17:10 -0700 (PDT) Received: from [192.168.20.170] (5403F394.catv.pool.telekom.hu. [84.3.243.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fbd1ce79csm59310085e9.0.2026.09.17.00.17.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Sep 2026 00:17:10 -0700 (PDT) Message-ID: <70d620e5-b03a-48ff-9b56-e787d03b4aed@gmail.com> Date: Thu, 17 Sep 2026 09:17:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] spi: spi-qpic-snand: drop the redundant ECC context handling To: Johan Alvarado , broonie@kernel.org, md.alam@oss.qualcomm.com Cc: konradybcio@kernel.org, pengpeng@iscas.ac.cn, miquel.raynal@bootlin.com, quic_varada@quicinc.com, quic_srichara@quicinc.com, linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260911184416.109790-1-contact@c127.dev> <20260911184416.109790-3-contact@c127.dev> Content-Language: hu From: Gabor Juhos In-Reply-To: <20260911184416.109790-3-contact@c127.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260917_001713_303762_C05D94C2 X-CRM114-Status: GOOD ( 12.71 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org MjAyNi4gMDkuIDExLiAyMDo0NCBrZWx0ZXrDqXNzZWwsIEpvaGFuIEFsdmFyYWRvIMOtcnRhOgo+ IHFjb21fc3BpX2VjY19pbml0X2N0eF9waXBlbGluZWQoKSBub3cgcHVibGlzaGVzIHRoZSBFQ0Mg Y29udGV4dCB0bwo+IHNuYW5kYy0+cXNwaS0+ZWNjLCBzbyB0aGUgYXNzaWdubWVudCBpbgo+IHFj b21fc3BpX2VjY19wcmVwYXJlX2lvX3JlcV9waXBlbGluZWQoKSByZXBlYXRzIHdoYXQgdGhlIHBv aW50ZXIgYWxyZWFkeQo+IGhvbGRzLCBhbmQgdGhlIHplcm9lZCBzdHJ1Y3QgcXBpY19lY2MgdGhh dCBxY29tX3NwaV9wcm9iZSgpIGFsbG9jYXRlcyBpcwo+IG5ldmVyIHJlYWQuCj4gCj4gVGhlIHBv aW50ZXIgaXMgbm9uLU5VTEwgb25seSBiZXR3ZWVuIGNvbnRleHQgY3JlYXRpb24gYW5kIGRlc3Ry dWN0aW9uLAo+IGFuZCBldmVyeSByZWFkZXIgcnVucyBpbnNpZGUgdGhhdCB3aW5kb3cuIFRoZSBv b2JsYXlvdXQgY2FsbGJhY2tzIGFyZQo+IGluc3RhbGxlZCBieSBpbml0X2N0eC4gVGhlIHBhZ2Ug cmVhZCwgd3JpdGUgYW5kIHByb2dyYW0gaGVscGVycyBydW4gb25seQo+IHdoZW4gcHJlcGFyZV9p b19yZXEgaGFzIHNldCBwYWdlX3J3IG9yIG9vYl9ydy4gcWNvbV9zcGlfYmxvY2tfZXJhc2UoKQo+ IHJ1bnMgb25seSB3aGlsZSB0aGUgbXRkIGlzIHJlZ2lzdGVyZWQsIHdoaWNoIGhhcHBlbnMgYWZ0 ZXIgaW5pdF9jdHggYW5kCj4gZW5kcyBiZWZvcmUgY2xlYW51cF9jdHguIFRoZSBjb250cm9sbGVy IGRyaXZlcyBhIHNpbmdsZSBjaGlwIHNlbGVjdCwgc28KPiB0aGUgcGVyLWNvbnRyb2xsZXIgcG9p bnRlciBhbmQgdGhlIHBlci1jaGlwIGNvbnRleHQgY2Fubm90IGRpc2FncmVlLgo+IAo+IFJlbW92 ZSBib3RoLiBObyBmdW5jdGlvbmFsIGNoYW5nZS4KPiAKPiBTdWdnZXN0ZWQtYnk6IEdhYm9yIEp1 aG9zIDxqNGc4eTdAZ21haWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEpvaGFuIEFsdmFyYWRvIDxj b250YWN0QGMxMjcuZGV2Pgo+IC0tLQo+IFRlc3RlZCBvbiBhIE1lcmN1c3lzIE1SODBYIChJUFE1 MDE4LCBFU01UIEY1MEQxRzQxTEIpIHdpdGggYm90aCBwYXRjaGVzCj4gYmFja3BvcnRlZCB0byA2 LjE4LjQ0LiBGaXZlIGJvb3RzLCByb290ZnMgbW91bnRlZCBldmVyeSB0aW1lLCBtdGQKPiByZXBv cnRlZCAwIEVDQyBmYWlsdXJlcyBhbmQgMCBjb3JyZWN0ZWQgYml0cywgYW5kIGEgNCBNaUIgZmls ZSBvbiB0aGUKPiBVQklGUyBvdmVybGF5IGtlcHQgaXRzIHNoYTI1NiBhY3Jvc3MgdGhlIHJlYm9v dHMuIE92ZXJsYXkgY2h1cm4gcmFpc2VkCj4gdGhlIFVCSSBtYXhpbXVtIGVyYXNlIGNvdW50ZXIg ZnJvbSAxMyB0byAxNSwgc28gcWNvbV9zcGlfYmxvY2tfZXJhc2UoKQo+IHJhbiByZXBlYXRlZGx5 LiBCdWlsZC10ZXN0ZWQgb24gdGhpcyBiYXNlIHdpdGggVz0xIGFuZCBzcGFyc2UsIG5vCj4gd2Fy bmluZ3MsIHBhdGNoIDEgYWxvbmUgYW5kIGJvdGggcGF0Y2hlcyBhcHBsaWVkLgoKVGVzdGVkIG9u IFRwLUxpbmsgQXJjaGVyIEFYNTUgdjEgYnVpbHQgb24gdG9wIG9mIDk4MTAwZDgzYWRjOCAoIk1l cmdlCnJlbW90ZS10cmFja2luZyBicmFuY2ggJ3NwaS9mb3ItNy40JyBpbnRvIHNwaS1uZXh0Iiku IE5vIHJlZ3Jlc3Npb25zIG9ic2VydmVkLgoKVGVzdGVkLWJ5OiBHYWJvciBKdWhvcyA8ajRnOHk3 QGdtYWlsLmNvbT4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA9D5478E2B for ; Thu, 17 Sep 2026 07:17:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789629434; cv=none; b=C4ETh/lZvaND1icVSc5jayYGbqwTEF+PSC2gBhBZBF1q1VvUgw9016rSnrHQVE7VH8YdZO0T2Rzg1tGwUMN8KX39sKEazUM82y059gOCgIj7SOBjo4LAUnxJum+j4eajOPvRphrQkJ8bHhhQnoPr8eOEVqzSEYc55yP+zKTnu4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789629434; c=relaxed/simple; bh=gbriEj1Y6woab39WAV/2YSR43SgslkII3LkrcHz7PIE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XPVn7MlppL0mkEVyMQUa4jPgwY+4nr10X/phTON0cBpD+91wBpmEXYb8SfYmKzNgV0Oeo+8mTCt5ViCQB3Q1bG3D3VTNbOi+oNV1rARSocck5VMsEAJqcpUxNovf/wcSgkc3edVXPuAB8W8hmxXpRPFSeOdxviAhoSGNQ0twk0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gx8qIRON; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gx8qIRON" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49e620fa473so2738805e9.1 for ; Thu, 17 Sep 2026 00:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789629431; x=1790234231; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6sjRq5JwkomwjePlQI1kfNhFczaltRdPXNsYjKkX5UM=; b=Gx8qIRONf1BkHfTUtSJYYSQDiccQNhmUGB8h3LIbYXB+lnl8/h6ubjVOXCjJKpzOmD 7gHZux9SbCqq/7rZSRLdWGq9Xx+uDkUTU5ySdrLOH2JfjV8aT/E0Vu06QuLSTot/ikpg A1SZ9yQ79EULxdpXfMVOHcxAUyVSIzH5zGpOOrkO70rR0lbdfTBmgDMRii/6nMmwV4zB 0zQc+wFKYGbGsYtepNIIdNXY5e26TK83AbR7KrNiNoKUFVe4oZ9FHhPuraOUYBQNh2x6 UZgqIs8AxUBYIIB5DDBqGY7+UHC3bAz8Op+W51bdTAFCriIuM+8VVi529CvCJIXfDuIl LBpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789629431; x=1790234231; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6sjRq5JwkomwjePlQI1kfNhFczaltRdPXNsYjKkX5UM=; b=RcW8uknTPwO+08Te13QfPKJ5AcusFvOPAU2PxS7Kigb7/661nMSmTU3zgYMThrHsm/ n7YxK4dkooF4RM8PzDGS8v7fajm24qV95k+kyNiLiBgB7Q6AVVebPtr07bkx/SdxPxh2 S0+P6mpRgv1H7fWUcoae02mrPCputOMt1iXfwZASfqMLG2HnACH2bp/tjpZm4kdvsZ1n b6cNu1CGLtZSH4/Xq6PWXwcBMcqAGQOWO2WpaE0CoYC7oIaWJGRq0/U2yw0pGm7dGURQ ENT4FKi6QaaiL+ZPGlSrw4pA56DpahqMJw1SvudzQG7PEaKklLIX/sHT3mVfFkNsk8Go m6XQ== X-Forwarded-Encrypted: i=1; AKwUvBzBeSDdRUTEy6ARhCTNBreQEZj4Cts6vfoAgiZCczlefwkTD35tyJTl9ryl+4T5G/MQVzL0l56Y07U=@vger.kernel.org X-Gm-Message-State: AFuF++kjj3iTdiO+vvzzoF9iRX6Y0Txhu8JtQee3sSQkKvrq2R1Mzsv8 7Xkgk231St4RBnM2P0fT6CPYTFtFHX566GC/TP4nrOIrsi0CsknQIJ9W X-Gm-Gg: AYBFou1sPfizHKSxUoBKOIHl265Cc6zvSQf9AYGxmMTk8H6eyi3P/9SVAqQ7gf11XlG VboES8Ut/8JBCZnLyQ0wpDi+FgmGZWOJt1rRFUvAoq0LPUqU/ot5TCaE0xJS90WfxIeSbQhfv6A DFolPCYPdyd75ejgoDqJEBWCjF9Lt4yt2styjOI957eqHyn+9C8Blp9ClfGmoughJ0GEGWvu3f1 fX3++kYU7UnTqr8r5Cta1aOuDWeaBu9F5Rm0H/3cOHGaHfT1nSf53aTFzFsUOs0mMqMSpbx7pDU i1+DOV2H1ic3CSqwpj8aOiggaM5m+y4MdhahIPBegJp+yMhXaxQKrBI7yLoNeEloDqZPoth7uiQ UX1u3abJKdrH8yN0Ap8w7jtEBDaiPmjATckrlQuGI3iM9DkrM4ZNYxlDRxTSyAMrTyyJOSi8tcH Yioi6ZuCPXa4N8XuCfOXMmJWCyNhdf273/iPAk+GJhGQd0pZHQxurlg+x9wiHrG3iCLHvf9pkzI 31EkVh5wEwQ3pxuwQU6ZkLrZgyYZLd3ga0ozTc= X-Received: by 2002:a05:600c:4ec6:b0:49c:fea3:8633 with SMTP id 5b1f17b1804b1-49eb732aec0mr62000005e9.24.1789629430773; Thu, 17 Sep 2026 00:17:10 -0700 (PDT) Received: from [192.168.20.170] (5403F394.catv.pool.telekom.hu. [84.3.243.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fbd1ce79csm59310085e9.0.2026.09.17.00.17.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Sep 2026 00:17:10 -0700 (PDT) Message-ID: <70d620e5-b03a-48ff-9b56-e787d03b4aed@gmail.com> Date: Thu, 17 Sep 2026 09:17:07 +0200 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] spi: spi-qpic-snand: drop the redundant ECC context handling To: Johan Alvarado , broonie@kernel.org, md.alam@oss.qualcomm.com Cc: konradybcio@kernel.org, pengpeng@iscas.ac.cn, miquel.raynal@bootlin.com, quic_varada@quicinc.com, quic_srichara@quicinc.com, linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260911184416.109790-1-contact@c127.dev> <20260911184416.109790-3-contact@c127.dev> Content-Language: hu From: Gabor Juhos In-Reply-To: <20260911184416.109790-3-contact@c127.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 2026. 09. 11. 20:44 keltezéssel, Johan Alvarado írta: > qcom_spi_ecc_init_ctx_pipelined() now publishes the ECC context to > snandc->qspi->ecc, so the assignment in > qcom_spi_ecc_prepare_io_req_pipelined() repeats what the pointer already > holds, and the zeroed struct qpic_ecc that qcom_spi_probe() allocates is > never read. > > The pointer is non-NULL only between context creation and destruction, > and every reader runs inside that window. The ooblayout callbacks are > installed by init_ctx. The page read, write and program helpers run only > when prepare_io_req has set page_rw or oob_rw. qcom_spi_block_erase() > runs only while the mtd is registered, which happens after init_ctx and > ends before cleanup_ctx. The controller drives a single chip select, so > the per-controller pointer and the per-chip context cannot disagree. > > Remove both. No functional change. > > Suggested-by: Gabor Juhos > Signed-off-by: Johan Alvarado > --- > Tested on a Mercusys MR80X (IPQ5018, ESMT F50D1G41LB) with both patches > backported to 6.18.44. Five boots, rootfs mounted every time, mtd > reported 0 ECC failures and 0 corrected bits, and a 4 MiB file on the > UBIFS overlay kept its sha256 across the reboots. Overlay churn raised > the UBI maximum erase counter from 13 to 15, so qcom_spi_block_erase() > ran repeatedly. Build-tested on this base with W=1 and sparse, no > warnings, patch 1 alone and both patches applied. Tested on Tp-Link Archer AX55 v1 built on top of 98100d83adc8 ("Merge remote-tracking branch 'spi/for-7.4' into spi-next"). No regressions observed. Tested-by: Gabor Juhos