From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32A8CC43381 for ; Thu, 21 Feb 2019 11:23:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F33902084F for ; Thu, 21 Feb 2019 11:23:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726652AbfBULXg (ORCPT ); Thu, 21 Feb 2019 06:23:36 -0500 Received: from mga17.intel.com ([192.55.52.151]:43136 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725385AbfBULXg (ORCPT ); Thu, 21 Feb 2019 06:23:36 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Feb 2019 03:23:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,395,1544515200"; d="scan'208";a="301451530" Received: from linux.intel.com ([10.54.29.200]) by orsmga005.jf.intel.com with ESMTP; 21 Feb 2019 03:23:35 -0800 Received: from [10.125.252.152] (abudanko-mobl.ccr.corp.intel.com [10.125.252.152]) by linux.intel.com (Postfix) with ESMTP id 4698458028E; Thu, 21 Feb 2019 03:23:33 -0800 (PST) Subject: Re: [PATCH v2 2/4] perf record: implement -z= and --mmap-flush= options To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Namhyung Kim , Alexander Shishkin , Andi Kleen , linux-kernel References: <044ee2be-2e1d-e90f-7317-40083b5e716c@linux.intel.com> <2d676199-bfe0-d8e0-442e-41280046f819@linux.intel.com> <20190212130828.GD775@krava> <39a1cf8d-2496-72f6-c3a4-a4abb8008689@linux.intel.com> <20190221094749.GC10990@krava> From: Alexey Budankov Organization: Intel Corp. Message-ID: <70ea6925-adb6-4b73-2882-eb014fd3d032@linux.intel.com> Date: Thu, 21 Feb 2019 14:23:32 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190221094749.GC10990@krava> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.02.2019 12:47, Jiri Olsa wrote: > On Wed, Feb 20, 2019 at 05:15:13PM +0300, Alexey Budankov wrote: >> >> On 12.02.2019 16:08, Jiri Olsa wrote: >>> On Mon, Feb 11, 2019 at 11:22:38PM +0300, Alexey Budankov wrote: >>> >>> SNIP >>> >>>> - if (rec->opts.nr_cblocks > nr_cblocks_max) >>>> - rec->opts.nr_cblocks = nr_cblocks_max; >>>> - if (verbose > 0) >>>> - pr_info("nr_cblocks: %d\n", rec->opts.nr_cblocks); >>>> + if (rec->opts.comp_level > 22) >>>> + rec->opts.comp_level = 0; >>>> + if (record__comp_enabled(rec) && !rec->opts.nr_cblocks) { >>>> + /* >>>> + * Allocate aio.data[0] buffer for compression. >>>> + */ >>>> + rec->opts.nr_cblocks = -1; >>>> + } >>> >>> I assume you're using aio.data[0] as a buffer for non-aio case >>> as compression buffer.. if that's the case, please dont do that >>> and use separate buffer for that >> >> Do you want it to be one more field in the mmap struct or >> aio related fields still could be reworked? > > I dont like it to use aio buffers if it's generic feature, > so please add new pointer for the needed buffer Ok. Thanks, Alexey > > jirka >