From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9328C2D0DB for ; Tue, 28 Jan 2020 18:20:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48C74214AF for ; Tue, 28 Jan 2020 18:20:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="rcxiDDWn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="b2YDan7j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48C74214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8D7211616; Tue, 28 Jan 2020 19:19:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8D7211616 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1580235622; bh=z6AylaGrtdqx/oFPBrPRSbG18Ys/q37WORygNGHN510=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rcxiDDWnM19/Yr3VTIx932OcLqDVqIsy/jxi+GhXfbhbgb9TM0qzjKG0NVFP5/zmA SrSwMxJ+96dp1pkcEBTdA1bXspg4D7/jNMZvBMc54tIx76UsGz26rmIk6ZaTK8b1Td hraJIWr89MShHnvpLDtAsE/fllJM6q3nSdEoH/ek= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 10B6BF8014B; Tue, 28 Jan 2020 19:19:32 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9A29EF800FF; Tue, 28 Jan 2020 19:19:29 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C0C78F800FF for ; Tue, 28 Jan 2020 19:19:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C0C78F800FF Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="b2YDan7j" Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 28 Jan 2020 10:19:09 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Tue, 28 Jan 2020 10:19:23 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Tue, 28 Jan 2020 10:19:23 -0800 Received: from [10.21.133.51] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 28 Jan 2020 18:19:21 +0000 To: Dmitry Osipenko , Mark Brown References: <29db3df4-6f51-7c0f-1eef-90171f1d233a@codethink.co.uk> <9a5447e2-155c-7e6e-b8f1-95523c6f42c6@gmail.com> <680e2dfd-6f4f-5c96-63b7-97520961dc82@gmail.com> <0e0cd260e39ad293edb881da1c565510@codethink.co.uk> <507dcd5a-672b-61ac-aa7f-af5ff01accff@codethink.co.uk> <28cafc56-095b-68c6-638d-270608a2983f@codethink.co.uk> <3d8544be-af20-f382-85fd-32183365267b@nvidia.com> <1b3c2af4-510e-306c-749a-efffc994b20a@gmail.com> <20200128121315.GD4689@sirena.org.uk> <047c8caa-e715-5295-9794-67ff3e10cea2@gmail.com> From: Jon Hunter Message-ID: <70f344bf-f991-606c-55ab-bdadea27d233@nvidia.com> Date: Tue, 28 Jan 2020 18:19:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <047c8caa-e715-5295-9794-67ff3e10cea2@gmail.com> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1580235549; bh=haGbRhnwYfqYm8OYOnYaS4TBQKtjm+tRkVZtCR7beeg=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=b2YDan7jVhnoJbfoEICNiUrr3zwMH3xSwNsZomEUUiX4D1JJN4iAv2eZq7nNYBUb3 syMh2miFnxtG9sm7webZD9FnIkb0QRmQsEtk5eN0RqpXFcVuKh750K6u1ciC9bA0fF l+Rv/+MDSEL4JmDcG5wJ8M4zKlF9u7wcOkSRBpdh4gkk7+JMEHxXwCd1ilPQgA/q3G jXWHrK6MlXpTY7tIrWnXzFWg3JygEkcVKx6m4Z9gzP5ZP2AmfggAh4tBfIOqf7auVV PoYjZpFJCs6xPLTnIltkkS0LHVWOhSktKd/oX/n3IrcywEvNvRnqXeGmGHsTfXfJ/Q CVzELsefxq+EQ== Cc: linux-kernel@lists.codethink.co.uk, alsa-devel@alsa-project.org, Liam Girdwood , Takashi Iwai , Ben Dooks , Thierry Reding , Edward Cragg , linux-tegra@vger.kernel.org Subject: Re: [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Ck9uIDI4LzAxLzIwMjAgMTc6NDIsIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPiAyOC4wMS4yMDIw IDE1OjEzLCBNYXJrIEJyb3duINC/0LjRiNC10YI6Cj4+IE9uIE1vbiwgSmFuIDI3LCAyMDIwIGF0 IDEwOjIwOjI1UE0gKzAzMDAsIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPj4+IDI0LjAxLjIwMjAg MTk6NTAsIEpvbiBIdW50ZXIg0L/QuNGI0LXRgjoKPj4KPj4+PiAgICAgICAgICAgICAgICAgLnJh dGVzID0gU05EUlZfUENNX1JBVEVfODAwMF85NjAwMCwKPj4+PiAgICAgICAgICAgICAgICAgLmZv cm1hdHMgPSBTTkRSVl9QQ01fRk1UQklUX1MzMl9MRSB8Cj4+Pj4gLSAgICAgICAgICAgICAgICAg ICAgICAgICAgU05EUlZfUENNX0ZNVEJJVF9TMjRfTEUgfAo+Pj4+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgIFNORFJWX1BDTV9GTVRCSVRfUzI0XzNMRSB8Cj4+Cj4+PiBJdCBzaG91bGQgc29s dmUgdGhlIHByb2JsZW0gaW4gbXkgcGFydGljdWxhciBjYXNlLCBidXQgSSdtIG5vdCBzdXJlIHRo YXQKPj4+IHRoZSBzb2x1dGlvbiBpcyBjb3JyZWN0Lgo+Pgo+PiBJZiB0aGUgZm9ybWF0IGltcGxl bWVudGVkIGJ5IHRoZSBkcml2ZXIgaXMgUzI0XzNMRSB0aGUgZHJpdmVyIHNob3VsZAo+PiBhZHZl cnRpc2UgUzI0XzNMRS4KPiAKPiBJdCBzaG91bGQgYmUgUzI0X0xFLCBidXQgc2VlbXMgd2Ugc3Rp bGwgZG9uJ3Qga25vdyBmb3Igc3VyZS4KCldoeT8KCj4+PiBUaGUgdjUuNSBrZXJuZWwgaXMgcmVs ZWFzZWQgbm93IHdpdGggdGhlIGJyb2tlbiBhdWRpbyBhbmQgYXBwYXJlbnRseQo+Pj4gZ2V0dGlu ZyAyNGJpdCB0byB3b3JrIHdvbid0IGJlIHRyaXZpYWwgKGlmIHBvc3NpYmxlIGF0IGFsbCkuIEJl biwgY291bGQKPj4+IHlvdSBwbGVhc2Ugc2VuZCBhIHBhdGNoIHRvIGZpeCB2NS41IGJ5IHJlbW92 aW5nIHRoZSBTMjQgc3VwcG9ydAo+Pj4gYWR2ZXJ0aXNlbWVudCBmcm9tIHRoZSBkcml2ZXI/Cj4+ Cj4+IFdoeSBpcyB0aGF0IHRoZSBiZXN0IGZpeCByYXRoZXIgdGhhbiBqdXN0IGFkdmVydGlzaW5n IHRoZSBmb3JtYXQKPj4gaW1wbGVtZW50ZWQgYnkgdGhlIGRyaXZlcj8KPiAKPiBUaGUgY3VycmVu dGx5IHN1cHBvcnRlZCBmb3JtYXQgdGhhdCBpcyBrbm93biB0byB3b3JrIHdlbGwgaXMgUzE2X0xF Lgo+IAo+IEknbSBzdWdnZXN0aW5nIHRvIGRyb3AgdGhlIFMyNF9MRSBhbmQgUzMyX0xFIHRoYXQg d2VyZSBhZGRlZCBieSB0aGUKPiBhcHBsaWVkIHBhdGNoZXMgc2ltcGx5IGJlY2F1c2UgdGhpcyBz ZXJpZXMgd2Fzbid0IHRlc3RlZCBwcm9wZXJseSBiZWZvcmUKPiBpdCB3YXMgc2VudCBvdXQgYW5k IHR1cm5lZCBvdXQgdGhhdCBpdCBkb2Vzbid0IHdvcmsgd2VsbC4KClMzMl9MRSBzaG91bGQgYmUg ZmluZSwgaG93ZXZlciwgSSBkbyBoYXZlIHNvbWUgY29uY2VybnMgYWJvdXQgUzI0X0xFLgoKSm9u CgotLSAKbnZwdWJsaWMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KQWxzYS1kZXZlbCBtYWlsaW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3Jn Cmh0dHBzOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxzYS1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples Date: Tue, 28 Jan 2020 18:19:19 +0000 Message-ID: <70f344bf-f991-606c-55ab-bdadea27d233@nvidia.com> References: <29db3df4-6f51-7c0f-1eef-90171f1d233a@codethink.co.uk> <9a5447e2-155c-7e6e-b8f1-95523c6f42c6@gmail.com> <680e2dfd-6f4f-5c96-63b7-97520961dc82@gmail.com> <0e0cd260e39ad293edb881da1c565510@codethink.co.uk> <507dcd5a-672b-61ac-aa7f-af5ff01accff@codethink.co.uk> <28cafc56-095b-68c6-638d-270608a2983f@codethink.co.uk> <3d8544be-af20-f382-85fd-32183365267b@nvidia.com> <1b3c2af4-510e-306c-749a-efffc994b20a@gmail.com> <20200128121315.GD4689@sirena.org.uk> <047c8caa-e715-5295-9794-67ff3e10cea2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <047c8caa-e715-5295-9794-67ff3e10cea2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko , Mark Brown Cc: Ben Dooks , linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, Liam Girdwood , Takashi Iwai , Thierry Reding , Edward Cragg , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 28/01/2020 17:42, Dmitry Osipenko wrote: > 28.01.2020 15:13, Mark Brown =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> On Mon, Jan 27, 2020 at 10:20:25PM +0300, Dmitry Osipenko wrote: >>> 24.01.2020 19:50, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> >>>> .rates =3D SNDRV_PCM_RATE_8000_96000, >>>> .formats =3D SNDRV_PCM_FMTBIT_S32_LE | >>>> - SNDRV_PCM_FMTBIT_S24_LE | >>>> + SNDRV_PCM_FMTBIT_S24_3LE | >> >>> It should solve the problem in my particular case, but I'm not sure tha= t >>> the solution is correct. >> >> If the format implemented by the driver is S24_3LE the driver should >> advertise S24_3LE. >=20 > It should be S24_LE, but seems we still don't know for sure. Why? >>> The v5.5 kernel is released now with the broken audio and apparently >>> getting 24bit to work won't be trivial (if possible at all). Ben, could >>> you please send a patch to fix v5.5 by removing the S24 support >>> advertisement from the driver? >> >> Why is that the best fix rather than just advertising the format >> implemented by the driver? >=20 > The currently supported format that is known to work well is S16_LE. >=20 > I'm suggesting to drop the S24_LE and S32_LE that were added by the > applied patches simply because this series wasn't tested properly before > it was sent out and turned out that it doesn't work well. S32_LE should be fine, however, I do have some concerns about S24_LE. Jon --=20 nvpublic