From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v1 3/4] selftests/bpf: Add mptcp netlink pm subtest
Date: Fri, 21 Mar 2025 12:21:09 +0100 [thread overview]
Message-ID: <71091cdf-6fa7-4816-9d67-e80273a94fb1@kernel.org> (raw)
In-Reply-To: <64d988e6d362e91e764ff235e45b28ba5e39ff4e.1742521587.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 21/03/2025 02:49, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> To verify that the behavior of BPF path manager is the same as that of
> netlink pm in the kernel, a netlink pm self-test has been added. BPF
> path manager in the next commit will also use this test too.
I didn't check the modifications yet, but that feels complex and long.
To me, it is a good idea to create an BPF PM imitating the in-kernel PM,
but: no netlink should be involved: limits, endpoints, dump, etc.
Instead, the configurations should be done with BPF (hardcoded in the
program, maps, bss, etc.), which means probably duplicating and adapting
code, a bit similar to what you did with the BPF "burst" packet scheduler.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-03-21 11:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 1:49 [PATCH mptcp-next v1 0/4] BPF path manager, part 7 Geliang Tang
2025-03-21 1:49 ` [PATCH mptcp-next v1 1/4] bpf: Add mptcp path manager struct_ops Geliang Tang
2025-03-21 10:59 ` Matthieu Baerts
2025-03-24 10:26 ` Matthieu Baerts
2025-03-24 10:43 ` Geliang Tang
2025-03-24 11:06 ` Matthieu Baerts
2025-03-25 4:15 ` Geliang Tang
2025-03-25 10:39 ` Matthieu Baerts
2025-03-21 1:49 ` [PATCH mptcp-next v1 2/4] bpf: Export mptcp path manager kfuncs Geliang Tang
2025-03-21 11:11 ` Matthieu Baerts
2025-03-21 1:49 ` [PATCH mptcp-next v1 3/4] selftests/bpf: Add mptcp netlink pm subtest Geliang Tang
2025-03-21 11:21 ` Matthieu Baerts [this message]
2025-03-21 1:49 ` [PATCH mptcp-next v1 4/4] selftests/bpf: Add mptcp bpf_netlink " Geliang Tang
2025-03-21 2:20 ` [PATCH mptcp-next v1 0/4] BPF path manager, part 7 MPTCP CI
2025-03-21 2:59 ` MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71091cdf-6fa7-4816-9d67-e80273a94fb1@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.