Re: [PATCH 2/8] ata: libata-scsi: do not accept subpage code FFh in MODE SELECT

[Damien Le Moal <dlemoal@kernel.org>]

On 11/4/26 05:54, Niklas Cassel wrote:
> When the SUBPAGE CODE of the mode page in a MODE SELECT parameter list
> is FFh, ata_scsi_mode_select_xlat() rejects it for the control mode
> page, but accepts it for all other mode pages, i.e. for the caching
> mode page, the only other mode page that it supports.
> 
> However, FFh is not the subpage code of an actual mode page: SPC-7
> (7.5.2) only defines it as the MODE SENSE request code for all
> subpages. SUBPAGE CODE FFh only means "all subpages" in requests, i.e.
> in the MODE SENSE CDB for mode pages and in the LOG SELECT CDB for log
> pages (see SPC-5, 6.8), while the SUBPAGE CODE of a mode page in a MODE
> SELECT parameter list identifies a specific mode page. Also, SAT-2 and
> later versions of SAT define the Caching mode page with the SPF bit set
> to zero (see SAT-6, 10.4.9), i.e. without a SUBPAGE CODE field.
> 
> Remove the ALL_SUB_MPAGES case, so that SUBPAGE CODE FFh is rejected
> like any other unsupported subpage.
> 
> Fixes: 1b26d29ccd59 ("[libata] scsi: implement MODE SELECT command")
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research