All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: gang.yan@linux.dev, mptcp@lists.linux.dev
Subject: Re: [RESEDN PATCH mptcp-net] mptcp: update window_clamp on subflows when SO_RCVBUF is set
Date: Mon, 20 Apr 2026 11:35:19 +0200	[thread overview]
Message-ID: <711cd795-c309-4d33-873d-d049df48622c@kernel.org> (raw)
In-Reply-To: <7b58555aba7fc56f135ee198a592e4d72e01f849@linux.dev>

On 20/04/2026 11:31, gang.yan@linux.dev wrote:
> -------- Forwarded message -------
> 
> From: gang.yan@linux.dev mailto:gang.yan@linux.dev 
> To: "Matthieu Baerts" <matttbe@kernel.org mailto:matttbe@kernel.org?to=%22Matthieu%20Baerts%22%20%3Cmatttbe%40kernel.org%3E >
> Sent: April 20, 2026 at 5:30 PM
> Subject: Re: [RESEDN PATCH mptcp-net] mptcp: update window_clamp on subflows when SO_RCVBUF is set
> 
> April 20, 2026 at 5:24 PM, "Matthieu Baerts" <matttbe@kernel.org mailto:matttbe@kernel.org?to=%22Matthieu%20Baerts%22%20%3Cmatttbe%40kernel.org%3E > wrote:
> 
> 
> 
>>
>> Hi Gang,
>>  
>>  On 20/04/2026 10:56, Gang Yan wrote:
>>  
>>  
>>  From: Gang Yan <yangang@kylinos.cn>
>>  
>>  Add __mptcp_subflow_set_rcvbuf() helper that calls the tcp_set_rcvbuf
>>  to update window_clamp, in addition to writing sk_rcvbuf. Use it in
>>  both mptcp_sol_socket_sync_intval() (setsockopt path) and
>>  sync_socket_options() (new subflow creation path).
>>  
>>  I didn't review the code yet, but just a note for next time: please
>>  don't use the RESEND tag if you did a modification, even if it is only
>>  in the commit message. Instead, increment the version and add a
>>  changelog describing the modifications.
>>
> Thanks for the advice and reminder!
> 
> The reason I sent this patch with the RESEND tag is that I wanted to
> trigger the CI checks, especially the AI reivew, to see if there are any
> issues that need to be fixed. It seems my previous patch didn't properly
> trigger those tests.

Strange, I don't see your previous patch on Patchew:

  https://patchew.org/MPTCP/

And sashiko had some issues with it:


https://sashiko.dev/#/patchset/20260416122945.324166-1-gang.yan%40linux.dev

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


  reply	other threads:[~2026-04-20  9:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20  8:56 [RESEDN PATCH mptcp-net] mptcp: update window_clamp on subflows when SO_RCVBUF is set Gang Yan
2026-04-20  9:24 ` Matthieu Baerts
     [not found]   ` <759c28ad07974bee4f83d69bd85ab5477690c0da@linux.dev>
2026-04-20  9:31     ` gang.yan
2026-04-20  9:35       ` Matthieu Baerts [this message]
2026-04-23 16:30 ` MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=711cd795-c309-4d33-873d-d049df48622c@kernel.org \
    --to=matttbe@kernel.org \
    --cc=gang.yan@linux.dev \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.