From: Ihor Solodrai <ihor.solodrai@linux.dev>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Yonghong Song <yonghong.song@linux.dev>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com, Martin KaFai Lau <martin.lau@kernel.org>
Subject: Re: [PATCH bpf-next 0/4] selftests/bpf: Fix a few test failures with arm64 64KB page
Date: Fri, 6 Jun 2025 09:37:37 -0700 [thread overview]
Message-ID: <711f5fb8-b4c2-49d7-9c7a-bd300f6da040@linux.dev> (raw)
In-Reply-To: <CAEf4Bzb+rPo6bfYe71vOzAsqQb4JM6Gu-Hi66qPj0ioF=PFF9g@mail.gmail.com>
On 6/6/25 9:30 AM, Andrii Nakryiko wrote:
> On Thu, Jun 5, 2025 at 8:23 PM Yonghong Song <yonghong.song@linux.dev> wrote:
>>
>> My local arm64 host has 64KB page size and the VM to run test_progs
>> also has 64KB page size. There are a few self tests assuming 4KB page
>> and hence failed in my envorinment. Patch 1 tries to reduce long assert
>
> typo: environment
>
>> logs when tail failed. Patches 2-4 fixed three selftest failures.
>
> How come our BPF CI doesn't catch this on aarch64?.. Ihor, any thoughts?
Because our aarch64 hosts use 4K pagesize...
$ uname -a
Linux ip-10-0-0-103.us-west-1.compute.internal
5.10.228-219.884.amzn2.aarch64 #1 SMP Wed Oct 23 17:17:31 UTC 2024
aarch64 aarch64 aarch64 GNU/Linux
[ec2-user@ip-10-0-0-103 ~]$ getconf PAGESIZE
4096
>
>>
>> Yonghong Song (4):
>> selftests/bpf: Reduce test_xdp_adjust_frags_tail_grow logs
>> selftests/bpf: Fix bpf_mod_race test failure with arm64 64KB page size
>> selftests/bpf: Fix ringbuf/ringbuf_write test failure with arm64 64KB
>> page size
>> selftests/bpf: Fix a user_ringbuf failure with arm64 64KB page size
>>
>> .../selftests/bpf/prog_tests/bpf_mod_race.c | 2 +-
>> .../testing/selftests/bpf/prog_tests/ringbuf.c | 5 +++--
>> .../selftests/bpf/prog_tests/user_ringbuf.c | 6 ++++--
>> .../selftests/bpf/prog_tests/xdp_adjust_tail.c | 18 ++++++++++++------
>> .../selftests/bpf/progs/test_ringbuf_write.c | 5 +++--
>> 5 files changed, 23 insertions(+), 13 deletions(-)
>>
>> --
>> 2.47.1
>>
next prev parent reply other threads:[~2025-06-06 16:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 3:23 [PATCH bpf-next 0/4] selftests/bpf: Fix a few test failures with arm64 64KB page Yonghong Song
2025-06-06 3:23 ` [PATCH bpf-next 1/4] selftests/bpf: Reduce test_xdp_adjust_frags_tail_grow logs Yonghong Song
2025-06-06 3:23 ` [PATCH bpf-next 2/4] selftests/bpf: Fix bpf_mod_race test failure with arm64 64KB page size Yonghong Song
2025-06-06 3:23 ` [PATCH bpf-next 3/4] selftests/bpf: Fix ringbuf/ringbuf_write " Yonghong Song
2025-06-06 3:23 ` [PATCH bpf-next 4/4] selftests/bpf: Fix a user_ringbuf " Yonghong Song
2025-06-06 5:52 ` Yonghong Song
2025-06-06 6:00 ` Yonghong Song
2025-06-06 16:30 ` [PATCH bpf-next 0/4] selftests/bpf: Fix a few test failures with arm64 64KB page Andrii Nakryiko
2025-06-06 16:37 ` Ihor Solodrai [this message]
2025-06-06 16:43 ` Yonghong Song
2025-06-06 16:49 ` Ihor Solodrai
2025-06-06 16:57 ` Andrii Nakryiko
2025-06-06 17:15 ` Ihor Solodrai
2025-06-06 18:21 ` Andrii Nakryiko
2025-06-06 17:03 ` Yonghong Song
2025-06-06 17:19 ` Ihor Solodrai
2025-06-06 18:11 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=711f5fb8-b4c2-49d7-9c7a-bd300f6da040@linux.dev \
--to=ihor.solodrai@linux.dev \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.