From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F0FC433DB for ; Thu, 21 Jan 2021 14:11:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F20E9239D4 for ; Thu, 21 Jan 2021 14:11:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F20E9239D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Nc894jTkYXnObs4EYrX7i4zo2DPPUk10r7N61h0+UJw=; b=RPovlk/THAJ4bVCa1sTpye4/Z QU1alnMUYkw5ND2DgvZxSOCoUoCAb8xUXqJCtNRrYB4y0bA7LxRmackvN3+/498vW1e9EkjcuCYqu do6vv7mn8rGgENxzvuQFS4n83N/xBnb6UtnnYsT5Yjfrv39csnDboojW+cwXjPicpFEixTmvvWw55 hMuC2i3obqV2+F/pp95N0iLaPK3UCNLlSf3zweDzbkt649a75wb5dz3d7Mmw1UjZTijxF+bm3rEbk GuITYK7Br1elGhHq8ixpHKjs6lpFJPAj1jBTXl7/9QDozxl60m1QEJOipn6ChmRrpBJ3q2URRQ7E4 4E596AWbQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2afR-0004mk-JN; Thu, 21 Jan 2021 14:10:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2afP-0004mI-Q9 for linux-arm-kernel@lists.infradead.org; Thu, 21 Jan 2021 14:10:32 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC657239A4; Thu, 21 Jan 2021 14:10:30 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l2afM-009Cst-QC; Thu, 21 Jan 2021 14:10:28 +0000 MIME-Version: 1.0 Date: Thu, 21 Jan 2021 14:10:28 +0000 From: Marc Zyngier To: Mohamed Mediouni Subject: Re: [RFC PATCH 7/7] irqchip/apple-aic: add SMP support to the Apple AIC driver. In-Reply-To: <2861E21B-32B9-479E-A5F6-528D021183E6@caramail.com> References: <20210120132717.395873-1-mohamed.mediouni@caramail.com> <20210120132717.395873-8-mohamed.mediouni@caramail.com> <71e94b48857cbdd21c5d6bdadf148621@kernel.org> <2861E21B-32B9-479E-A5F6-528D021183E6@caramail.com> User-Agent: Roundcube Webmail/1.4.10 Message-ID: <7131f110736b8a17c824f39abeeaf711@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: mohamed.mediouni@caramail.com, arnd@kernel.org, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, catalin.marinas@arm.com, marcan@marcan.st, linux-kernel@vger.kernel.org, will@kernel.org, stan@corellium.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_091031_920325_6E6FF103 X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Arnd Bergmann , Catalin Marinas , Hector Martin , linux-kernel@vger.kernel.org, Will Deacon , Linux ARM , Stan Skowronek Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMS0wMS0yMSAxMzozNCwgTW9oYW1lZCBNZWRpb3VuaSB3cm90ZToKPj4gT24gMjEgSmFu IDIwMjEsIGF0IDE0OjIyLCBNYXJjIFp5bmdpZXIgPG1hekBrZXJuZWwub3JnPiB3cm90ZToKPj4g Cj4+IE9uIDIwMjEtMDEtMjEgMTI6NTAsIE1vaGFtZWQgTWVkaW91bmkgd3JvdGU6Cj4+Pj4gT24g MjEgSmFuIDIwMjEsIGF0IDEzOjQ0LCBBcm5kIEJlcmdtYW5uIDxhcm5kQGtlcm5lbC5vcmc+IHdy b3RlOgo+Pj4+IE9uIFdlZCwgSmFuIDIwLCAyMDIxIGF0IDI6MjcgUE0gTW9oYW1lZCBNZWRpb3Vu aQo+PiAKPj4gWy4uLl0KPj4gCj4+Pj4+ICsgICAgICAgYWljLmZhc3RfaXBpID0gb2ZfcHJvcGVy dHlfcmVhZF9ib29sKG5vZGUsICJmYXN0LWlwaSIpOwo+Pj4+IFdoZXJlIGlzIHRoaXMgcHJvcGVy dHkgZG9jdW1lbnRlZCwgYW5kIHdoYXQgZGVjaWRlcyB3aGljaCBvbmUgdG8gCj4+Pj4gdXNlPwo+ Pj4gSXTigJlzIGdldHRpbmcgZG9jdW1lbnRlZCBpbiB0aGUgbmV4dCBwYXRjaCBzZXQuCj4+PiBU aGlzIHByb3BlcnR5IGlzIHRoZXJlIHRvIGVuYWJsZSBzdXBwb3J0IGZvciBvbGRlciBpUGhvbmUg cHJvY2Vzc29ycwo+Pj4gbGF0ZXIgb24sIHNvbWUgb2Ygd2hpY2ggZG8gbm90IGhhdmUgZmFzdCBJ UEkgc3VwcG9ydC4KPj4+IE9uIEFwcGxlIE0xLCBmYXN0LWlwaSBpcyBhbHdheXMgb24uCj4+IAo+ PiBUaGVuIHBsZWFzZSBmb2N1cyBvbiBhIHNpbmdsZSBpbXBsZW1lbnRhdGlvbi4gQWRkaXRpb25h bCBmZWF0dXJlcyBjYW4KPj4gYWx3YXlzIGJlIG1lcmdlZCBsYXRlciBvbmNlIHNvbWV0aGluZyBp cyB1cCBhbmQgcnVubmluZy4KPj4gCj4+IEFsc28sIHRoZXJlIHN5c3JlZ3MgY2FuIGJlIGRldGVj dGVkIGJ5IG1hdGNoaW5nIHRoZSBNSURSLCBzbyBJIGRvbid0Cj4+IHRoaW5rIHdlIG5lZWQgYSBE VCBwcm9wZXJ0eSBmb3IgdGhhdC4KPj4gCj4+IFRoYW5rcywKPj4gCj4gQmVjYXVzZSBVQVJUIGFj Y2VzcyBhZGFwdGVycyBmb3IgdGhlIG5ldyBNMSBNYWNzIGFyZW7igJl0IHBsZW50aWZ1bAo+IGF0 IGFsbCwgSSBhY3R1YWxseSB1c2UgdGhpcyBmb3IgZGV2ZWxvcG1lbnQsIHdpdGggaVBob25lcyB3 aGljaCBoYXZlCj4gbXVjaCBtb3JlIGVhc3kgdG8gYnV5IExpZ2h0bmluZy10by1VQVJUIGFkYXB0 ZXJzLgo+IAo+IChUaGF04oCZcyB3aHkgdGhlIG9sZCBpbXBsZW1lbnRhdGlvbiBpcyB0aGVyZSB0 b28pCj4gCj4gTWlnaHQgYmUgd29ydGggc3BsaXR0aW5nIHRoZSBuZXcgb25lIHRvIGEgbmV3IGNv bW1pdCB0aG91Z2guLi4KClRoaXMgc2VyaWVzIGlzIHN1cHBvc2VkIHRvIGNvdmVyIE0xIG9ubHks IGFuZCBhZGRpbmcgZXh0cmEgc3VwcG9ydAphcyBwYXJ0IG9mIGl0IGlzIG9ubHkgbGlrZWx5IHRv IG1ha2UgdGhlIGNvZGUgaGFyZGVyIHRvIHJldmlldy4KCkknZCByYXRoZXIgeW91IGZvY3VzIG9u IGEgc2luZ2xlIElQSSBpbnRlcmZhY2UgKGZhc3Qgb3Igc2xvdywKSSBkb24ndCByZWFsbHkgY2Fy ZSkuIEV4dHJhIGZlYXR1cmVzIGNhbiBjb21lIGluIGxhdGVyLgoKVGhhbmtzLAoKICAgICAgICAg TS4KLS0gCkphenogaXMgbm90IGRlYWQuIEl0IGp1c3Qgc21lbGxzIGZ1bm55Li4uCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA811C433DB for ; Thu, 21 Jan 2021 14:17:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9244239D4 for ; Thu, 21 Jan 2021 14:17:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729161AbhAUORR (ORCPT ); Thu, 21 Jan 2021 09:17:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:58166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731060AbhAUOLO (ORCPT ); Thu, 21 Jan 2021 09:11:14 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC657239A4; Thu, 21 Jan 2021 14:10:30 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l2afM-009Cst-QC; Thu, 21 Jan 2021 14:10:28 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 21 Jan 2021 14:10:28 +0000 From: Marc Zyngier To: Mohamed Mediouni Cc: Arnd Bergmann , Linux ARM , Mark Rutland , Catalin Marinas , Hector Martin , linux-kernel@vger.kernel.org, Will Deacon , Stan Skowronek Subject: Re: [RFC PATCH 7/7] irqchip/apple-aic: add SMP support to the Apple AIC driver. In-Reply-To: <2861E21B-32B9-479E-A5F6-528D021183E6@caramail.com> References: <20210120132717.395873-1-mohamed.mediouni@caramail.com> <20210120132717.395873-8-mohamed.mediouni@caramail.com> <71e94b48857cbdd21c5d6bdadf148621@kernel.org> <2861E21B-32B9-479E-A5F6-528D021183E6@caramail.com> User-Agent: Roundcube Webmail/1.4.10 Message-ID: <7131f110736b8a17c824f39abeeaf711@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: mohamed.mediouni@caramail.com, arnd@kernel.org, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, catalin.marinas@arm.com, marcan@marcan.st, linux-kernel@vger.kernel.org, will@kernel.org, stan@corellium.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-21 13:34, Mohamed Mediouni wrote: >> On 21 Jan 2021, at 14:22, Marc Zyngier wrote: >> >> On 2021-01-21 12:50, Mohamed Mediouni wrote: >>>> On 21 Jan 2021, at 13:44, Arnd Bergmann wrote: >>>> On Wed, Jan 20, 2021 at 2:27 PM Mohamed Mediouni >> >> [...] >> >>>>> + aic.fast_ipi = of_property_read_bool(node, "fast-ipi"); >>>> Where is this property documented, and what decides which one to >>>> use? >>> It’s getting documented in the next patch set. >>> This property is there to enable support for older iPhone processors >>> later on, some of which do not have fast IPI support. >>> On Apple M1, fast-ipi is always on. >> >> Then please focus on a single implementation. Additional features can >> always be merged later once something is up and running. >> >> Also, there sysregs can be detected by matching the MIDR, so I don't >> think we need a DT property for that. >> >> Thanks, >> > Because UART access adapters for the new M1 Macs aren’t plentiful > at all, I actually use this for development, with iPhones which have > much more easy to buy Lightning-to-UART adapters. > > (That’s why the old implementation is there too) > > Might be worth splitting the new one to a new commit though... This series is supposed to cover M1 only, and adding extra support as part of it is only likely to make the code harder to review. I'd rather you focus on a single IPI interface (fast or slow, I don't really care). Extra features can come in later. Thanks, M. -- Jazz is not dead. It just smells funny...