From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mO4k5-0004f2-TQ for mharc-grub-devel@gnu.org; Wed, 08 Sep 2021 17:04:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mO4k4-0004df-4h for grub-devel@gnu.org; Wed, 08 Sep 2021 17:04:24 -0400 Received: from mout.gmx.net ([212.227.17.21]:57161) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mO4k2-0004pJ-Ax for grub-devel@gnu.org; Wed, 08 Sep 2021 17:04:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1631135060; bh=tAdt6PDNBF8oNi+/R8b2mTHC4oUxziTrUsyKikTLVIw=; h=X-UI-Sender-Class:Date:From:To:Subject:References:In-Reply-To; b=Ivzs60e/dEq8WwEMR4aIWgbBfKOb/ey7t2PcEXdyR/naXZon349fJ4ceYHVXY1HH8 eXa4PQQ/0ODUm0zywU1FKzKy7m8FwIJqraM9pccLi3itSGyfFlCULFd1JeRM4Kytp5 dkqaBlZrjx1TqIv6KGzuvkrOSU0SmiH49Reks9Zk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from scdbackup.webframe.org ([79.222.32.79]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MG9kC-1m9lPD46cG-00GZYX for ; Wed, 08 Sep 2021 23:04:20 +0200 Date: Wed, 08 Sep 2021 23:03:39 +0200 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: Re: [PATCH] [PATCH] tests: Keep grub-fs-tester ziso9660 from failing for wrong reasons Content-Type: text/plain; charset="utf-8" References: <20210908190445.fv6zartuu4js5eqc@tomti.i.net-space.pl> In-Reply-To: <20210908190445.fv6zartuu4js5eqc@tomti.i.net-space.pl> Message-Id: <7135362548759968545@scdbackup.webframe.org> X-Provags-ID: V03:K1:Kvd+ysBo7f2EtdfmHsX23f+vW2CJmWZ7PoVzlAPGKVVg2zuVcx9 KDTyiiJE5igDKjFUZwFImtPvlszf+mg420yWPIpxkIgGOwYnMQkHcemCQGRRIViWqzQN/V2 Tf6pEvAZVqyjpg8Qt4uOWjVRFf2HEOVNt/d7/J9UV9hR2l5sYfNgyT/H/P5U/g9J7LhM4gi J3bLYZISdDoKjg8gm8rgw== X-UI-Out-Filterresults: notjunk:1;V03:K0:Ecbvz9FfZz0=:goivY0Rnp18mo2zc+7ybuz FThVQ/gk9/RR2Nnx4X6Nzq5Ex7Zc5NFKqgcaHbzYxJxRMjdHRvSaZJGworUNj2JD5gkM3TLfU ZPIQLfBM8Zam3rI+aodCnXWOmPtZjkGs/W1N9Z1uXjoHOVwjDgZ5rnTK1YbOWuzwNwaQ96x+Y q9uy86SHqwXhSphfkH0FdDGrb2nDzpMAD7AW8oP9wStbhE9pyGeASBsba1wi9glzyUt0tgTJF QEnjMuvkxJ02tQyaFd9QW3kAD1W1RlGLWtRIL8CUaznfURmkCVDGsza56IZPBWtNNDxSQQmvJ bkMOpjiC1/HPBVhG3ICBUtGrMN+AxnXu3+O08qHhkkLlO21sFVD2DFjsKaXwI6dfzjywuDNKm egEo0hQe8YGN+2k+xZWNFUR8drJgUulfdKpsnYbdlo0m+GTPtZzUdC+7y/vo1MkADQ4Ip1Cqz emNHZUIJ2R/RpXmk7aoaYMl5nWKOupUgVDR/KdbDYTkVfYVB2ycLScTsSNdPH9Wf1IR+h7hcn LPJU0qdvSJ86QNDrF061158OWhcrmuIABIUOo16bMeJkUwUxQ48UuSljgH/M8I0+DjzkImmgA N6kn3/jml9vgB3uBab56h4HxX3LVPAdI2JTHr4t8HusjJH5QsfVsfaHLMB8GhjAVLRxE2FEPn NAFau2jb+PSeH/4FdGj+bos4/UdvBLruSEHAqo7310zyOPYHuJmtgeS08N/jAS14pwPJS/I0M hM73mmCxyYvym63f2KFZCG6teliR21Sc0Zr/fLP3aa1sKn4mnZ8hd4HUAeUjpH7KkOmcHdMJQ dlyfw6XSTeXW8mj18LxKDQoOrT6gOZFhU/80kwJrynf8WZYxITz0BzIqlQt0ph35kS7CRRKFQ Hlu6+NSUYqktt6HLT7G2/Dv3ACYDH7hhtbye7u4UGyjvTGEuTFcUghG8XoDgY+fw4ULQUyryT 0M89KC70pxE7JdE+95PHHO1FdJLMtsfS13tqVboKcO7L4yv1SID9AaMq02frrk9j4//txHu7X 9GLdQuTYNZiCxK+5ZE+4memsVUtUjmWcbe/Li+G94B6zU0hKsTIowUcLHVaqm5JqJaBedLTYW gQrB8tt1NmPhDI= Received-SPF: pass client-ip=212.227.17.21; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 21:04:24 -0000 Hi, i am working on the requested changes. In my patch message i wrote: > > A bug > > in xorriso causes a distracting warning about FSLABEL being too long for > > Joliet. Shortcommings of Joliet cause warnings about symbolic links. Daniel Kiper wrote: > s/links./links too./? Rather not. Both warnings have very different reasons. The xorriso bug was that the warning came if more than 16 bytes of volume id are submitted. The correct test is to count the UCS-2 characters after conversion from the local character set (meanwhile surely UTF-8). The FSLABEL which is prepared by grub-fs-tester for ISO 9660 tests has only 15 characters but 32 UTF-8 bytes. The shortcomming of Joliet is in its specs. It was invented by Microsoft Inc. for presenting Microsoft filesystem names. At least back in 1995 no symbolic links were desired for their version of ISO 9660. Other than the xorriso bug i cannot fix this. Both warnings could deceive the reader of the test report, especially since the test is expected to fail. Thus my patch disables Joliet to silence both for all xorriso versions. > I have an itching to ask you to split this thing into two patches. I decided against this because the test would indicate false success after the early failure because of the FSLABEL length is fixed. If i fix the xorriso command sequence problem first, then this first patch does not have any effect at run time. So i rather consider the ziso9660 test as untested sketch which i replace by a working test with proper failure as long as no zisofs decompression is implemented. > You described everything in the commit message what you are doing here > except of "-set_filter_r --zisofs -- -zisofs default" games. Could you > explain that too? Will try without copying a whole paragraph from man xorriso. Have a nice day :) Thomas